Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 11 Aug 2023 15:56:50 +0200
From:   Petr Mladek <pmladek@suse.com>
To:     John Ogness <john.ogness@linutronix.de>
Cc:     Sergey Senozhatsky <senozhatsky@chromium.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH printk v2 0/8] wire up nbcon consoles
Message-ID: <ZNY-IhuJJMZuFAHz@alley>
References: <20230728000233.50887-1-john.ogness@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230728000233.50887-1-john.ogness@linutronix.de>
Precedence: bulk

On Fri 2023-07-28 02:08:25, John Ogness wrote:
> Hi,
> 
> This is v2 of a series to introduce the new non-BKL (nbcon)
> consoles. This series is only a subset of the original
> v1 [0]. In particular, this series represents patches 5-10 of
> the v1 series. For information about the motivation of the
> atomic consoles, please read the cover letter of v1.
> 
> This series focuses on wiring up the printk subsystem to
> be able to use the nbcon consoles and implement their ownership
> interfaces and rules. This series does _not_ include threaded
> printing, atomic printing regions, or nbcon drivers. Those
> features will be added in separate follow-up series.
> 
> 
>  include/linux/console.h      | 132 +++++
>  kernel/printk/Makefile       |   2 +-
>  kernel/printk/internal.h     |  29 ++
>  kernel/printk/printk.c       | 156 ++++--
>  kernel/printk/printk_nbcon.c | 955 +++++++++++++++++++++++++++++++++++

Nit: Is there still any chance to rename this to kernel/printk/nbcon.c ?

I am sorry that I did not suggested this earlier. I think that
we should have omitted the "printk_" prefix even for
the "ringbuffer.*" files.

I think that it came from "printk_safe.c". But it made some sense.
"printk_safe_*" was also an API.

But in general, "printk_" prefix is superfluous in "printk" directory.

Best Regards,
Petr