Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230810095949.123473-1-krzysztof.kozlowski@linaro.org>
In-Reply-To: <20230810095949.123473-1-krzysztof.kozlowski@linaro.org>
From:   Bartosz Golaszewski <brgl@bgdev.pl>
Date:   Fri, 11 Aug 2023 16:22:06 +0200
Message-ID: <CAMRc=MccHyVtv10YVbsP7x5zSsFYiPTKbTsSaqEPWKp7ewHtPA@mail.gmail.com>
Subject: Re: [PATCH] gpio: mxs: fix Wvoid-pointer-to-enum-cast warning
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Andy Shevchenko <andy@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, Andi Shyti <andi.shyti@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Aug 10, 2023 at 11:59=E2=80=AFAM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> 'devid' is an enum, thus cast of pointer on 64-bit compile test with W=3D=
1
> causes:
>
>   gpio-mxs.c:274:16: error: cast to smaller integer type 'enum mxs_gpio_i=
d' from 'const void *' [-Werror,-Wvoid-pointer-to-enum-cast]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  drivers/gpio/gpio-mxs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-mxs.c b/drivers/gpio/gpio-mxs.c
> index 8e04c9c4b5a2..024ad077e98d 100644
> --- a/drivers/gpio/gpio-mxs.c
> +++ b/drivers/gpio/gpio-mxs.c
> @@ -271,7 +271,7 @@ static int mxs_gpio_probe(struct platform_device *pde=
v)
>         port->id =3D of_alias_get_id(np, "gpio");
>         if (port->id < 0)
>                 return port->id;
> -       port->devid =3D (enum mxs_gpio_id)of_device_get_match_data(&pdev-=
>dev);
> +       port->devid =3D (uintptr_t)of_device_get_match_data(&pdev->dev);
>         port->dev =3D &pdev->dev;
>         port->irq =3D platform_get_irq(pdev, 0);
>         if (port->irq < 0)
> --
> 2.34.1
>

Applied, thanks!

Bart