Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-624-g7714e4406d-fm-20230801.001-g7714e440
Mime-Version: 1.0
Message-Id: <ef7d94a4-9f65-47fb-906a-4fed4480d020@app.fastmail.com>
In-Reply-To: <97764bad-7091-e9ed-6f49-d31861fc622f@linux.intel.com>
References: <20230811130948.2211800-1-arnd@kernel.org>
 <97764bad-7091-e9ed-6f49-d31861fc622f@linux.intel.com>
Date:   Fri, 11 Aug 2023 17:02:01 +0200
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        "Arnd Bergmann" <arnd@kernel.org>
Cc:     "Hans de Goede" <hdegoede@redhat.com>,
        "Mark Gross" <markgross@kernel.org>,
        "xingtong.wu" <xingtong.wu@siemens.com>,
        "Nathan Chancellor" <nathan@kernel.org>,
        "Nick Desaulniers" <ndesaulniers@google.com>,
        "Tom Rix" <trix@redhat.com>,
        "Henning Schild" <henning.schild@siemens.com>,
        "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
        "Lee Jones" <lee@kernel.org>, platform-driver-x86@vger.kernel.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] platform/x86/siemens: simatic-ipc: fix nonsensical condition
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Aug 11, 2023, at 15:17, Ilpo J=C3=A4rvinen wrote:
> On Fri, 11 Aug 2023, Arnd Bergmann wrote:
>
>> From: Arnd Bergmann <arnd@arndb.de>
>>=20
>> The condition checking for a constant SIMATIC_IPC_DEVICE_BX_59A value
>> clearly makes no sense, as clang warns:
>>=20
>> drivers/platform/x86/siemens/simatic-ipc.c:132:42: error: use of logi=
cal '||' with constant operand [-Werror,-Wconstant-logical-operand]
>>                 if (ledmode =3D=3D SIMATIC_IPC_DEVICE_227G || SIMATIC=
_IPC_DEVICE_BX_59A)
>>                                                        ^  ~~~~~~~~~~~=
~~~~~~~~~~~~~~
>> drivers/platform/x86/siemens/simatic-ipc-batt.c:197:49: error: use of=
 logical '||' with constant operand [-Werror,-Wconstant-logical-operand]
>>                 if (priv.devmode =3D=3D SIMATIC_IPC_DEVICE_BX_21A || =
SIMATIC_IPC_DEVICE_BX_59A)
>>                                                               ^  ~~~~=
~~~~~~~~~~~~~~~~~~~~~
>>=20
>> Most likely, this was meant to check ledmode to be one of the two val=
ues,
>> so change it to that.
>>=20
>> Fixes: b8af77951941e ("platform/x86/siemens: simatic-ipc: add new mod=
els BX-56A/BX-59A")
>> Fixes: c56beff203754 ("platform/x86/siemens: simatic-ipc-batt: add su=
pport for module BX-59A")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Ok, I see. I missed those as there is hasn't been a new linux-next in
a few days.

I suppose this one is also fixed then?

WARNING: unmet direct dependencies detected for P2SB
  Depends on [n]: PCI [=3Dn] && X86 [=3Dy]
  Selected by [m]:
  - SIEMENS_SIMATIC_IPC_WDT [=3Dm] && WATCHDOG [=3Dy] && SIEMENS_SIMATIC=
_IPC [=3Dy]
drivers/platform/x86/p2sb.c:68:9: error: call to undeclared function 'pc=
i_scan_single_device'; ISO C99 and later do not support implicit functio=
n declarations [-Wimplicit-function-declaration]

     Arnd