Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Lopez, Jorge A (Security)" <jorge.lopez2@hp.com>
To:     =?iso-8859-1?Q?Ilpo_J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
CC:     "hdegoede@redhat.com" <hdegoede@redhat.com>,
        "markgross@kernel.org" <markgross@kernel.org>,
        "platform-driver-x86@vger.kernel.org" 
        <platform-driver-x86@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Abaci Robot <abaci@linux.alibaba.com>
Subject: RE: [PATCH] platform/x86: hp-bioscfg: Remove useless else
Thread-Topic: [PATCH] platform/x86: hp-bioscfg: Remove useless else
Thread-Index: AQHZzB4Jrsa7FfVgg0iiCdS6YCkah6/kvJ2AgAB+O6A=
Date:   Fri, 11 Aug 2023 15:41:58 +0000
Message-ID: <PH0PR84MB1953B73F3FD78882065549C8A810A@PH0PR84MB1953.NAMPRD84.PROD.OUTLOOK.COM>
References: <20230811062957.82728-1-jiapeng.chong@linux.alibaba.com>
 <2ec499b-c37e-0a9-c163-2a1591b56029@linux.intel.com>
In-Reply-To: <2ec499b-c37e-0a9-c163-2a1591b56029@linux.intel.com>
Accept-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?P5mz/66pOV13bduvXyrluJBFrHobLkAVRPVvnnC3uCHwQjxMjM4vADgpJx?=
 =?iso-8859-1?Q?ihiBFFCbLWQs0LOYXEqVZu9Iuv1YR/KL0aeMuY5I0xYxr3jjnCyEGusNyU?=
 =?iso-8859-1?Q?ICY5kkYm/SkycLfmElGE2VvgFggBszSf8fMnHNESjLFMuaNIKlvPbzgQLK?=
 =?iso-8859-1?Q?x3t/bFCYAg8kQmwYocMcxxXDZUhnZff0MSac22g3mEobd48D+koz4gZ3GL?=
 =?iso-8859-1?Q?NCAoenyosxfzXmkIDiYHWURVKI6BnqEaRes/6YirRQYNwtn4RRO9ZgGzch?=
 =?iso-8859-1?Q?wac26HiSRMwiZFdyopSaX/C/eEUQde1nI4YtN6221JqiYo2S6lUP3xNjAF?=
 =?iso-8859-1?Q?mPXlN/H3gq1U6PLEgYvsUwPRBG2SuWE333goa0lsBWfVZodHz2gA47b1Dz?=
 =?iso-8859-1?Q?+SRK44qN3cjoZcbuT5KaDtCaQ84zH+Dk7cxP1sFroD3gLd8UoAuG5jVZAU?=
 =?iso-8859-1?Q?AEL9NWYu71mCj7FVVAr15gsn/KjfnXNvyX+PKKuhCBcVUnyn/s3KBHuCxJ?=
 =?iso-8859-1?Q?gMvH4ZFj/6tUFpSmGSxPnE4nJi+vtvxkzPUtilbQflbAR9KaegVKgSOxM/?=
 =?iso-8859-1?Q?mQRIMJaJdGnbMQ23qNdDdaj5IqYpK5024AKHUUJz/o69TpW9fs0L4k6/oc?=
 =?iso-8859-1?Q?Awg8KYK2/DhnISfnW54Hxm7+m6TrAnUlD/onZbR6zT7aBn6HXDfio1xF/N?=
 =?iso-8859-1?Q?hD7FRQo8J/DLBCGjZDCHEKSGadq6PeYEuNMK0fZjcmk12n/WSI+gGDQdHe?=
 =?iso-8859-1?Q?30wHXoHDrh5rr13YA1ZRONx9YIY+x4qjMoTEUtJkbgxO7Ymris42h/dlkH?=
 =?iso-8859-1?Q?Yc2Y1R+Pgqfs1zD8QqC5ZF/2QLO7MQGVQeA/xyOOyg/ds94qjQVXpTQvO8?=
 =?iso-8859-1?Q?5ueai87cweJvzXwTDps90XuIrZmPuTxtyT4FN0UMlNxBg1AZjlhpE3q++9?=
 =?iso-8859-1?Q?KRuk4Qz/u/qTqqXSruUEGmIi4lk5eSVk1vZ/8dUbjcif2dTofleCPvjIaA?=
 =?iso-8859-1?Q?96Rg26oi5lJFV2gGV5g5vgbrW1QWBhZFhgX1wvJ9apfLE0ipT5tKDrZCAf?=
 =?iso-8859-1?Q?Ot1tWfCUazBueypVHwGxlhhCvNPLowAY+IlzIlgqw50fOaQtSTuU/y1Sbf?=
 =?iso-8859-1?Q?1VrU42gjV2e5H2tITfGY6R/Eun/cZ7+I0607p0s6cesbkXpwGd1kg/nuLR?=
 =?iso-8859-1?Q?PcbcykKzZyppF5TgZPL0rRLkxchCTAYWaTTFL75ZD5Yg5SrHtBJrNnsiOi?=
 =?iso-8859-1?Q?tpAnNMJFNXRAkXSMgqwaGKPUBDvAcv58HPhhFxKEpIXjdPQqmZJGqSDOIs?=
 =?iso-8859-1?Q?PU4hDwbJLIB/S4+0SM+pAqPl5Vw+ZZXljBWhe7KSGKF2IDGQQjrv2g0lu/?=
 =?iso-8859-1?Q?wJOe1qqU23ch0Mj9xMH+C/T5k+WmEoCrfdQNl35/MZXKFcwfi5ReKMSWjx?=
 =?iso-8859-1?Q?lS7sP4R/KFU91zgkGBhQKW2Glj8JVJqQQwYtf6Yc0YKpP7MxlYz/F6c6jA?=
 =?iso-8859-1?Q?cXlCbmEJP+9Sdaj+sLPjXfTL3iJNmBNR/VopMaQ/hGmkiKkMZCA1G9ZOGa?=
 =?iso-8859-1?Q?fk4iSdHFnT9LfpXs7e24R417WWHS+nxWo4W2r64bmzlXAP/hu3Xqwuw5B9?=
 =?iso-8859-1?Q?XkMr+5cT6t6iv6pr/dixc+x4uLRL3o/eTc?=
MIME-Version: 1.0
X-OriginatorOrg: hp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR84MB1953.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 4ba4714a-c82c-425c-e1a1-08db9a817f73
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Aug 2023 15:41:58.2815
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: ca7981a2-785a-463d-b82a-3db87dfc3ce6
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: zY1gfi2r7cPGMuJH7DIDDF6HpZAmTZOoH2iPLIealM9CXSmp3TyD5opFHWoAjkYQNWh6FmQCM86+o9hnQQvSbA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR84MB1818
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: hp.com
Content-Language: en-US
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The redundant code is a remnant code from test phase.
I concur with your changes which were approved in a separate email.


Regards,

Jorge Lopez
HP Inc

"Once you stop learning, you start dying"
Albert Einstein

> -----Original Message-----
> From: Ilpo J=E4rvinen <ilpo.jarvinen@linux.intel.com>
> Sent: Friday, August 11, 2023 3:04 AM
> To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> Cc: Lopez, Jorge A (Security) <jorge.lopez2@hp.com>;
> hdegoede@redhat.com; markgross@kernel.org; platform-driver-
> x86@vger.kernel.org; LKML <linux-kernel@vger.kernel.org>; Abaci Robot
> <abaci@linux.alibaba.com>
> Subject: Re: [PATCH] platform/x86: hp-bioscfg: Remove useless else
>=20
> CAUTION: External Email
>=20
> On Fri, 11 Aug 2023, Jiapeng Chong wrote:
>=20
> > The assignment of the else and if branches is the same, so the else
> > here is redundant, so we remove it.
> >
> > ./drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:545:3-5:
> WARNING: possible condition with no effect (if =3D=3D else).
> >
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> > ---
> >  .../platform/x86/hp/hp-bioscfg/passwdobj-attributes.c  | 10
> > ++--------
> >  1 file changed, 2 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c
> > b/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c
> > index 03d0188804ba..771e554182dc 100644
> > --- a/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c
> > +++ b/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c
> > @@ -541,14 +541,8 @@ void hp_exit_password_attributes(void)
> >               struct kobject *attr_name_kobj =3D
> >
> > bioscfg_drv.password_data[instance_id].attr_name_kobj;
> >
> > -             if (attr_name_kobj) {
> > -                     if (!strcmp(attr_name_kobj->name, SETUP_PASSWD))
> > -                             sysfs_remove_group(attr_name_kobj,
> > -                                                &password_attr_group);
> > -                     else
> > -                             sysfs_remove_group(attr_name_kobj,
> > -                                                &password_attr_group);
> > -             }
> > +             if (attr_name_kobj)
> > +                     sysfs_remove_group(attr_name_kobj,
> > + &password_attr_group);
> >       }
> >       bioscfg_drv.password_instances_count =3D 0;
> >       kfree(bioscfg_drv.password_data);
>=20
> While this is a valid observation, I wonder why you didn't change the cre=
ate
> side too?
>=20
> I hope it's not because you never took a look to understand the
> SETUP_PASSWD related code, it'd be pretty impossible to not notice it.
> This could have just as well have been a bug with inconsitent pairing aga=
inst
> create side, which is why reports from automated tools must not be
> implemented blindly but the related code must be understood first.
>=20
> --
>  i.