Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230810130600.25616-1-coolrrsh@gmail.com>
In-Reply-To: <20230810130600.25616-1-coolrrsh@gmail.com>
From:   Bartosz Golaszewski <brgl@bgdev.pl>
Date:   Fri, 11 Aug 2023 16:20:52 +0200
Message-ID: <CAMRc=Md4K1KwXiC69QqK_Kk02+4vEiu2Leir9OT4hy=jSzaXpA@mail.gmail.com>
Subject: Re: [PATCH v3] gpio: gpio-imx-scu: Use ARRAY_SIZE for array length
To:     coolrrsh@gmail.com
Cc:     linus.walleij@linaro.org, andy@kernel.org,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-kernel-mentees@lists.linuxfoundation.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Aug 10, 2023 at 3:06=E2=80=AFPM <coolrrsh@gmail.com> wrote:
>
> From: Rajeshwar R Shinde <coolrrsh@gmail.com>
>
> Use of macro ARRAY_SIZE to calculate array size minimizes
> the redundant code and improves code reusability.
> This fixes warnings reported by Coccinelle:
> drivers/gpio/gpio-imx-scu.c:106:32-33: WARNING: Use ARRAY_SIZE
>
> Signed-off-by: Rajeshwar R Shinde <coolrrsh@gmail.com>
> ---
> v1->v2
> ARRAY_SIZE calculates array length, so changed
> gc->ngpio =3D ARRAY_SIZE(scu_rsrc_arr)/sizeof(unsigned int) to
> gc->ngpio =3D ARRAY_SIZE(scu_rsrc_arr)
>
> v2->v3
> added linux/kernel.h containing ARRAY_SIZE definition
>
> ---
>  drivers/gpio/gpio-imx-scu.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-imx-scu.c b/drivers/gpio/gpio-imx-scu.c
> index e190bde5397d..13baf465aedf 100644
> --- a/drivers/gpio/gpio-imx-scu.c
> +++ b/drivers/gpio/gpio-imx-scu.c
> @@ -6,6 +6,7 @@
>   * to control the PIN resources on SCU domain.
>   */
>
> +#include <linux/kernel.h>
>  #include <linux/module.h>
>  #include <linux/gpio/driver.h>
>  #include <linux/platform_device.h>
> @@ -103,7 +104,7 @@ static int imx_scu_gpio_probe(struct platform_device =
*pdev)
>         gc =3D &priv->chip;
>         gc->base =3D -1;
>         gc->parent =3D dev;
> -       gc->ngpio =3D sizeof(scu_rsrc_arr)/sizeof(unsigned int);
> +       gc->ngpio =3D ARRAY_SIZE(scu_rsrc_arr);
>         gc->label =3D dev_name(dev);
>         gc->get =3D imx_scu_gpio_get;
>         gc->set =3D imx_scu_gpio_set;
> --
> 2.25.1
>

The commit title should be "gpio: imx-scu: ..."

I fixed it and applied.

Bart