Received: by 2002:a05:7412:6592:b0:d7:7d3a:4fe2 with SMTP id m18csp1087479rdg; Fri, 11 Aug 2023 09:16:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEKgmiRG+oAaI6koGsvU+x7ZgSaiPwThHYuPg6CPSPqFsffVUuuLCjQcnYkS+HFwLNoPROq X-Received: by 2002:a05:6a21:7898:b0:140:56b6:4137 with SMTP id bf24-20020a056a21789800b0014056b64137mr2779691pzc.52.1691770599345; Fri, 11 Aug 2023 09:16:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691770599; cv=none; d=google.com; s=arc-20160816; b=djR7qcK1tS3Cj+C7+xMVNrNKXHDJ0HWcpQLKPu22/Uqpvx5TZVlwZYtEkPr/0tuCzq ZA140jGbOiJAEfOvwTAw/pVxVg1GDd3t1kmfkz2dnI+jRVTH9muPkSSb+76WtIZuQVkV zKLogf9oZcRIwRwOxi+t42S2e7xIJpk0u/1nA01EmTn4cFhzetpRcm9uMp4b3f5vQL6u NLYrMFkJdKK6OkHUYbTIk/MyzNYSJWhmSn/8Uggeh1+KKV+A7BCfNuW6+DWx4z79TfM1 Erjrt+2BwPhAJc4MmsioqtjKSnqnCHjTsSUMfZ5RwyHRDoIvYp5WoF8hIQHhv4qqnqcw G6ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Mzquj8eTvhvEyz0nSaD8F2VvGcyfO5NM+CW4hTL1NQw=; fh=T1yZ0XHDXJOzAiGv4Z6PSdakJD3nf/R02BJQiICNXeU=; b=HmLsapq021CZGLnNHSOt1SCACSu2JVflnp2CgSNcUVh+GG/OAYWxtMZEdBNmXDSMIg VvLZ+3Xq9Jd+OgUhgBZDOcPCwz/coi4FdvHLkwVLUmPRCWTQAOWRvkYsusaV5B/ONo4p DozMmjmtiFvPdRvhC8QkQjrNrbRRn/kOlRxUoA5q/6etMwNff5Tw9ZI2PZJJTushR10g dknsG/FGAe1QMnzS2/gSNKznXLwAAyRctTeu+JEc7O0lmiAWC7y9fu674QlvD1Rp0CaD rhbb5N9zZ/WdYbBxNOUklSwwRTynSLhHboBlTlhdSOt9zTe7xr67a9tssfd5571GPVsp pAoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=EDHbNOOb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b75-20020a63344e000000b00563f7525babsi3609121pga.485.2023.08.11.09.16.25; Fri, 11 Aug 2023 09:16:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=EDHbNOOb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235243AbjHKP1W (ORCPT + 99 others); Fri, 11 Aug 2023 11:27:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229535AbjHKP1U (ORCPT ); Fri, 11 Aug 2023 11:27:20 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F788F5; Fri, 11 Aug 2023 08:27:20 -0700 (PDT) Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37BE5L7M023199; Fri, 11 Aug 2023 15:26:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=qcppdkim1; bh=Mzquj8eTvhvEyz0nSaD8F2VvGcyfO5NM+CW4hTL1NQw=; b=EDHbNOObH+THUyxh3BkK+qoHQ/le0emdST4x+V978qX/EqJFMb1Kooa889paOnZTKMJf gBxDuulNW7bp6EMafClvMWgMg2FPwIxa4kgAp9SR+7to/atrGGWj3Meh88Qq71oTJd+S pUvvuBfux0B659QjYHyb7+Mvbc5TarDS6I8w1ArtQH0G1IONj1lSut8TV6HRrhaDt6ez jFk49kewju3gyZHciAAnhI+xMnIfdcuSDxIZCkKn0N+k789Rua5PRWELngrtgMEosomm dzBmObml8obsg+YfGNSQRjuDet2lPM5C2ATCanwkoHEjz5DTnl5GgTPZNqitFZ1V8tur nw== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3sd8yda2cj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 11 Aug 2023 15:26:44 +0000 Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 37BFQhja009600 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 11 Aug 2023 15:26:43 GMT Received: from hu-bjorande-lv.qualcomm.com (10.49.16.6) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Fri, 11 Aug 2023 08:26:43 -0700 Date: Fri, 11 Aug 2023 08:26:41 -0700 From: Bjorn Andersson To: Konrad Dybcio CC: Andy Gross , Bjorn Andersson , Georgi Djakov , Mike Tipton , Neil Armstrong , Marijn Suijten , , , Subject: Re: [PATCH 1/2] interconnect: qcom: bcm-voter: Improve enable_mask handling Message-ID: <20230811152641.GR1428172@hu-bjorande-lv.qualcomm.com> References: <20230811-topic-icc_fix_1he-v1-0-5c96ccef3399@linaro.org> <20230811-topic-icc_fix_1he-v1-1-5c96ccef3399@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230811-topic-icc_fix_1he-v1-1-5c96ccef3399@linaro.org> X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01c.na.qualcomm.com (10.47.97.35) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: MFFk38_6czTssm7vmajHSBtUZ9HPpD75 X-Proofpoint-ORIG-GUID: MFFk38_6czTssm7vmajHSBtUZ9HPpD75 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-08-11_06,2023-08-10_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 phishscore=0 mlxlogscore=801 bulkscore=0 clxscore=1011 spamscore=0 priorityscore=1501 mlxscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308110141 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 11, 2023 at 01:55:07PM +0200, Konrad Dybcio wrote: > We don't need all the complex arithmetic for BCMs utilizing enable_mask, > as all we need to do is to determine whether there's any user (or > keepalive) asking for it to be on. > > Separate the logic for such BCMs for a small speed boost. > Suggested-by: Bjorn Andersson Reviewed-by: Bjorn Andersson Regards, Bjorn