Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Eric DeVolder <eric.devolder@oracle.com>
To:     linux-kernel@vger.kernel.org, david@redhat.com, osalvador@suse.de,
        corbet@lwn.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, x86@kernel.org, bhe@redhat.com,
        ebiederm@xmission.com, kexec@lists.infradead.org
Cc:     hpa@zytor.com, gregkh@linuxfoundation.org, rafael@kernel.org,
        vgoyal@redhat.com, dyoung@redhat.com, lf32.dev@gmail.com,
        akpm@linux-foundation.org, naveen.n.rao@linux.vnet.ibm.com,
        zohar@linux.ibm.com, bhelgaas@google.com, vbabka@suse.cz,
        tiwai@suse.de, seanjc@google.com, linux@weissschuh.net,
        vschneid@redhat.com, linux-mm@kvack.org, linux-doc@vger.kernel.org,
        sourabhjain@linux.ibm.com, konrad.wilk@oracle.com,
        boris.ostrovsky@oracle.com, eric.devolder@oracle.com
Subject: [PATCH v27 8/8] x86/crash: optimize CPU changes
Date:   Fri, 11 Aug 2023 13:06:42 -0400
Message-Id: <20230811170642.6696-9-eric.devolder@oracle.com>
In-Reply-To: <20230811170642.6696-1-eric.devolder@oracle.com>
References: <20230811170642.6696-1-eric.devolder@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rXmUMaZyptWiNWWt6YqcTHzWlQvQPeY5OqIDG4BtYojjk7uS6PeDSb+0WO2l?=
 =?us-ascii?Q?jlele7kieZpLm0LtduwmXVaI6eVrukHdjcq31FrICmgrxcKNMFQocmbuBMvM?=
 =?us-ascii?Q?yeMJsqsyDYaRFzs/ZO4TCmali2gPVYsbwFnJdl9Bb3YCX02Svv2G9Yqk8bdG?=
 =?us-ascii?Q?n9Jet461kz+J/A2J2qTMKrIGj5aMWeAEi0mD/NYDm4uQubQDrlSORY3V9BY1?=
 =?us-ascii?Q?zmnsOz8Oe1bApvjjbozkLzfgDGVjLxs90kXkcn0Sm2RzJoaRHxvzSpqJaMLs?=
 =?us-ascii?Q?kl35J6lpaJSN3mDNOfgTXyd2KedTiNojlonZ4+Wz5MTIMegUruxJCsrEWO+w?=
 =?us-ascii?Q?YmHUew8pvBQ6P4PPf1ifwKzMKjugVXw/45CZInIE33yuvNQAuuwLu7kd1eZv?=
 =?us-ascii?Q?YS6i0Vex3M6VYhUB8YWGWKCJPnBhumutFDmLfb0lEzoyYWlEGc/k5gHdljda?=
 =?us-ascii?Q?8Bo5bDfzPE8cdSMpwFWxYCyekaBJc9lTlc+ztD77HBI2rbdlmJ6yBNGo9NGq?=
 =?us-ascii?Q?R3ad5XYFRip+UvByeHLzKxOLAs6gYK4wYa2gP2/9Md9CrofDNWwinGdyyGYD?=
 =?us-ascii?Q?4R+sIPMe5qUP6/nlHrO9KfZwsa0dEhMi2Cq6OVixjcl8mNXTYPesiolUZII5?=
 =?us-ascii?Q?UWmIy8kOj7bme7Kop3iR0fm2UqGbcsAX7r0GTumEyV5fO7Irx0EX4Tb/gPr6?=
 =?us-ascii?Q?sBHlRiauD/T8Aj3zpJ+Q2/QLCoDPnkzQ1oRXLynK0dRPmTGYKl9Ps8PrkkVo?=
 =?us-ascii?Q?M9zDEzDRFjb3AJa0+nVcOQIn6CpxOLhJ+7rc1juHkOL5oj+58lq353mLwUKQ?=
 =?us-ascii?Q?zKyAFt/tAMiR7URLpycCmROI5X4b8UvrMP4xQMIUnQ9h/f7av5tgfTtMONP+?=
 =?us-ascii?Q?G6Dmj25PIWfyOp1P0iCxykTRbwzGSNhfnUs8fy63j+ujqmNxtWvTEKufeJdJ?=
 =?us-ascii?Q?19RaNvwWVSeN4fKm3g4n07A4hN45MrBWZ74jfGUh7mBixeiEebAc51WquOxl?=
 =?us-ascii?Q?RkjMU5U9LchW3mhVNR8nJ56uaupw/E6Q2Ow/FspYph1KkScbL6sDXrsHG+eg?=
 =?us-ascii?Q?oKZkKw4K4drCxcMcdJ4yCMpz1f6MZ5kizQ9fNEqVtIC8vw25gh0aWmiEmmdo?=
 =?us-ascii?Q?kpfJZmGWAP13P2zq+vSn4+J/kN8sSp7v4LR2HSr4iMG50IlCANh5xJXas0aa?=
 =?us-ascii?Q?i0mGWpL752GdiJq65XFAR+8tNLh/tk7kSagvIM/7c7CaeWIiNQKC7PwtNOn+?=
 =?us-ascii?Q?aajJ8euregJQTNnYgejmD9Re5X2bs0r62EHVItGwHOY3wkYF/hdcC1C9giEn?=
 =?us-ascii?Q?hPt8pbSXgJBv009VrHuZxBcRDAfEveRgNwEELKtOEdfmeU6EYFf6xH3JuYz+?=
 =?us-ascii?Q?TjhsHxuEGvwEjn0ysl6/SpUJdR82Tf7smBlMDcgG5U/DbrHU9/Vp+kRltSIA?=
 =?us-ascii?Q?CaDz5yMdasDocXo1WVl3KhO5OW+smHUBvoObNiccLtLYPpe6scI2e6Cwkpgm?=
 =?us-ascii?Q?/wsU0XB1HMy07Axb14WqhjooAEtzsXJ44yHgWq7W4KH1790LMDO0mltLElzE?=
 =?us-ascii?Q?0CYfKv3BYkEVo4E7FwJeU9L+byqKbK2QCLnbyRJqolIJUWQOTGdFNTY+R7vq?=
 =?us-ascii?Q?8w=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?eLo7UagzOAD/PCxcQ/ReIJkX3TN5ybBAwgzMroMCZCdKtomPNYt2ApNY7vL+?=
 =?us-ascii?Q?w/lYvGon+U+CO19wmAuwSAXd0pouJYpuoYJFmztlKq8+t2n/dS9jx+JfoLBS?=
 =?us-ascii?Q?Ixl63d2p/Z6O0LeZSxXf++4PzihzzGe0Z0k/Vbb62Nndg1J0lx5KAWVmTKFs?=
 =?us-ascii?Q?sEXUudahWWY7mdV1ka4LHhRGX7fUTVM0lbyJbDV2/+F1jQKgUS6q7pkrXMBR?=
 =?us-ascii?Q?htiliqtD3sQcdN3Ybmhq6k6m79z8RIK3/VuEePRXh1F50EOWWzF6c9eZfRTE?=
 =?us-ascii?Q?aRMcsqxxaN7Hz9M5mzUQTR3FP2gYHaUuk/RHoyqoAyqHhXGlyUdKr/51M6GM?=
 =?us-ascii?Q?GUXDYyVuE9G+4AHktNeoY7HNJRj4sDPLmhCJEKNIjueNtYNKgeHUrZPUFKLU?=
 =?us-ascii?Q?F5W934dEgJIirpA2w7XIv7HUyQKzoYFLwg+Z4Q2lo0eIaNUH6gVkLUTHcOQ0?=
 =?us-ascii?Q?z1dj2fBBrwJG6fXf25/5EuCtEgW3iR8XOV2zDfrZXm46s7Kd2hTL/tP7vfBv?=
 =?us-ascii?Q?Vo5uL/H09x7VQ2fvEuEQU+DdmCNnTPiDMZI4rLbJWUFEx8f1hZ1v1cb1dEpm?=
 =?us-ascii?Q?Tx3+9yxJdZhr/C1c/662d8mD/FwAXcOHcmlxhuQ15IPt0begd9lShWgD0b2t?=
 =?us-ascii?Q?EGzyQnMSAkVS1b3KHWXbOZBO3N5f6iB7Ui8BJIpcpdltpYRX+kbK4Le/r8EY?=
 =?us-ascii?Q?/MCuUXTBHJUIBAA5dZo5PdpJ1/oLHVCqsKDhQBkrSmZyJlb08vhfiQaIhk+5?=
 =?us-ascii?Q?gu7v5BhcUnqNcEWt0iSM9Hp5+wR/zs7Cxf+BkGMYTTxlb0DhI2V0Ev7KKe4n?=
 =?us-ascii?Q?jyTLJ8by/6cC6pXz+8XZbMzoU7uned6hZ7YQI+zcxumjZV1rXnf9ykmUeq8q?=
 =?us-ascii?Q?TVpE1g05hZz7IrswsaNQitXG90CHUyjyedNpyuoUyamdHfBTxH700az4r5tB?=
 =?us-ascii?Q?DGr6VC8bM732shz0cw3dRHFEk/5DOq9h/HxwJxuIE75VJXrazuOQ/GTkRuUk?=
 =?us-ascii?Q?38JRpITvVss13wmoeq5LkSeB7vGQDyGwfYRQNFq52YblXhTNW3ya5twz/cAr?=
 =?us-ascii?Q?yU22E6V9PCF+vY5S5GL1tn34l6HMbzlGDvVAmXcqOHAJ00sS6Ce3hjGAzmL5?=
 =?us-ascii?Q?MoaGt1ATRBoEuY8VsdYEik0oOYxMeyzkrH3lsA3TweFIt1/3j9rCnbesFxKq?=
 =?us-ascii?Q?lxJ2/9R8C/6vTu0hvl+AM91Tu9ZIa7DakUz9Wrl0OKhIRwn5aLfsTKh+2Dub?=
 =?us-ascii?Q?UfxnAayaTDqo1psg8MDe6+gewB4O1CcY3aezi+ahMOFCB5VIUAu19S30YTSY?=
 =?us-ascii?Q?+MT+gLE7Y1Srpcai4hLgi344kbLHdVMJ1hfArZmjM8SX5gvtWcaPKDlhO8ZY?=
 =?us-ascii?Q?LXEEbcoRjb4AyAyBlwRnZAU91sQqBBy/OMmXpD5qcKlmj9rpoiNG57/9wy5F?=
 =?us-ascii?Q?TNdTNwpJe2U=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: be543831-d258-4bed-cdea-08db9a8d69e1
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4531.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2023 17:07:16.2956
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hMvqRlL+7lr8IMQhNSnolQEElqjhZVEFv2OplbAv9e5X8IKdeVSPJ9ZoGFWpzTg+l3fmi4kW8dfZ5TSoQOUrkUk8KzI+1sxPbWUg3RSVfCM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR10MB5978
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-08-11_09,2023-08-10_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0 spamscore=0
 mlxscore=0 bulkscore=0 phishscore=0 malwarescore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000
 definitions=main-2308110156
X-Proofpoint-GUID: bu5R73LzN88UCxlltWa3cN5NiCrm7_MK
X-Proofpoint-ORIG-GUID: bu5R73LzN88UCxlltWa3cN5NiCrm7_MK
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

crash_prepare_elf64_headers() writes into the elfcorehdr an ELF
PT_NOTE for all possible CPUs. As such, subsequent changes to CPUs
(ie. hot un/plug, online/offline) do not need to rewrite the elfcorehdr.

The kimage->file_mode term covers kdump images loaded via the
kexec_file_load() syscall. Since crash_prepare_elf64_headers()
wrote the initial elfcorehdr, no update to the elfcorehdr is
needed for CPU changes.

The kimage->elfcorehdr_updated term covers kdump images loaded via
the kexec_load() syscall. At least one memory or CPU change must occur
to cause crash_prepare_elf64_headers() to rewrite the elfcorehdr.
Afterwards, no update to the elfcorehdr is needed for CPU changes.

This code is intentionally *NOT* hoisted into
crash_handle_hotplug_event() as it would prevent the arch-specific
handler from running for CPU changes. This would break PPC, for
example, which needs to update other information besides the
elfcorehdr, on CPU changes.

Signed-off-by: Eric DeVolder <eric.devolder@oracle.com>
Reviewed-by: Sourabh Jain <sourabhjain@linux.ibm.com>
Acked-by: Hari Bathini <hbathini@linux.ibm.com>
Acked-by: Baoquan He <bhe@redhat.com>
---
 arch/x86/kernel/crash.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c
index caf22bcb61af..18d2a18d1073 100644
--- a/arch/x86/kernel/crash.c
+++ b/arch/x86/kernel/crash.c
@@ -467,6 +467,16 @@ void arch_crash_handle_hotplug_event(struct kimage *image)
 	unsigned long mem, memsz;
 	unsigned long elfsz = 0;
 
+	/*
+	 * As crash_prepare_elf64_headers() has already described all
+	 * possible CPUs, there is no need to update the elfcorehdr
+	 * for additional CPU changes.
+	 */
+	if ((image->file_mode || image->elfcorehdr_updated) &&
+		((image->hp_action == KEXEC_CRASH_HP_ADD_CPU) ||
+		(image->hp_action == KEXEC_CRASH_HP_REMOVE_CPU)))
+		return;
+
 	/*
 	 * Create the new elfcorehdr reflecting the changes to CPU and/or
 	 * memory resources.
-- 
2.31.1