Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Lopez, Jorge A (Security)" <jorge.lopez2@hp.com>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
CC:     "hdegoede@redhat.com" <hdegoede@redhat.com>,
        "markgross@kernel.org" <markgross@kernel.org>,
        "platform-driver-x86@vger.kernel.org" 
        <platform-driver-x86@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Abaci Robot <abaci@linux.alibaba.com>
Subject: RE: [PATCH] platform/x86: hp-bioscfg: Remove useless else
Thread-Topic: [PATCH] platform/x86: hp-bioscfg: Remove useless else
Thread-Index: AQHZzB4Jrsa7FfVgg0iiCdS6YCkah6/lPExA
Date:   Fri, 11 Aug 2023 15:42:57 +0000
Message-ID: <PH0PR84MB1953FF2E688B5E250B0E37E3A810A@PH0PR84MB1953.NAMPRD84.PROD.OUTLOOK.COM>
References: <20230811062957.82728-1-jiapeng.chong@linux.alibaba.com>
In-Reply-To: <20230811062957.82728-1-jiapeng.chong@linux.alibaba.com>
Accept-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jxUra9rewIqkWip5sYWo/Oa6H06EPQD5uium25DcqTw2UAc7dk6ahAwOk39g?=
 =?us-ascii?Q?bO6kxWimgUj/cBhHqYbeU1SelWcXo0wE85PfFwV5ue5JNoR6t722U37vHkf6?=
 =?us-ascii?Q?pUXhBqcbv0C74boWWYk+/scnohzkvWL4l/j90ndNP2hYdR4BgoZZasQdNYoO?=
 =?us-ascii?Q?qAxiagRalVtnPQ4zS64znGMdYm+yeAcnZrJ9871GR0tXYzbuNueRjHF/IZRc?=
 =?us-ascii?Q?/cJ7am1zHlNCSG9vdLCzMbWF4BT+iOv00Jtg1orjjdxqGN4RhAN1FCQ3v1Fn?=
 =?us-ascii?Q?HDIK8nSOjCk2jZVp9OR9G0XJK4UfwNNj/5dj3soHvS0RBtyIxlzJ+Y+8yFNh?=
 =?us-ascii?Q?ntu7WkA1vxBxNChaauAIgH1M0/A8R0WLTASOrf+6ITlgG1eAz8ThtQlAT/f4?=
 =?us-ascii?Q?m/ebfSstg8hSgmbhMHTF84cMEHcseX+f0H1nDJQU+3GiCQpAn9Q2OJdnHHag?=
 =?us-ascii?Q?KJqHWBdSaHkZI0sUSsieMXikdiEapoPMgpB0cjAGQXmQQ/Dd3vYHeTEWHPVU?=
 =?us-ascii?Q?lHZiNJy6cNRkTzlGIIH2Ylfly50PuT7eD9YXIqBrlrcWFfgA4mk9zV3kORR6?=
 =?us-ascii?Q?p/AL76RQO7y8ml5OPICdfMd+12Hz2R/yMUmSuqWYejhWECB993EPFo7BYsYP?=
 =?us-ascii?Q?ldkkgtN77iuKLVSplvyajIiLLggaAC3AsgeUEWptpPENv1u+hQv+sQB1YpIz?=
 =?us-ascii?Q?kYraFjHy2W3NSQnjRXh4u2p80NT2JQHUTGJdL9VK1WGdqbNHNzSzPpmyicix?=
 =?us-ascii?Q?VHtSOh90XLFYDFQtAaeiKxmgZvTd3TVIh2z8R5xLxi6e7Q6UbJRUV4IU/Ckc?=
 =?us-ascii?Q?B5/XrzMRd788goxPpOm/OCCQr7u3QBdJ8R3T1lT9EYD7zYs6pABJxcfFOzYE?=
 =?us-ascii?Q?KQXi1OSa6XBVLnq3dzl1pi2ei9JYYjVkHzXMFIFO60Q9fFVIPxsYDs99+H7E?=
 =?us-ascii?Q?pY5EqcKPZF4lhZSGqjwJxtU6WcQqP7V8GaHpMIFqGfdqz/iXoDh8FmDxmdn/?=
 =?us-ascii?Q?jRFfVvpzKiWTyJysZ7vryTOUNJPi62mF2P3UuAZnS2rN5NggCYSRv7yoohG/?=
 =?us-ascii?Q?0gXnxgRIFj5RhrkbUTWKFeIewlqM0iqCpGzHqG4X8onNPMUKGN41S2nUcrmf?=
 =?us-ascii?Q?2Xgkn3jxBy1BKnIo3w8pZP5vMZirqMqFQJQ7Y6hvzBtOPTkNAOkFxP4Wfhbh?=
 =?us-ascii?Q?KKKLJo0/wVNoXmOCRsSUqidvwDAMPjVOfBjSxPZnLLQ9xoLZOYa9Ol97qEhT?=
 =?us-ascii?Q?RdPDqiNkHJg1ejD6AfqhT4QMnYdlL+zfUuCITD/kMMDOBs6338m5BEaffc8O?=
 =?us-ascii?Q?aDtrZ8/W0G1oJ72w2Zl1nIhtQ4p6GZchLKP6Be/MbVp5KA8+zuIlMnZuiZEp?=
 =?us-ascii?Q?0E882xQKf42cGtNu/ydgyxeWSu53h8kq0HZSn68IjTPqxAjwyO61b+HcHfCk?=
 =?us-ascii?Q?icRUB6D3PDQilgYiz0M110CwRDnN9HMz9EhXNmdOcc9z6u2V4eVvsJSlZr3m?=
 =?us-ascii?Q?N+Xy4tq/KEos4emtAfvGcUWe2NuUXVGLTG59RQkps5JvCefijSwyYH8UpvWk?=
 =?us-ascii?Q?NqfC2lM0FZ0JBMQFpTYdu7rGYjheSlpVwBBFS8MH?=
MIME-Version: 1.0
X-OriginatorOrg: hp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR84MB1953.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 787d9bed-c35d-4a83-8efa-08db9a81a2cc
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Aug 2023 15:42:57.5291
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: ca7981a2-785a-463d-b82a-3db87dfc3ce6
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: GThoSiah8Lc7X888oONo+fUavMwhRSIHZK1IE7pDV/oPTPxM0T20uEVB08SBzdWXvl7BGecxUn0p3gZAHqPghw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR84MB3655
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: hp.com
Content-Language: en-US
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Reviewed-by: Jorge Lopez <jorge.lopez2@hp.com>


Regards,

Jorge Lopez
HP Inc

"Once you stop learning, you start dying"
Albert Einstein

> -----Original Message-----
> From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> Sent: Friday, August 11, 2023 1:30 AM
> To: Lopez, Jorge A (Security) <jorge.lopez2@hp.com>
> Cc: hdegoede@redhat.com; markgross@kernel.org; platform-driver-
> x86@vger.kernel.org; linux-kernel@vger.kernel.org; Jiapeng Chong
> <jiapeng.chong@linux.alibaba.com>; Abaci Robot
> <abaci@linux.alibaba.com>
> Subject: [PATCH] platform/x86: hp-bioscfg: Remove useless else
>=20
> CAUTION: External Email
>=20
> The assignment of the else and if branches is the same, so the else here =
is
> redundant, so we remove it.
>=20
> ./drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:545:3-5:
> WARNING: possible condition with no effect (if =3D=3D else).
>=20
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  .../platform/x86/hp/hp-bioscfg/passwdobj-attributes.c  | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
>=20
> diff --git a/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c
> b/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c
> index 03d0188804ba..771e554182dc 100644
> --- a/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c
> +++ b/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c
> @@ -541,14 +541,8 @@ void hp_exit_password_attributes(void)
>                 struct kobject *attr_name_kobj =3D
>                         bioscfg_drv.password_data[instance_id].attr_name_=
kobj;
>=20
> -               if (attr_name_kobj) {
> -                       if (!strcmp(attr_name_kobj->name, SETUP_PASSWD))
> -                               sysfs_remove_group(attr_name_kobj,
> -                                                  &password_attr_group);
> -                       else
> -                               sysfs_remove_group(attr_name_kobj,
> -                                                  &password_attr_group);
> -               }
> +               if (attr_name_kobj)
> +                       sysfs_remove_group(attr_name_kobj,
> + &password_attr_group);
>         }
>         bioscfg_drv.password_instances_count =3D 0;
>         kfree(bioscfg_drv.password_data);
> --
> 2.20.1.7.g153144c