Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\))
Subject: Re: [RFC PATCH v2 4/5] mm/autonuma: call .numa_protect() when page is
 protected for NUMA migrate
From:   Nadav Amit <nadav.amit@gmail.com>
In-Reply-To: <20230810090048.26184-1-yan.y.zhao@intel.com>
Date:   Fri, 11 Aug 2023 11:52:53 -0700
Cc:     linux-mm <linux-mm@kvack.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Mike Kravetz <mike.kravetz@oracle.com>, apopple@nvidia.com,
        Jason Gunthorpe <jgg@nvidia.com>,
        Mike Rapoport <rppt@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        kevin.tian@intel.com, david@redhat.com
Content-Transfer-Encoding: quoted-printable
Message-Id: <8735E3A2-795B-4D52-9634-D48C68645A5D@gmail.com>
References: <20230810085636.25914-1-yan.y.zhao@intel.com>
 <20230810090048.26184-1-yan.y.zhao@intel.com>
To:     Yan Zhao <yan.y.zhao@intel.com>
Precedence: bulk


> On Aug 10, 2023, at 2:00 AM, Yan Zhao <yan.y.zhao@intel.com> wrote:
>=20
> Call mmu notifier's callback .numa_protect() in change_pmd_range() =
when
> a page is ensured to be protected by PROT_NONE for NUMA migration =
purpose.

Consider squashing with the previous patch. It=E2=80=99s better to see =
the user
(caller) with the new functionality.

It would be useful to describe what the expected course of action that
numa_protect callback should take.