Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jonathan Corbet <corbet@lwn.net>
To:     Min-Hua Chen <minhuadotchen@gmail.com>,
        Hu Haowen <src.res@email.cn>
Cc:     Min-Hua Chen <minhuadotchen@gmail.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        linux-doc-tw-discuss@lists.sourceforge.net,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] docs: sparse: convert TW sparse.txt into sparse.rst
In-Reply-To: <20230811153554.84571-3-minhuadotchen@gmail.com>
References: <20230811153554.84571-1-minhuadotchen@gmail.com>
 <20230811153554.84571-3-minhuadotchen@gmail.com>
Date:   Fri, 11 Aug 2023 14:41:36 -0600
Message-ID: <87a5uxxqf3.fsf@meer.lwn.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Min-Hua Chen <minhuadotchen@gmail.com> writes:

> Follow Randy's advice [1] to move
> Documentation/translations/zh_TW/dev-tools/sparse.txt
> to
> Documentation/translations/zh_TW/dev-tools/sparse.rst
>
> [1] https://lore.kernel.org/lkml/bfab7c5b-e4d3-d8d9-afab-f43c0cdf26cf@inf=
radead.org/

So the right way to do this would be to simply say something like
"Convert sparse.txt to RST", then add a Suggested-by: tag to credit
Randy.=20

> Cc: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com>
> ---
>  .../dev-tools/{sparse.txt =3D> sparse.rst}      | 31 ++++++-------------
>  1 file changed, 10 insertions(+), 21 deletions(-)
>  rename Documentation/translations/zh_TW/dev-tools/{sparse.txt =3D> spars=
e.rst} (71%)

You're not adding this new document to a toctree anywhere; that will add
a warning and this file won't be a part of the docs build.

> diff --git a/Documentation/translations/zh_TW/dev-tools/sparse.txt b/Docu=
mentation/translations/zh_TW/dev-tools/sparse.rst
> similarity index 71%
> rename from Documentation/translations/zh_TW/dev-tools/sparse.txt
> rename to Documentation/translations/zh_TW/dev-tools/sparse.rst
> index 6d2d088b1060..2f632f6ce8e8 100644
> --- a/Documentation/translations/zh_TW/dev-tools/sparse.txt
> +++ b/Documentation/translations/zh_TW/dev-tools/sparse.rst
> @@ -1,33 +1,22 @@
> -=EF=BB=BFChinese translated version of Documentation/dev-tools/sparse.rst
> -
> -If you have any comment or update to the content, please contact the
> -original document maintainer directly.  However, if you have a problem
> -communicating in English you can also ask the Chinese maintainer for
> -help.  Contact the Chinese maintainer if this translation is outdated
> -or if there is a problem with the translation.
> +=EF=BB=BFCopyright 2004 Linus Torvalds
> +Copyright 2004 Pavel Machek <pavel@ucw.cz>
> +Copyright 2006 Bob Copeland <me@bobcopeland.com>
>=20=20
> -Traditional Chinese maintainer: Hu Haowen <src.res@email.cn>
> ----------------------------------------------------------------------
> -Documentation/dev-tools/sparse.rst =E7=9A=84=E7=B9=81=E9=AB=94=E4=B8=AD=
=E6=96=87=E7=BF=BB=E8=AD=AF
> +.. include:: ../disclaimer-zh_TW.rst
>=20=20
> -=E5=A6=82=E6=9E=9C=E6=83=B3=E8=A9=95=E8=AB=96=E6=88=96=E6=9B=B4=E6=96=B0=
=E6=9C=AC=E6=96=87=E7=9A=84=E5=85=A7=E5=AE=B9=EF=BC=8C=E8=AB=8B=E7=9B=B4=E6=
=8E=A5=E8=81=AF=E7=B9=AB=E5=8E=9F=E6=96=87=E6=AA=94=E7=9A=84=E7=B6=AD=E8=AD=
=B7=E8=80=85=E3=80=82=E5=A6=82=E6=9E=9C=E4=BD=A0=E4=BD=BF=E7=94=A8=E8=8B=B1=
=E6=96=87
> -=E4=BA=A4=E6=B5=81=E6=9C=89=E5=9B=B0=E9=9B=A3=E7=9A=84=E8=A9=B1=EF=BC=8C=
=E4=B9=9F=E5=8F=AF=E4=BB=A5=E5=90=91=E7=B9=81=E9=AB=94=E4=B8=AD=E6=96=87=E7=
=89=88=E7=B6=AD=E8=AD=B7=E8=80=85=E6=B1=82=E5=8A=A9=E3=80=82=E5=A6=82=E6=9E=
=9C=E6=9C=AC=E7=BF=BB=E8=AD=AF=E6=9B=B4=E6=96=B0=E4=B8=8D=E5=8F=8A=E6=99=82=
=E6=88=96
> -=E8=80=85=E7=BF=BB=E8=AD=AF=E5=AD=98=E5=9C=A8=E5=95=8F=E9=A1=8C=EF=BC=8C=
=E8=AB=8B=E8=81=AF=E7=B9=AB=E7=B9=81=E9=AB=94=E4=B8=AD=E6=96=87=E7=89=88=E7=
=B6=AD=E8=AD=B7=E8=80=85=E3=80=82
> +:Original: Documentation/dev-tools/sparse.rst
>=20=20
> -=E7=B9=81=E9=AB=94=E4=B8=AD=E6=96=87=E7=89=88=E7=B6=AD=E8=AD=B7=E8=80=85=
=EF=BC=9A =E8=83=A1=E7=9A=93=E6=96=87 Hu Haowen <src.res@email.cn>
> -=E7=B9=81=E9=AB=94=E4=B8=AD=E6=96=87=E7=89=88=E7=BF=BB=E8=AD=AF=E8=80=85=
=EF=BC=9A =E8=83=A1=E7=9A=93=E6=96=87 Hu Haowen <src.res@email.cn>
> +:=E7=BF=BB=E8=AD=AF:

So you are removing a fair amount of text here, much of which I cannot
read.  Why are you doing that?  In any case, that would appear to be a
change that is independent of the format conversion, and should thus be
in its own patch.

Thanks,

jon