Received: by 2002:a05:7412:6592:b0:d7:7d3a:4fe2 with SMTP id m18csp1258175rdg; Fri, 11 Aug 2023 15:34:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEbBHhTMYraJgcrsQFyLrf9VFxNUsCbg/Lsu8qTjJKDG8Gcg2t+88AjexVfmY6DqtcBusSp X-Received: by 2002:a17:907:2c48:b0:99c:bcbe:c9e4 with SMTP id hf8-20020a1709072c4800b0099cbcbec9e4mr2575306ejc.32.1691793293725; Fri, 11 Aug 2023 15:34:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691793293; cv=none; d=google.com; s=arc-20160816; b=jPq2zsCuA6q3A+J8+VROPgQhAnLNoY3DOqsTGvIeXEv+UQpoXzAq+YLbSQ8YOz2UOk M1obNSkLWbAOXlguQBrYrkKiwkeGqmtTirjbqOkqvTSMi2x3R1g6V8LLxQN+zes3dcaZ tx02TlssZ+BoqiVVo5hCgWZkBvCm8i6ruaV2eZlR8qUt1WKqEwqQ6w893T2IftjntmvW scDlYvmSnztyQMKcAbBTe8soiXFkUln//v5M6C8IzJgCtRHeUMbZh+Wp7i91IMls72Nh RCY7SlRzN0UWhWgnCGAxXn9UBDA5bLreIi29v/06PFKEQpKLgA6HtxNe7sDMc6aZNhHd 8IeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=cBhR7GYc1FKpArricedkgQ52SkpCNvfi1EZ6TEpufnI=; fh=bect0YfwlQNMhl9TTE1mamcOay+NiVrr5fBWYFtnjII=; b=hm9SIsAMLSF5sBPBSo6S6NugMDknrZsvpOQ84k+sc6GiTimUF53f89EuvElKuvPmHD ErnPwGiXyPPDNZ1iREIkXpi8jc1UdOI1sqgv+60B6DWo153sIqshmgr+G2LK0tFLYouY qWnjwrI/nDOag57Y4iuKL2MzIzUJw5MADTVVXDfnJrj4sixq4pBXnZTkhWwO05hY2IMf z1gUGiV8X7vGmfCF02gVGPbWU/Mw+5W5R2motcbqq5ssARwijKymXrs9XYlkDgh3oIMB a6Je6mSXqMm88sCFT8M2dzivXPyOqLJ1pocz0AD79xgyxJ6kkT5VlZC//uOobLI4863r JT7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QIeCOjJ3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l18-20020a1709065a9200b00987383af65asi4023762ejq.582.2023.08.11.15.34.29; Fri, 11 Aug 2023 15:34:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QIeCOjJ3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231705AbjHKWEz (ORCPT + 99 others); Fri, 11 Aug 2023 18:04:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229483AbjHKWEv (ORCPT ); Fri, 11 Aug 2023 18:04:51 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BCFF100 for ; Fri, 11 Aug 2023 15:04:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C684E641CA for ; Fri, 11 Aug 2023 22:04:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5DE1C433C9; Fri, 11 Aug 2023 22:04:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691791490; bh=R79FmNVLkjyVIXv6tcSmcPvmWYKleg4cZwFL8d//vZU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QIeCOjJ3kgBHaAngByoR+7WKXG5S3MUZzf8VNz4lm5p93cp034lXuqIByZvWT3QWE B3GG5Uz7waECrMAkotSKH3qKsLzzW8jxT0I5FGlWJBg6qvSh5osqDiDZLOwj5Tx43t s7gfbB+ZiflZvnrVAChWKhUqOWqqDnQ255PPJZNFblCZCIICRiOFeSBDCMNZMEftNx Cb5wpLLLHabXpfMq87yxFAnux0CV4c1uwqoaKHVId1f7aFp1cu8z7fmWZ0Y03SSNJ+ LYAYffE0I2Uup57miARef5Pb+nxLSizI/bAxkvLV6Dvw1/AXJsvENaOLz6YWlsKuek KFSynfrpfgHXQ== Date: Fri, 11 Aug 2023 15:04:49 -0700 From: Jakub Kicinski To: Sai Krishna Gajula Cc: "davem@davemloft.net" , "edumazet@google.com" , "pabeni@redhat.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sunil Kovvuri Goutham , Geethasowjanya Akula , Subbaraya Sundeep Bhatta , Hariprasad Kelam , "richardcochran@gmail.com" , Naveen Mamindlapalli Subject: Re: [net-next PATCH v2] octeontx2-pf: Use PTP HW timestamp counter atomic update feature Message-ID: <20230811150449.64ce3512@kernel.org> In-Reply-To: References: <20230807140535.3070350-1-saikrishnag@marvell.com> <20230809155022.132a69a7@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 11 Aug 2023 05:48:38 +0000 Sai Krishna Gajula wrote: > > If you reorder the includes - maybe put them in alphabetical order? > > There are some structure definitions in rvu.h which are required in > ptp.h. So, re-ordering in alphabetical order will give compilation > issue. Headers should be self-contained. Such dependencies are hard to figure out for people doing refactoring so it'd be best to clean that up.