Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230810133216.GKZNTm4KpohRR4gVsT@fat_crate.local>
 <20230810134056.GA130730@dev-arch.thelio-3990X> <20230810144344.GLZNT3oM6MLVdzGlyd@fat_crate.local>
 <20230810150706.GA42856@dev-arch.thelio-3990X> <20230810151410.GNZNT+wn/cLBWiU6dO@fat_crate.local>
 <20230810154831.GA38495@dev-arch.thelio-3990X> <20230810161414.GA4000@dev-arch.thelio-3990X>
 <20230811101456.GDZNYKIHs1k7ri8hrI@fat_crate.local> <20230811140941.GB193223@dev-arch.thelio-3990X>
 <ZNZbxhL5ZJD1Sd9P@google.com> <20230811161225.GIZNZd6QfLUoZv9TLO@fat_crate.local>
In-Reply-To: <20230811161225.GIZNZd6QfLUoZv9TLO@fat_crate.local>
From:   Nick Desaulniers <ndesaulniers@google.com>
Date:   Fri, 11 Aug 2023 17:42:04 -0700
Message-ID: <CAKwvOdmejxO=_KBuw1WZGgh=MXNNbfWH03TpEFO47vkKWq04Cg@mail.gmail.com>
Subject: Re: Hang when booting guest kernels compiled with clang after SRSO mitigations
To:     Sean Christopherson <seanjc@google.com>
Cc:     Nathan Chancellor <nathan@kernel.org>, x86@kernel.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
        Borislav Petkov <bp@alien8.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Aug 11, 2023 at 9:12=E2=80=AFAM Borislav Petkov <bp@alien8.de> wrot=
e:
>
> On Fri, Aug 11, 2023 at 09:03:18AM -0700, Sean Christopherson wrote:
> > Might be the flags bug that borks KVM's fastop() emulation.  If that fi=
xes things,
> > my guess is that bringing APs out of WFS somehow triggers emulation.
>
> I was just about to connect you two guys, thanks Sean!
>
> > https://lore.kernel.org/all/20230811155255.250835-1-seanjc@google.com
>
> Nathan, if you could test, that would be cool.

Nathan confirmed on IRC (since Sean isn't there; Sean what are you
doing, you know we have corp IRCCloud accounts, yeah?):


<nathanchance>
bpetkov: Seems like Sean bailed you out :P his patch appears to fix
the issue on the Ryzen 3 box, about to test the Threadripper
bpetkov: Will have results shortly assuming the machine boots :^) is
it possible that clang is generating a code sequence that triggers
this issue that gcc does not?

<bpetkov>
yeah, something about rFLAGS gets clobbered in the clang variant while
gcc doesn't
dunno if this is a more serious code generation issue

I'm not familiar enough with the relevant code to make a call there,
but perhaps Sean has more context and can help us deduce if that's the
case?

>
> Also, Nick has another patch for -mno-shared, it probably isn't fixing
> yours but it would be good to test it too, just in case:
>
> https://github.com/ClangBuiltLinux/linux/issues/1911#issuecomment-1674993=
796

So far it looks like it's working for folks. Fixing that issue is the
lowest priority issue of the three we found; I'll send it formally
next week.

I literally just had my hard drive fail on my main dev box (that's two
machines fail in one week; laptop wont power on anymore; down to one
machine left).  Going to see if fsck can help at all; worst case I may
need Nathan to formally send it for me next week.  Let's see if I can
recover this machine first...what a way to end the week. SMH

>
> Thx!
>
> --
> Regards/Gruss,
>     Boris.
>
> https://people.kernel.org/tglx/notes-about-netiquette


--=20
Thanks,
~Nick Desaulniers