Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3a4bf401-0781-492f-a952-3c96c1507551@intel.com>
Date:   Fri, 11 Aug 2023 16:58:23 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.14.0
Subject: Re: [PATCH 1/1] x86/pti: Fix kernel warnings for pti= and nopti
 cmdline options.
Content-Language: en-US
To:     Dave Hansen <dave.hansen@intel.com>,
        Jo Van Bulck <jo.vanbulck@cs.kuleuven.be>,
        <linux-kernel@vger.kernel.org>, <dave.hansen@linux.intel.com>,
        <luto@kernel.org>, <peterz@infradead.org>, <mingo@redhat.com>
CC:     <x86@kernel.org>, <bp@alien8.de>, <tglx@linutronix.de>,
        <hpa@zytor.com>
References: <20230811213628.40428-1-jo.vanbulck@cs.kuleuven.be>
 <20230811213628.40428-2-jo.vanbulck@cs.kuleuven.be>
 <295ea2ef-3480-856b-b93a-9ae36f7b2286@cs.kuleuven.be>
 <d76126be-9eda-d426-1fa5-a35fd4ca3d57@intel.com>
From:   Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <d76126be-9eda-d426-1fa5-a35fd4ca3d57@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T0orRm1veFNSNWt3Sm9zS0UvMjNtZUpONWJQT1hpWTdtTUE3R1dRRUE2Z1lx?=
 =?utf-8?B?Qk91dkhGWUc5Mkgzb3FkQTd2NGJZbTBIall1R3R1UTM3ZXpxdktyeGtXNjZL?=
 =?utf-8?B?eEFwT1Voc3poMi91U2VxN3ROdzhzS2FsNGYva0JvRy9mZmhubkZ2ZFJrQit2?=
 =?utf-8?B?SG9jOTE3TWdEeVhTZTd5NGU1WW0weUpqRUlmV2UzRWZLMHViZlRFRkhJQzUr?=
 =?utf-8?B?dVVNbE9PWitNUy9tdlRzY2ROZ0F6SGZodVRYWjA4STE4dDUwK0FMc1VDNlRo?=
 =?utf-8?B?SzdjRDZKT2x0MlNBZmFrdk5tMFh6YllnZFRvaTltUE1VTDlHQ1M3U1B1TlZI?=
 =?utf-8?B?enFlNDJ1cHFNMjlocXgwRkZ0ZGtaVGxoWEN6L1AwZ3FZWGJvcjZPSldKdVRp?=
 =?utf-8?B?Mm0zN2dhMHV5T1lwU2VvakFoSFBPdnovc3hYYk1nWGRoNTF2ZGhqYWpIU0tB?=
 =?utf-8?B?MmR3MUlJMEEvdytLTCtDU2RkS3VwUFJiMXlZdnJKUStrQ0pESlRoTXJjclh0?=
 =?utf-8?B?UG9DTm83Y3Uxa0lNVzgyLzFtMjg0L3ExYzJPVmNnMlZTazFsTy9OamhQemhI?=
 =?utf-8?B?anpGbHN5OVQwSmxSc3dwaHAvN0FBcFRxRHVmOGNWbmgydFY4Yk5ZdGwyY1NS?=
 =?utf-8?B?VGpOT1g4NlNSdnNrbUtrQWhZdTBrSXc0T0xDRXJCTFROWmJkN0JCYloycDZl?=
 =?utf-8?B?ZHlOVmJjOEVDU1RZUGZFS3g2RnJMWUxPOTAwSmViaURWUXM5SVRHSGtXQTFG?=
 =?utf-8?B?NGlKb3VBcmp4MldOVGhJaGJKTVE2UjZBeERIT2V3cUt2UHpwemJuS2UyRXBp?=
 =?utf-8?B?djRKTkdQTDF0S3dHdlRVN2Z1WGk4anlkb1lGOXA4djZ2cFEwTksyS3MveWUz?=
 =?utf-8?B?dTRBd2VBb1J4RGRnTXJsYkdBVEdKemc3RFlSa25XNmJOMjlnV203ZzNmY0JU?=
 =?utf-8?B?RUlsWVl0Nm1VU1Z0NGxxcjV3VnRReTE2aUd5YkVKVUdVR0t0bHpsZElOdlR0?=
 =?utf-8?B?cnprQ3YzcWp5UXE4TTZXaUIxd0QwaGs1Wk8rNkhUZTcyQUNwVk9vYy9xcDVF?=
 =?utf-8?B?M3FJQkpXbTBYQ0tqWUxmUjlCNDBEMUhqZkI5Qk9MSDBYMnNtTHl4eHJGOEZM?=
 =?utf-8?B?dytNSVYwSW95b21FdWlwYVRSblcrZWdCK0JlZll2WkJnMmVvZC9GL1BVZm50?=
 =?utf-8?B?YzZ3b1ZSbWNtQXJtQ0RvRXFXc1Vja2cvUHVvUmRKKzRFQUJkd21Na0pqL1ll?=
 =?utf-8?B?eEE3MDBSb1QxZk11Z3VnVEs3ajlrSkhqN0VDR2hYNWVENGF6ZVVnUXErQVVu?=
 =?utf-8?B?NStMdndSWURudUhGYy92d21BRDNwZWd0RjBkK3dubG5QWmh2MEFLZmdRMUJV?=
 =?utf-8?B?LzdrLzB2R2JlVnFjc1Rac1pjVTBuem8wcUtnSTcwVmxReXQrVTVvMjNtbkdH?=
 =?utf-8?B?WUxjVGVZd2t1S1A4QVBIQ00xRlZlMytFTGhUa2xDeW9WSmdVbTlGWEhSUEo5?=
 =?utf-8?B?Z3B0RXR5V1V1YlN5QWJGZ3B5RWJyaGZJeEM5cGRlVy84WXAwYk9OVU12ZlJS?=
 =?utf-8?B?cmRLRWNZdFJJYld0bTJyVUtzZ3pYNkJ2eVlZbFJycjRhTUR3S2NCb1ozOFhU?=
 =?utf-8?B?RFlrMGJ6Y05LTzI1czlwUWdXM2czZTVtLzc2czcvRERXaDhLUDlsQ2hZR01p?=
 =?utf-8?B?U0dDVmkycDR0TEdUZXplTEtnV1FOSjdPempWL2k4cm1ibFVSditEL1JRN3Qv?=
 =?utf-8?B?Yk1nSUVjcjA5RDRoQkgyUUovS09QWTQyQmNtQkpHNE9WaERHZDFteFFNV0J3?=
 =?utf-8?B?NUVHL21Jd3ZNZFlCMGdmQ083Q3FEQWd3SXR4a1g1bGNBM3JSNFlvY0xxZmFs?=
 =?utf-8?B?ejRiSkhpckx0eEFUSDRhNk1GZjBNNm9xb3pyK1VSdFM4ak44aXJTZGFzYllR?=
 =?utf-8?B?M2RkY3RyUlU3Nnpob2tKYTUrem9oYURCTlM3YTEyVkduYnFBeVlRUG9ibXRY?=
 =?utf-8?B?WlBhVFljOWplcllIOWxnQ2hLdDBXOGtVWXJ3MVU1K0MyK0xpT3FORVBVQzVk?=
 =?utf-8?B?YlFTckc0SlJMaWd2MG9pOG1uaHgzU2tJeUVCakVoT0k3Wko2RDZqMjRpaUx2?=
 =?utf-8?Q?36DgfjlSNaY46KOL9lPJ6RcIh?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6e1827a5-d907-41b8-4370-08db9ac6da0e
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2023 23:58:25.6923
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qQur5p9rMxWPTVY2s3RvYkpQigR1rDBHzpf2mIN0tLFIXFDFoezVBiqwwwUmlE+SBGk6ezFD+GYpWc/3qvKbLw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6044
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/11/2023 4:42 PM, Dave Hansen wrote:
> On 8/11/23 16:27, Jo Van Bulck wrote:

>> Not sure which option would best match kernel coding guidelines?
> 
> This sound like it's getting a bit out of hand and reaching far beyond
> cleaning up some (mostly) harmless warnings.
> 

I agree this doesn't have to be this complex. PTI_FORCE_AUTO is unnecessary.

> pti=auto does *not* need to override mitigations=off.

I think only pti=on needs to override mitigations=off i.e. the User is
saying turn off mitigations but keep PTI enabled. This should be fairly
easy to achieve with the current enum. If it is not then it's not worth
the hassle.