Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 12 Aug 2023 10:21:08 +0200
From:   Lukas Wunner <lukas@wunner.de>
To:     Damien Le Moal <dlemoal@kernel.org>
Cc:     Alistair Francis <alistair23@gmail.com>, bhelgaas@google.com,
        linux-pci@vger.kernel.org, Jonathan.Cameron@huawei.com,
        alex.williamson@redhat.com, christian.koenig@amd.com,
        kch@nvidia.com, gregkh@linuxfoundation.org, logang@deltatee.com,
        linux-kernel@vger.kernel.org, chaitanyak@nvidia.com,
        rdunlap@infradead.org, Alistair Francis <alistair.francis@wdc.com>
Subject: Re: [PATCH v4] PCI/DOE: Expose the DOE protocols via sysfs
Message-ID: <20230812082108.GD9469@wunner.de>
References: <20230810163342.1059509-1-alistair.francis@wdc.com>
 <b3d437f5-fe33-4677-e336-a67ac9b8d477@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b3d437f5-fe33-4677-e336-a67ac9b8d477@kernel.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Fri, Aug 11, 2023 at 10:03:58AM +0900, Damien Le Moal wrote:
> On 8/11/23 01:33, Alistair Francis wrote:
> > Each DOE feature is exposed as a single file. The files are empty and
> > the information is contained in the file name.
> 
> s/feature/protocol ?

DOE r1.1 replaced all occurrences of "protocol" with the term "feature"
or "Data Object Type".

PCIe r6.1 (which was published July 24) incorporated that change.

So going forward the term "protocol" is deprecated in the DOE context.

We should use the terms used by the (latest) PCIe Base Spec so that
users can easily make the connection between the language in the spec
and our code.

Unfortunately this patch uses a mix of "protocol" and "feature".
It should use the latter term exclusively.

Thanks,

Lukas