Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 12 Aug 2023 11:17:46 +0200
From:   Lorenzo Bianconi <lorenzo@kernel.org>
To:     Linus Walleij <linus.walleij@linaro.org>
Cc:     Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Mario Tesi <mario.tesi@st.com>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] iio: lsm6dsx: Support temperature channel
Message-ID: <ZNdOOuXy7vON/Shb@lore-rh-laptop>
References: <20230811-iio-spacex-lsm6ds0-v1-0-e953a440170d@linaro.org>
 <20230811-iio-spacex-lsm6ds0-v1-1-e953a440170d@linaro.org>
 <ZNYIaagdt7HuRet5@lore-rh-laptop>
 <CACRpkdYHMyfvAGxgvtB8jgTsOp36Lm4gXzVYcBfXdY7RQK36cQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="JW11KyscPKBiby6C"
Content-Disposition: inline
In-Reply-To: <CACRpkdYHMyfvAGxgvtB8jgTsOp36Lm4gXzVYcBfXdY7RQK36cQ@mail.gmail.com>
Precedence: bulk


--JW11KyscPKBiby6C
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> Hi Lorenzo!
>=20
> thanks for the review!
>=20
> On Fri, Aug 11, 2023 at 12:07=E2=80=AFPM Lorenzo Bianconi <lorenzo@kernel=
=2Eorg> wrote:
>=20
> > > +                     [ST_LSM6DSX_ID_TEMP] =3D {
> > > +                             .reg =3D {
> > > +                                     .addr =3D 0x0A,
> > > +                                     .mask =3D GENMASK(5, 4),
> > > +                             },
> >
> > looking at the ISM330DHCX datasheet, the temperature sensor ODR is just=
 52Hz,
> > while values in 0x0A register are used only for FIFO decimation, they a=
re not
> > values you can configure the sensor e.g. for read_one_shot().
> >
> > > +                             .odr_avl[0] =3D {  26000, 0x02 },
> > > +                             .odr_avl[1] =3D {  52000, 0x03 },
> > > +                             .odr_len =3D 2,
>=20
> I look at page 44, paragraph 9.6 about bits 4-5:
>=20
> ODR_T_BATCH_[1:0]
> Selects batch data rate (write frequency in FIFO) for temperature data
> (00: Temperature not batched in FIFO (default);
> 01: 1.6 Hz;
> 10: 12.5 Hz;
> 11: 52 Hz)

AFAIR the batch register is used to sub-sample sensor data before queueing =
them
into the FIFO (please check st_lsm6dsx_set_fifo_odr()), but it does not ref=
er
to the configured sensor ODR.
Looking at the device application-note [0], the temperature sensor ODR depe=
nds
on the accel/gyro one:

- temperature sensor ODR =3D=3D accel sensor ODR if accel ODR is < 52Hz and=
 the
  gyro is in power-down
- temperature sensor ODR =3D 52Hz if accel ODR > 52Hz or if the gyro is not=
 in
  power-down

Regards,
Lorenzo

[0] https://www.st.com/resource/en/application_note/an5398-ism330dhcx-alway=
son-3d-accelerometer-and-3d-gyroscope-with-digital-output-for-industrial-ap=
plications-stmicroelectronics.pdf

>=20
> That reads to me that I should actually add the odr for 1.6 and 12.5 Hz
> and the above 26 Hz is wrong but the .odr_avl[1] =3D {  52000, 0x03 },
> 52000 milli-Hz is fine?
>=20
> Yours,
> Linus Walleij

--JW11KyscPKBiby6C
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCZNdONwAKCRA6cBh0uS2t
rGTgAPwMXyzceZYVU6okEAgaH9yCvyNeOc3nFiYMtI016bnmtgD/WbETAWx5M6Mr
JCxdDIvAcGmT/ETd9KQFy2Ltq+2EZgE=
=B9Yu
-----END PGP SIGNATURE-----

--JW11KyscPKBiby6C--