Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230811210142.403160-1-robimarko@gmail.com> <20230811210142.403160-2-robimarko@gmail.com>
 <4c96210b-4567-4cb5-80bb-7adca6c5f124@linaro.org> <CAOX2RU6X0Tww4UkTKVfc=PLY=RKVJdsm+gomytT0vOydTF+Hnw@mail.gmail.com>
 <7116b473-7f22-43df-af39-81e5f6db4507@linaro.org>
In-Reply-To: <7116b473-7f22-43df-af39-81e5f6db4507@linaro.org>
From:   Robert Marko <robimarko@gmail.com>
Date:   Sat, 12 Aug 2023 11:55:55 +0200
Message-ID: <CAOX2RU6nMvpTkGdwBoLJrES5v0qARnDDT6nCVd-DZid7p3pg6Q@mail.gmail.com>
Subject: Re: [PATCH 2/2] ARM: dts: qcom: ipq4019-ap.dk01.1: align flash node
 with bindings
To:     Konrad Dybcio <konrad.dybcio@linaro.org>
Cc:     agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, 12 Aug 2023 at 00:56, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
> On 11.08.2023 23:35, Robert Marko wrote:
> > On Fri, 11 Aug 2023 at 23:28, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
> >>
> >> On 11.08.2023 23:01, Robert Marko wrote:
> >>> Rename the SPI-NOR node to flash@0, remove #address-cells and #size-cells
> >>> as they should be under the partitions subnode and use the generic
> >>> jedec,spi-nor compatible.
> >>>
> >>> Signed-off-by: Robert Marko <robimarko@gmail.com>
> >>> ---
> >> You can also do "nandmanufacturer,mx25l25635e", "jedec,spi-nor"
> >
> > Hi,
> > I grepped the vendor U-Boot to make sure it's not being triggered off
> > the mx25l25635e
> > compatible but the only hit is the IC support itself.
> > MX25L25635 was just the original NOR IC Qualcomm used on the board so
> > to me it made
> > most sense to just use the JEDEC compatible as NOR itself is JEDEC NOR
> > compatible.
> OK if dynamic identification works fine

It should work fine, datasheet is clear that its JEDEC compatible.
That being said, I dont actually have the board, just figured it was
time for a cleanup as
OpenWrt has been patching DK01 and DK04 for ages.

Regards,
Robert
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>
> Konrad