Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 12 Aug 2023 07:31:30 -0700
From:   Nathan Chancellor <nathan@kernel.org>
To:     Borislav Petkov <bp@alien8.de>
Cc:     Nick Desaulniers <ndesaulniers@google.com>,
        Sean Christopherson <seanjc@google.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: Hang when booting guest kernels compiled with clang after SRSO
 mitigations
Message-ID: <20230812143130.GA3494185@dev-arch.thelio-3990X>
References: <20230810150706.GA42856@dev-arch.thelio-3990X>
 <20230810151410.GNZNT+wn/cLBWiU6dO@fat_crate.local>
 <20230810154831.GA38495@dev-arch.thelio-3990X>
 <20230810161414.GA4000@dev-arch.thelio-3990X>
 <20230811101456.GDZNYKIHs1k7ri8hrI@fat_crate.local>
 <20230811140941.GB193223@dev-arch.thelio-3990X>
 <ZNZbxhL5ZJD1Sd9P@google.com>
 <20230811161225.GIZNZd6QfLUoZv9TLO@fat_crate.local>
 <CAKwvOdmejxO=_KBuw1WZGgh=MXNNbfWH03TpEFO47vkKWq04Cg@mail.gmail.com>
 <20230812134642.GGZNeNQpebzu3H3NDh@fat_crate.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230812134642.GGZNeNQpebzu3H3NDh@fat_crate.local>
Precedence: bulk

On Sat, Aug 12, 2023 at 03:46:42PM +0200, Borislav Petkov wrote:
> Btw, this:
> 
> https://github.com/ClangBuiltLinux/linux/commit/150c42407f87463c27a2459e06845965291d9973
> 
> Is this fixing a current issue and so it needs to go to Linus now?
> 
> If so, I'll expedite it too.

Yes, that fixes an error at link time when building with LTO:

https://github.com/ClangBuiltLinux/linux/issues/1909

That is commit 973ab2d61f33 ("x86/retpoline,kprobes: Fix position of
thunk sections with CONFIG_LTO_CLANG") in x86/core, with the conflicts
against SRSO resolved and the fix that Andrew Cooper pointed out
squashed in, in case my comment in the commit message was not clear
enough :)

https://lore.kernel.org/lkml/20230803230323.1478869-1-andrew.cooper3@citrix.com/

With that change and the other ld.lld change you already picked up in
x86/bugs, our builds should go back to green, then we can decide what to
do about that runtime warning based on Peter's series and Nick's ability
to get back up and running (I have his patch applied locally somewhere
so I don't mind collecting tags and sending it next week).

Thanks again for helping us with this, I know it has been chaotic.

Cheers,
Nathan