Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 12 Aug 2023 16:19:44 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Florian Fainelli <florian.fainelli@broadcom.com>
Cc:     Giulio Benetti <giulio.benetti@benettiengineering.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@broadcom.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Russell King <linux@armlinux.org.uk>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Jim Reinhart <jimr@tekvox.com>,
        James Autry <jautry@tekvox.com>,
        Matthew Maron <matthewm@tekvox.com>
Subject: Re: [PATCH] net: phy: broadcom: add support for BCM5221 phy
Message-ID: <187506b6-f6a1-4e50-b287-f01984c1e334@lunn.ch>
References: <20230811215322.8679-1-giulio.benetti@benettiengineering.com>
 <0188dd19-7fcb-4bfe-945d-6cb5b57ae80a@lunn.ch>
 <6f7fd397-2b63-be20-fa9c-c26298226088@broadcom.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6f7fd397-2b63-be20-fa9c-c26298226088@broadcom.com>
Precedence: bulk

> > This table has some sort of sorting. I would put this new entry before
> > PHY_ID_BCM5241.
> > 
> > >   #define PHY_ID_BCM50610			0x0143bd60
> > >   #define PHY_ID_BCM50610M		0x0143bd70
> > >   #define PHY_ID_BCM5241			0x0143bc30
> > > +#define PHY_ID_BCM5221			0x004061e0
> > 
> > The value looks odd. Is the OUI correct? Is that a broadcom OUI?
> 
> Yes it is correct and yes it is assigned to Broadcom.

I found a datasheet for this PHY and it does list this OUI. I just
noticed it is the only device supported by this driver which uses this
OUI, so i just wanted to check.

     Andrew