Received: by 2002:a05:7412:6592:b0:d7:7d3a:4fe2 with SMTP id m18csp1712413rdg; Sat, 12 Aug 2023 12:57:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFWzmHJxcrjreK9bzysHuYTmOCiCkTAUbq3OTZ5kbVk3zqk0q971Bri5v85dFcktbhXT1PR X-Received: by 2002:a05:6402:68e:b0:522:4f6d:c443 with SMTP id f14-20020a056402068e00b005224f6dc443mr4546972edy.23.1691870262423; Sat, 12 Aug 2023 12:57:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691870262; cv=none; d=google.com; s=arc-20160816; b=ceKvGVUxbkDCNAmDyWVWQ/T/UfnSmp3g4kl0SCFicFcn4IfKNKDUoByVYOc6BvTmZ7 hELvIyQbAQUD4OzstM3zB3xJVkqfNf9XSGsXklOcptqC+CloF0ayTwkjb75mOyszFUKb 4fJfzbPjT8u3krgYQwkMUGrKz8MuImMmOPxHgcjPMG1a8cVBRvoppItda58PtXeOkJOt kqZ1EJGEJ4TbYzeJVZfJek3GVDUxBmp3dr5JsDEj33AV2KYBJXcE7Gq6ecT95x6WwQbh o3mAMQ/TfNBs5SpUSuuw4DqO+h0fF9SqirnF3/LBxGq89lcY4ZsgZNnx8mjXNan+Jvjo OaPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=p+cYZqPkq2yEiMfVnzXTw563FqsEFK6qc54FcPd8+P0=; fh=Z0zE3h5iywZX90Xt80PXNWHb5LmvjqCl8QAFknyVluQ=; b=rNIgLUbRDOIskQ2izh4IK255LJID+lq3iT2x9gDVoim/dQzVMgZO/ZFp3OkITz/foW q4aEMugeL/ik5VTvfLARF2ZJF+EmSX6uZISmj25C6kAwy0RiglPo0wIXIwn4PvrMBOIF +u8chxbRoHjg7O7zG1BHS/6IAiXpjgdne5EwJjlnbuIIDCQDIKNN+wwVvzu/jbJFOiNd iaJuO3lxVSF5rgk17id8FL6y96a7KJ8ogEfwZ73d+i3AdmYx6Qney3hHovwAu5YGOWtK URs5ulGAhFNJI0WWSUaJCZ3n4ud6Oxw99oC+Gf+d0b8PkIhR3MsPVthIJE5LIVfOSRi+ fp9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ixit.cz header.s=dkim header.b=K3MLvFpI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=ixit.cz Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id be6-20020a0564021a2600b00522384df47fsi5744184edb.319.2023.08.12.12.57.16; Sat, 12 Aug 2023 12:57:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ixit.cz header.s=dkim header.b=K3MLvFpI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=ixit.cz Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229772AbjHLSxQ (ORCPT + 99 others); Sat, 12 Aug 2023 14:53:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229810AbjHLSxM (ORCPT ); Sat, 12 Aug 2023 14:53:12 -0400 Received: from ixit.cz (ip-89-177-23-149.bb.vodafone.cz [89.177.23.149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20CC019A4 for ; Sat, 12 Aug 2023 11:52:58 -0700 (PDT) Received: from newone.lan (unknown [10.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ixit.cz (Postfix) with ESMTPSA id 5C287160D84; Sat, 12 Aug 2023 20:52:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ixit.cz; s=dkim; t=1691866376; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=p+cYZqPkq2yEiMfVnzXTw563FqsEFK6qc54FcPd8+P0=; b=K3MLvFpImbRBT6R7DBzNxwdVTxUCRU1KwWNdGL873rYIcyGGTLP5WDe6SyI5JwTQsX1443 Id9l0PcuhrNLqcy4AKi/D3cqIlztMyWiCScCihqdTzt7pKcmRcaA079VWJ3yjtdt1L1PU5 qL5/zP0mBFSLRdzsrzedG/wCGDD6eG8= From: David Heidelberg To: Neil Armstrong , Sam Ravnborg , David Airlie , Daniel Vetter Cc: David Heidelberg , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [RESEND PATCH v2] drm/panel: JDI LT070ME05000 simplify with dev_err_probe() Date: Sat, 12 Aug 2023 20:52:39 +0200 Message-Id: <20230812185239.378582-1-david@ixit.cz> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,PDS_RDNS_DYNAMIC_FP, RCVD_IN_DNSWL_BLOCKED,RDNS_DYNAMIC,SPF_HELO_PASS,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use the dev_err_probe() helper to simplify error handling during probe. This also handle scenario, when EDEFER is returned and useless error is printed. Fixes error: panel-jdi-lt070me05000 4700000.dsi.0: cannot get enable-gpio -517 Signed-off-by: David Heidelberg --- resend: - applies cleanly on -next v2: - original v1 patch name "drm/panel: JDI LT070ME05000 remove useless warning" - use dev_err_probe function .../gpu/drm/panel/panel-jdi-lt070me05000.c | 36 ++++++++----------- 1 file changed, 14 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c b/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c index e94c98f00391..f9a69f347068 100644 --- a/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c +++ b/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c @@ -400,38 +400,30 @@ static int jdi_panel_add(struct jdi_panel *jdi) ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(jdi->supplies), jdi->supplies); - if (ret < 0) { - dev_err(dev, "failed to init regulator, ret=%d\n", ret); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, + "failed to init regulator, ret=%d\n", ret); jdi->enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_LOW); if (IS_ERR(jdi->enable_gpio)) { - ret = PTR_ERR(jdi->enable_gpio); - dev_err(dev, "cannot get enable-gpio %d\n", ret); - return ret; + return dev_err_probe(dev, PTR_ERR(jdi->enable_gpio), + "cannot get enable-gpio %d\n", ret); } jdi->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH); - if (IS_ERR(jdi->reset_gpio)) { - ret = PTR_ERR(jdi->reset_gpio); - dev_err(dev, "cannot get reset-gpios %d\n", ret); - return ret; - } + if (IS_ERR(jdi->reset_gpio)) + return dev_err_probe(dev, PTR_ERR(jdi->reset_gpio), + "cannot get reset-gpios %d\n", ret); jdi->dcdc_en_gpio = devm_gpiod_get(dev, "dcdc-en", GPIOD_OUT_LOW); - if (IS_ERR(jdi->dcdc_en_gpio)) { - ret = PTR_ERR(jdi->dcdc_en_gpio); - dev_err(dev, "cannot get dcdc-en-gpio %d\n", ret); - return ret; - } + if (IS_ERR(jdi->dcdc_en_gpio)) + return dev_err_probe(dev, PTR_ERR(jdi->dcdc_en_gpio), + "cannot get dcdc-en-gpio %d\n", ret); jdi->backlight = drm_panel_create_dsi_backlight(jdi->dsi); - if (IS_ERR(jdi->backlight)) { - ret = PTR_ERR(jdi->backlight); - dev_err(dev, "failed to register backlight %d\n", ret); - return ret; - } + if (IS_ERR(jdi->backlight)) + return dev_err_probe(dev, PTR_ERR(jdi->backlight), + "failed to register backlight %d\n", ret); drm_panel_init(&jdi->base, &jdi->dsi->dev, &jdi_panel_funcs, DRM_MODE_CONNECTOR_DSI); -- 2.40.1