Received: by 2002:a05:7412:6592:b0:d7:7d3a:4fe2 with SMTP id m18csp1802682rdg; Sat, 12 Aug 2023 18:14:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHNvL1Oixpb6aNiejKn7pzTi22f8GgIFsbWvPct6D+FNQ8XlbMFgWY2OChj0kbPC2PCrjHE X-Received: by 2002:a2e:9042:0:b0:2b5:974f:385 with SMTP id n2-20020a2e9042000000b002b5974f0385mr4333817ljg.9.1691889293906; Sat, 12 Aug 2023 18:14:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691889293; cv=none; d=google.com; s=arc-20160816; b=pPBej6l3GXzKPFuMnHlh/M3o86M7KPrw0Ng40DWejLapWpA95Bu3ahnAJgSaLnI7GC zJtdxKOrwwQzctamNvJA16pzXXRmVCky9Q2L4XIiTI4/02TpdzhjhDdJgDiBMBtOJqBz jdDhj9uYOn3N3NWS4J8bi/CRZQxzzzqyjJdGRRPzjqtUTT/kl8jFDlOSu/9OLwvB+68s 7Yayb0MpM3k2y7wptSNKTAq/MwBbvsRbXTYY6x4ZG2VZ+ESQlKaKkkE/aGTM6YViAcrk xy6j1Ay981mokHEwGDjh5VTqxHKPdflRZ+z20yyzCXxlJwH6hIB05sil985zgQCPWYTs CuYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=ZIX653XuJCeRFQzY3OLN/y++qlr9PHaGWI36dQJFJms=; fh=xRGUOJ5akaY8Al85DTycCJ49WaY/xRRNvOfObSYdfXU=; b=cnnWesuAT42FZCMUFi8TCmiTLKz3/3F3ZuVoAc0YmM/+vDHWUjaLZbES7rCCrC9Tkz gxE+89r9w8qJigZTbibJT4ImNjFvHxYoGXyzryP/nStQjzklHYQnYToiV0lk3JYxwsli y6UwU1VFb7pssiC8CmPNvD1TFiAUP/uMYF+V8snwC3IyRXMj2S2KkjG4pVq56IocA6Dl skIj6+xdpl0+/I1spaxWTkCdioAMTf1gngC5Jzl7WdfYReTuKYkh9tnNz6YCiZE/ry81 923MYbUz5n68TJH4t07Ya7ws1GK5thni9bOXuaPTs3nTX8TLFilSFqvQZtm4CZ1ocn7E RTqw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=sntech.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w24-20020a056402129800b005221eb09887si6188964edv.86.2023.08.12.18.14.26; Sat, 12 Aug 2023 18:14:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=sntech.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229821AbjHLW2a (ORCPT + 99 others); Sat, 12 Aug 2023 18:28:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229589AbjHLW23 (ORCPT ); Sat, 12 Aug 2023 18:28:29 -0400 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F2881984 for ; Sat, 12 Aug 2023 15:28:30 -0700 (PDT) Received: from i53875bbf.versanet.de ([83.135.91.191] helo=phil.lan) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qUx5r-0002QJ-4H; Sun, 13 Aug 2023 00:28:23 +0200 From: Heiko Stuebner To: Jonas Karlman , David Airlie , Daniel Vetter , Sandy Huang Cc: Heiko Stuebner , linux-rockchip@lists.infradead.org, Sascha Hauer , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Andy Yan , Maarten Lankhorst , Mark Yao , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 0/5] drm/rockchip: Fix crtc duplicate state and crtc reset funcs Date: Sun, 13 Aug 2023 00:28:21 +0200 Message-Id: <169187928908.3734147.12874056475289998677.b4-ty@sntech.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230621223311.2239547-1-jonas@kwiboo.se> References: <20230621223311.2239547-1-jonas@kwiboo.se> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_PASS,T_SPF_HELO_TEMPERROR autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 21 Jun 2023 22:33:15 +0000 (UTC), Jonas Karlman wrote: > This series fixes a reset of state in duplicate state crtc funcs for VOP > driver, a possible crash and ensure crtc reset helper is called in VOP2 > driver. > > Patch 1 use kmemdup instead of kzalloc to duplicate the crtc state. > Patch 2 change to use crtc and plane cleanup helpers directly. > Patch 3 adds a null guard for allocation failure. > Patch 4 adds a crash guard for empty crtc state. > Patch 5 adds a missing call to crtc reset helper. > > [...] Applied, thanks! [1/5] drm/rockchip: vop: Fix reset of state in duplicate state crtc funcs commit: 13fc28804bf10ca0b7bce3efbba95c534836d7ca [2/5] drm/rockchip: vop: Use cleanup helper directly as destroy funcs commit: 800f7c332df7cd9614c416fd005a6bb53f96f13c [3/5] drm/rockchip: vop: Fix call to crtc reset helper commit: 5aacd290837828c089a83ac9795c74c4c9e2c923 [4/5] drm/rockchip: vop2: Don't crash for invalid duplicate_state commit: 342f7e4967d02b0ec263b15916304fc54841b608 [5/5] drm/rockchip: vop2: Add missing call to crtc reset helper commit: 4d49d87b3606369c6e29b9d051892ee1a6fc4e75 Best regards, -- Heiko Stuebner