Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 12 Aug 2023 23:46:36 +0200
From:   =?iso-8859-2?Q?Micha=B3_Miros=B3aw?= <mirq-linux@rere.qmqm.pl>
To:     Rob Herring <robh@kernel.org>
Cc:     Svyatoslav Ryhel <clamor95@gmail.com>,
        Andi Shyti <andi.shyti@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Wolfram Sang <wsa@kernel.org>, linux-i2c@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: i2c: add binding for i2c-hotplug-gpio
Message-ID: <ZNf9vKJHc/FFlkY4@qmqm.qmqm.pl>
References: <20230729160857.6332-1-clamor95@gmail.com>
 <20230729160857.6332-2-clamor95@gmail.com>
 <20230811173752.GA3639776-robh@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230811173752.GA3639776-robh@kernel.org>
Precedence: bulk

On Fri, Aug 11, 2023 at 11:37:52AM -0600, Rob Herring wrote:
> On Sat, Jul 29, 2023 at 07:08:56PM +0300, Svyatoslav Ryhel wrote:
[...]
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/i2c/i2c-hotplug-gpio.yaml
[...]
> > +  - |
> > +    /*
> > +     * Asus Transformers use I2C hotplug for attachable dock keyboard
> > +     */
> > +    #include <dt-bindings/gpio/gpio.h>
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +
> > +    i2c-dock {
> > +        compatible = "i2c-hotplug-gpio";
> > +
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
[...]
> > +        i2c-parent = <&gen2_i2c>;
> 
> Couldn't you just add 'detect-gpios' to the existing bus node? It's 
> really part of that bus and there's not a separate bus. That would be a 
> lot simpler. I suppose you want to instantiate a driver, but that's not 
> DT's problem.

Not a driver but a group of devices (possibly discovered dynamically)
behind a passive gate (like e.g. PCA9517A with EN tied to a connector pin).
It's not much different to a I2C gate or mux with a single child bus
(i2c-mux-gpio that has only a single child). For ASUS Transformers with
only the dock plugged-in it could work with a 'detect-gpios' extension
(I'll take a look at how this way would work).  I think there were also
different attachments made you could connect instead of the dock.

Best Regards
Micha? Miros?aw