Received: by 2002:a05:7412:6592:b0:d7:7d3a:4fe2 with SMTP id m18csp1818315rdg; Sat, 12 Aug 2023 19:17:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEeCVlsjhL5gWKHWqtjM86d1VXcEVJy1lm0iyNeBxcULm6nBtK0ihHFUdFIsv8Zux2RlE2l X-Received: by 2002:a17:907:75e7:b0:99c:53f:1dc7 with SMTP id jz7-20020a17090775e700b0099c053f1dc7mr4676172ejc.54.1691893049706; Sat, 12 Aug 2023 19:17:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691893049; cv=none; d=google.com; s=arc-20160816; b=LIpWhenlMNPNgac+A8z20MdYS8zp3pI4PLMSGA9MqOXxK14woOVUD/wXvODlhoi/wM z3M7Nnxdc9Y4SNLYANFKCKsETVRurwoXckhZ7bU4+FTcx+lCZNUtxKGO7knQXER5Ier6 bNwOtLSHTx2WW/IKEY4j5xrsVS1H108OAKr9uIvNjz4E0E6SDGnGaw4JEY54LhTdvkqL ajr+FHNOMEmCBlSV5UibtnTmAPH5XQeSq5KNeubGB3YM9uQKDjESIWvBsuqfPGR3bkcX JTRh8fGVS/YE2XD8Zee56Lnx2Zc7wDeNrqZBbkwVXzI2bzUO//fIetMRK6GpFQfhy6Iq LQkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=GqXXdSXqmSKRlMsBTPl7b4VHj/6r9umG3QZpzsXapms=; fh=5jP6hwykL29nHUNAZNJVE9ZwY5GWsSrFLmxHEl5AEmU=; b=NLEUlkyJV7IWrL3LnL7vkQHs1pBR9ewZFqfUSYJfA8DI5c4uiKW3B/z4Pz8tUgtN79 Bv7mNArABC7sW2s11jFgdrKw7lrrg3TV0zKqq52NwaEQFFFRp3XaK+gJoO4vcNa7uGEw 1Do1IRJJuFR+EuWlHZE1Yn9eMq1DEkP6oqnunKWdteCGDK45QBUEvZ8Okp+6wYuV2s81 LUV3/F4FGr1H2Xaepk8tR2fYdZqQ1gqDOffhMnDJ7osTNcpFhp3SfN646XOTlHkJ62KA OP/DDf8FrRWRR0xWQ4fIP2KohSB2t9D1QbcEJIHN6XLRiynGq4hlMauxIOYbz8M02rfD +xoQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cf20-20020a170906b2d400b00989a806b3fasi5677586ejb.1031.2023.08.12.19.17.05; Sat, 12 Aug 2023 19:17:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230091AbjHMBxa (ORCPT + 99 others); Sat, 12 Aug 2023 21:53:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229458AbjHMBx3 (ORCPT ); Sat, 12 Aug 2023 21:53:29 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A909BAA; Sat, 12 Aug 2023 18:53:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 341CC619D2; Sun, 13 Aug 2023 01:53:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD7C6C433C7; Sun, 13 Aug 2023 01:53:28 +0000 (UTC) Date: Sat, 12 Aug 2023 21:53:27 -0400 From: Steven Rostedt To: Joe Perches Cc: Zheao Li , edumazet@google.com, bpf@vger.kernel.org, davem@davemloft.net, dsahern@kernel.org, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, mhiramat@kernel.org, ncardwell@google.com, netdev@vger.kernel.org, pabeni@redhat.com Subject: Re: [PATCH v3] tracepoint: add new `tcp:tcp_ca_event` trace event Message-ID: <20230812215327.1dbd30f3@rorschach.local.home> In-Reply-To: <6bfa88099fe13b3fd4077bb3a3e55e3ae04c3b5d.camel@perches.com> References: <20230812201249.62237-1-me@manjusaka.me> <20230812205905.016106c0@rorschach.local.home> <20230812210140.117da558@rorschach.local.home> <20230812210450.53464a78@rorschach.local.home> <6bfa88099fe13b3fd4077bb3a3e55e3ae04c3b5d.camel@perches.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 12 Aug 2023 18:17:17 -0700 Joe Perches wrote: > > I forgot to say "for TRACE_EVENT() macros". This is not about what > > checkpatch says about other code. > > trace has its own code style and checkpatch needs another > parsing mechanism just for it, including the alignment to > open parenthesis test. If you have a template patch to add the parsing mechanism, I'd be happy to try to fill in the style. -- Steve