Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c1fb4972-765a-d06a-14d1-028a8a75bd97@suse.com>
Date:   Sun, 13 Aug 2023 09:55:06 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [patch V2 09/37] x86/microcode/intel: Remove pointless mutex
Content-Language: en-US
To:     Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>
Cc:     x86@kernel.org, Borislav Petkov <bp@alien8.de>,
        Ashok Raj <ashok.raj@intel.com>,
        Arjan van de Ven <arjan@linux.intel.com>
References: <20230812194003.682298127@linutronix.de>
 <20230812195728.069849788@linutronix.de>
From:   Nikolay Borisov <nik.borisov@suse.com>
In-Reply-To: <20230812195728.069849788@linutronix.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzJwc0Fna25hQk40dXhYdmFWUlNaMGVCSnYyN3pQanRTSE9xcTVkaXlSRHJF?=
 =?utf-8?B?ZlgwRzlTd001ajUxeDdjTGhLamRrWFJ6N2ZiQWtIT0lMNVJIRzNEOHlqc1RQ?=
 =?utf-8?B?NWt6VEtleGc5VURETE04djc0NTRLaklKQUhSNktqU044ZWVIOUhvRllhOGpo?=
 =?utf-8?B?cVkrbUFmUzBPSnFOblFMY0IwT2E2WEVvY0hIdGdoNEhkM2RCelp2RFN3U3Zi?=
 =?utf-8?B?d0JxcTZNc3dSTk9LblFQcW1qYm5IWUZ1VzBKV0dLNmZjTTB4OEp0THBxVFl4?=
 =?utf-8?B?VEVWbUdEN25LLytmOUIzOGp4anAzY0laN0ZFWlJtdEZvSDNNZm9kNWc3K0NI?=
 =?utf-8?B?RnRDMjEvSG9yYkFoRDh3a2RvQ0pyNUlzS3NrWUlJZGhra2RWNGRoWmM5YU9K?=
 =?utf-8?B?bksyZHl4SFRlcndENXJ2eXlYU2hLeUpyS0V5K1BuT0ZkOGhHeWJDc1dOUXZV?=
 =?utf-8?B?bGJ4dDNRV1JvMmZ0TGVGRHgxTzRzZU9Vek10UlJJM2l0eS9nb0YvSGhaVElw?=
 =?utf-8?B?ekltQy9SVnJtREVHQWo4RmFRL1lhWG4yY1F4Umc5VmhNdmh4Z3RmZzd4K1FP?=
 =?utf-8?B?MnpXM2szVWhTeE0wZXk4ckRpT2h5VzZsMEpvb0NWTEVsTGxxR0F1YnQwN0g0?=
 =?utf-8?B?Ump4KzdkVHVsWWtPaXJRdms2NUNFaXVyZ0pIL2ZYenVHY0g0bnFWTXovQVdp?=
 =?utf-8?B?TERuQWxUVFhmdUQzNHA4WVZCWkVWVEZPNEZlWjRScHQzTGRjYUxnUnBxZVFa?=
 =?utf-8?B?SEVEQnNZbGhzbFdDNTVqME53VjJOWm9JR3RiY1d6bTFUOWZ6OWJEclB0UmVj?=
 =?utf-8?B?MFNLQ3FzZndJelhLL3c1VDlZOVVpZVNZNmRSY08wVEgwd0FXU05ZdzVXUEQw?=
 =?utf-8?B?eWpQSlFJdWN0cE1PYXY0UWI5a0I3c3RES3Y3eXoyWkJUcThMU0x3K20yT3Zt?=
 =?utf-8?B?STlwRVVOQW5rbk1wWTY3ZFVxZzNpa1FTL2lJQkZLbThlbGhqcWs5djV5Y05Y?=
 =?utf-8?B?SENabHRmbEs1R0pKZFI1VE5jYkN1NjBJSGRPZmJlZ0ZnSGRsYjdKQlVwRXNB?=
 =?utf-8?B?MDJIdnUrdVZXU0ZqTFV1cHcwTC9GY1Y1MkdhT2VEZmJ0RGZrTVB4cGlOS0Fn?=
 =?utf-8?B?N1pJQjdFVGYxVnhUMElBUzB3S1lrODYvMG5YNUlHTGlaalhJQXh1UFJDN0pN?=
 =?utf-8?B?WFJwdnMya050aUsrVjZsNXRudEtRNXA2cnkvZFM5TENWbGFIamozdU8vSE1G?=
 =?utf-8?B?eGhTTGozQkh5RFJKTzRZVERXT1VwZzJsRm1NTDE3UkZ6aTh2eXpqNmduMVNW?=
 =?utf-8?B?T2FCNCtQV3hoRVc0UDltRUExcXZkWW1NOU4wdXNuSEkxa1hRRXVIYm5vaU5U?=
 =?utf-8?B?bTlDTlErS2FkdU1UV09QZnpUb3BTNWtyLys2Z2dGYVJPQS9LSjltQ1kzb1Nq?=
 =?utf-8?B?d0hIYTYyc00raEp3bUJ3azhCTWNHTGgwdzB5bzR5bkFEZHlOYlNxRkcxTWZ5?=
 =?utf-8?B?bnNScWhMdzZjRkNiRnRNS08wa2ZScHdHdEtCSzBlM1owaElybStlRmQ5SDhz?=
 =?utf-8?B?MU5yZzliTFJ4dWxRVjV3WFZIQWhxNmFlU0ltVm9seURuTkxNZHdUUk5HdEsv?=
 =?utf-8?B?b3JkWnpacWVwbThici9HYkt1UXVzYkpaZGIrUkpTRityQ0ZqbzBnOUVkK3Z3?=
 =?utf-8?B?S1B6ajBGT0hrSE1rcVlBVFAweE5HMTQ2clNCUmErdk1rU2N6M04wcEcrcDlk?=
 =?utf-8?B?eDBYTkY4Y1FDK0ZhNFhkdUdaNXV0cGF1am1pYVhjcFpZZm1wNkZCdnh5byt1?=
 =?utf-8?B?TDNJdzlDbE5ZVWFpTXlpdW4ySGFHcHoyemNFTTdzb2Fjckl6QkJTZkRYYXc5?=
 =?utf-8?B?cVpDLzBNeWJNSUdrMkJROHNYSk0va0tjcUpoUU54d0ZUL0hRK2Q1eExwVTBC?=
 =?utf-8?B?Vk5VRVYvNFlrazJObE8zWFZ2YW1LNEZKTlQvL0hYaEVzQWJUeFZpY3I4SW5J?=
 =?utf-8?B?NXVlUTNscStBRW05S1l0UXFXNVc2QUxhamt5RGlleEt1UFlrNStRL0NWY1ph?=
 =?utf-8?B?RklkVWozanJVRi8vbHBmZ2k4SkVyNUhBY3NtTWtmeWZhOG9ZM2dKeHBIWlYy?=
 =?utf-8?Q?Z1t/1AwExDxT2dTS+1rlqhlyx?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a9c9f56-2b90-4c66-1d8c-08db9bca3c45
X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB7790.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Aug 2023 06:55:10.1713
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: q3L+qCB63P5AE8EGoJNRC7koRcShCV8MEaXgKkUNtC5IhJAzyHDo11FAYn8xYecT1Age5ffjxqrkdlkqFZFW1Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7525
X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 12.08.23 г. 22:58 ч., Thomas Gleixner wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
> 
> There is no concurreny.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> 
> ---
>   arch/x86/kernel/cpu/microcode/intel.c |   24 ++----------------------
>   1 file changed, 2 insertions(+), 22 deletions(-)
> ---
> --- a/arch/x86/kernel/cpu/microcode/intel.c
> +++ b/arch/x86/kernel/cpu/microcode/intel.c
> @@ -397,22 +397,6 @@ scan_microcode(void *data, size_t size,
>   	return patch;
>   }
>   
> -/*
> - * Save this microcode patch. It will be loaded early when a CPU is
> - * hot-added or resumes.
> - */
> -static void save_mc_for_early(struct ucode_cpu_info *uci, u8 *mc, unsigned int size)
> -{
> -	/* Synchronization during CPU hotplug. */
> -	static DEFINE_MUTEX(x86_cpu_microcode_mutex);
> -
> -	mutex_lock(&x86_cpu_microcode_mutex);
> -
> -	save_microcode_patch(uci, mc, size);
> -
> -	mutex_unlock(&x86_cpu_microcode_mutex);
> -}
> -


So this function is ultimately invoked from a write to the 'reload' 
sysfs file, what about 2 racing writes to this file ? Though if it's 
about cpu hotplug then in reload_store() this is handled via 
cpus_read_lock I guess so indeed this is correct.