Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 13 Aug 2023 00:11:37 -0700
From:   Tree Davies <tdavies@darkphysics.net>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     philipp.g.hortmann@gmail.com, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/6] Staging: rtl8192e: Rename variable pTS in
 function rtllib_rx_ADDBAReq()
Message-ID: <ZNiCKbAFZ4UOtSn1@basil>
References: <20230813065035.95157-1-tdavies@darkphysics.net>
 <20230813065035.95157-3-tdavies@darkphysics.net>
 <2023081315-grandma-fifth-1e9c@gregkh>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2023081315-grandma-fifth-1e9c@gregkh>
Precedence: bulk

On Sun, Aug 13, 2023 at 08:55:21AM +0200, Greg KH wrote:
> On Sat, Aug 12, 2023 at 11:50:31PM -0700, Tree Davies wrote:
> > Rename variable pTS in function rtllib_rx_ADDBAReq() to rx_ts
> > to fix checkpatch warning Avoid CamelCase.
> > 
> > Signed-off-by: Tree Davies <tdavies@darkphysics.net>
> > ---
> > v2:Resending in smaller patch series
> >  drivers/staging/rtl8192e/rtl819x_BAProc.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> > index 1eff30533f47..2748ab59545c 100644
> > --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
> > +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> > @@ -220,7 +220,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb)
> >  	union ba_param_set *pBaParamSet = NULL;
> >  	u16 *pBaTimeoutVal = NULL;
> >  	union sequence_control *pBaStartSeqCtrl = NULL;
> > -	struct rx_ts_record *pTS = NULL;
> > +	struct rx_ts_record *rx_ts = NULL;
> 
> This should just be called "ts" as that's what it is being used for, as
> the original name says.
> 
> I've stopped reviewing the series here, please go through and make sure
> all of your renames make logical sense as that is important when reading
> the code in the future.
> 
> thanks,
> 
> greg k-h

Thanks Greg, will fix.
~Tree