Received: by 2002:a05:7412:6592:b0:d7:7d3a:4fe2 with SMTP id m18csp1945886rdg; Sun, 13 Aug 2023 02:52:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEsmZH+pdsUc3qWQhCnrD4wu9IVB15A8VkVn2NP2Dfm+MpV0sxs/DevVZkZ8ZHk5qwxqwfh X-Received: by 2002:a05:6402:696:b0:522:3a89:a7bc with SMTP id f22-20020a056402069600b005223a89a7bcmr4623498edy.42.1691920369552; Sun, 13 Aug 2023 02:52:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691920369; cv=none; d=google.com; s=arc-20160816; b=C1fevEfgerUoWZ0ryR18qkdIXVweUxLK7YNayFxV/q+ril6awezhAXqzx2B0bCdtJ5 SQhF1u05MNuRHqOLU892vTTZu41cwHGdD3YKfa6GExPkTq0i4W1kRuFOguDSrG+p6mxq xGh0m6kvhY0vNEui8yF6FjEAmoau9kwJNEEGI12amvsOUZniC+PDfreevPKHiSnJ+tc2 Jyvck9uuk+HUr8ZMOKeGdHXrScQeTxmNy5woufvYe4sFB8/dJ6LPTFBcolE4apc0KnrA hSNxxGITs9+sbDJ8wAc5xnIoQUOOXhRRtIiObMhFozbGcphApbRdc8WcQcxGsDb1bryK G99g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature; bh=vxennY8ANUtnDa+XJCb9lNsyatKpI4/A8rOOfrUJu2M=; fh=aYxbkv1sF29S2sQIrDHAVMARXGob+x4JAj7v+jCexxc=; b=qG3wFQHuRRZm2VuNZjN3QGgzpz1sUNirNXeAUD1RCMel0ZkuxmNpugSg/BvcFdpXyg eZxaqDi+L0io5rjP6C9oqvWrpYM9sNqtT0nZ+HxS7XFy6W9266LpJCM+yjdfdBYZqUIO cWRlfS2F78991gyVRjdoxhhzNSBPaqC2sEsa/RKkgLd0dPtxpSXEvBaF0VF4vHMvam/7 yj/L1r7MTjx89kWXhduXlemygEdrT/RKB6qGtTsyacSgQ5ul57mIrOC7Al0hTwvdC6/F jKXdnYeJKfBlkvBaYzYks867BPAxO2JlQzLF8ySLQhTQwoHNjVOCa5WpL28EfES3XJug G09w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@pobox.com header.s=sasl header.b="fM/2ESp5"; dkim=neutral (body hash did not verify) header.i=@darkphysics.net header.s=2019-09.pbsmtp header.b=idL3b1Ns; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r16-20020aa7da10000000b005231977092fsi5985091eds.546.2023.08.13.02.52.24; Sun, 13 Aug 2023 02:52:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@pobox.com header.s=sasl header.b="fM/2ESp5"; dkim=neutral (body hash did not verify) header.i=@darkphysics.net header.s=2019-09.pbsmtp header.b=idL3b1Ns; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230242AbjHMGtE (ORCPT + 99 others); Sun, 13 Aug 2023 02:49:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230209AbjHMGsz (ORCPT ); Sun, 13 Aug 2023 02:48:55 -0400 Received: from pb-smtp2.pobox.com (pb-smtp2.pobox.com [64.147.108.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07191171D for ; Sat, 12 Aug 2023 23:48:54 -0700 (PDT) Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 63EC21A3DEB; Sun, 13 Aug 2023 02:48:54 -0400 (EDT) (envelope-from tdavies@darkphysics.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; s=sasl; bh=PcLXtUljWKv/4ouQcNZrq39h6 QaqnaGY6jwx/OUHT9o=; b=fM/2ESp5FMd0PMzMhT4EYpFBH7YM3mktWYfRdSuMq ON9vaXdXv+qUKtkyZlb9CF/DFHSH/VswJtYQLSDOCtOuxfHHc+OAKKWfG9ERCf5e 1Pw7GRoxQ5ZsXWiewxT4wTRteXd8NWC0//4v87S1W81v5BBDK78Jx+dh7HC82sFU Pw= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 5B8FB1A3DEA; Sun, 13 Aug 2023 02:48:54 -0400 (EDT) (envelope-from tdavies@darkphysics.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=darkphysics.net; h=from:to:cc:subject:date:message-id:in-reply-to:references:mime-version:content-transfer-encoding; s=2019-09.pbsmtp; bh=xivH+ZMVje0qkRNh8Vy/E+f0jKARuDcnh8KGiyXJu2E=; b=idL3b1NsJBHsLIbbQHWpLN6FQ8LdCffzaKDN1YXh68mZOZNdQEQ5nqmLp5g0k1ZmRO5H3pi91h313id12apU/RIIg1+GF1CNDX+vljAJtnOZD5r/QBip/T4Fg28N0irxCDtFmiUnFNzE7Bjb/x1UREdq+XxqMmoXrP7O59k0FJE= Received: from basil.darkphysics (unknown [76.146.178.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id BBDBD1A3DE6; Sun, 13 Aug 2023 02:48:51 -0400 (EDT) (envelope-from tdavies@darkphysics.net) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 6/6] Staging: rtl8192e: Rename variable pRxTs in function RxPktPendingTimeout() Date: Sat, 12 Aug 2023 23:50:35 -0700 Message-ID: <20230813065035.95157-7-tdavies@darkphysics.net> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230813065035.95157-1-tdavies@darkphysics.net> References: <20230813065035.95157-1-tdavies@darkphysics.net> MIME-Version: 1.0 X-Pobox-Relay-ID: 777C790A-39A5-11EE-BC63-307A8E0A682E-45285927!pb-smtp2.pobox.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,NO_DNS_FOR_FROM,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE, SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Rename variable pRxTs in function RxPktPendingTimeout() to rx_ts to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies --- v2:Resending in smaller patch series drivers/staging/rtl8192e/rtl819x_TSProc.c | 32 +++++++++++------------ 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/= rtl8192e/rtl819x_TSProc.c index 24a8b9fc0168..1c78134fc625 100644 --- a/drivers/staging/rtl8192e/rtl819x_TSProc.c +++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c @@ -10,10 +10,10 @@ =20 static void RxPktPendingTimeout(struct timer_list *t) { - struct rx_ts_record *pRxTs =3D from_timer(pRxTs, t, + struct rx_ts_record *rx_ts =3D from_timer(rx_ts, t, rx_pkt_pending_timer); - struct rtllib_device *ieee =3D container_of(pRxTs, struct rtllib_device= , - RxTsRecord[pRxTs->num]); + struct rtllib_device *ieee =3D container_of(rx_ts, struct rtllib_device= , + RxTsRecord[rx_ts->num]); =20 struct rx_reorder_entry *pReorderEntry =3D NULL; =20 @@ -22,24 +22,24 @@ static void RxPktPendingTimeout(struct timer_list *t) bool bPktInBuf =3D false; =20 spin_lock_irqsave(&(ieee->reorder_spinlock), flags); - if (pRxTs->rx_timeout_indicate_seq !=3D 0xffff) { - while (!list_empty(&pRxTs->rx_pending_pkt_list)) { + if (rx_ts->rx_timeout_indicate_seq !=3D 0xffff) { + while (!list_empty(&rx_ts->rx_pending_pkt_list)) { pReorderEntry =3D (struct rx_reorder_entry *) - list_entry(pRxTs->rx_pending_pkt_list.prev, + list_entry(rx_ts->rx_pending_pkt_list.prev, struct rx_reorder_entry, List); if (index =3D=3D 0) - pRxTs->rx_indicate_seq =3D pReorderEntry->SeqNum; + rx_ts->rx_indicate_seq =3D pReorderEntry->SeqNum; =20 if (SN_LESS(pReorderEntry->SeqNum, - pRxTs->rx_indicate_seq) || + rx_ts->rx_indicate_seq) || SN_EQUAL(pReorderEntry->SeqNum, - pRxTs->rx_indicate_seq)) { + rx_ts->rx_indicate_seq)) { list_del_init(&pReorderEntry->List); =20 if (SN_EQUAL(pReorderEntry->SeqNum, - pRxTs->rx_indicate_seq)) - pRxTs->rx_indicate_seq =3D - (pRxTs->rx_indicate_seq + 1) % 4096; + rx_ts->rx_indicate_seq)) + rx_ts->rx_indicate_seq =3D + (rx_ts->rx_indicate_seq + 1) % 4096; =20 netdev_dbg(ieee->dev, "%s(): Indicate SeqNum: %d\n", @@ -58,7 +58,7 @@ static void RxPktPendingTimeout(struct timer_list *t) } =20 if (index > 0) { - pRxTs->rx_timeout_indicate_seq =3D 0xffff; + rx_ts->rx_timeout_indicate_seq =3D 0xffff; =20 if (index > REORDER_WIN_SIZE) { netdev_warn(ieee->dev, @@ -72,9 +72,9 @@ static void RxPktPendingTimeout(struct timer_list *t) bPktInBuf =3D false; } =20 - if (bPktInBuf && (pRxTs->rx_timeout_indicate_seq =3D=3D 0xffff)) { - pRxTs->rx_timeout_indicate_seq =3D pRxTs->rx_indicate_seq; - mod_timer(&pRxTs->rx_pkt_pending_timer, jiffies + + if (bPktInBuf && (rx_ts->rx_timeout_indicate_seq =3D=3D 0xffff)) { + rx_ts->rx_timeout_indicate_seq =3D rx_ts->rx_indicate_seq; + mod_timer(&rx_ts->rx_pkt_pending_timer, jiffies + msecs_to_jiffies(ieee->ht_info->rx_reorder_pending_time) ); } --=20 2.41.0