Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "G Thomas, Rohan" <rohan.g.thomas@intel.com>
To:     "jszhang@kernel.org" <jszhang@kernel.org>
CC:     "alexandre.torgue@foss.st.com" <alexandre.torgue@foss.st.com>,
        "conor+dt@kernel.org" <conor+dt@kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "edumazet@google.com" <edumazet@google.com>,
        "joabreu@synopsys.com" <joabreu@synopsys.com>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-stm32@st-md-mailman.stormreply.com" 
        <linux-stm32@st-md-mailman.stormreply.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "peppe.cavallaro@st.com" <peppe.cavallaro@st.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>
Subject: Re: [PATCH net-next v3 03/10] net: stmmac: mdio: enlarge the max
 XGMAC C22 ADDR to 31
Thread-Topic: Re: [PATCH net-next v3 03/10] net: stmmac: mdio: enlarge the max
 XGMAC C22 ADDR to 31
Thread-Index: AdnN64iTNewURgUoSuyDlZj1njalFw==
Date:   Sun, 13 Aug 2023 14:18:27 +0000
Message-ID: <DM3PR11MB871491A357B9A12BF1B0CC82DE16A@DM3PR11MB8714.namprd11.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VbzEWJQQbUoCAsPHEIpBPZriIQFOJHwwflswVQog5SJIPM52NOvy3Qbt9YNV?=
 =?us-ascii?Q?q499XE7HLIbNlx0XuZBNkaJjc3Q25Ia+SDnphCuvlGRqRN5aLHOH1EPqmhA4?=
 =?us-ascii?Q?bo9Khwl6Wnv5sm5rlLDNRHr8pbtRm3Olo36qpxB4pIsKOCHYyJG6xoyXwxMs?=
 =?us-ascii?Q?9h0QnUWyyOJQXZ0YM4U+Ic3fl3LehPf9FtjwRHrZSiiHrrta6orNjtt7P3Eu?=
 =?us-ascii?Q?5EWBpH9BlCE0/eb6BjtKxrOzpfZ4cxb5ngr7XEdNvEcnUpSDj7n5E0lujxlB?=
 =?us-ascii?Q?h8Abt226HIYvmcPL1TwGOuD0BRxx54BMaNwCvIO9zedKFgGYY5e7rllDdiAo?=
 =?us-ascii?Q?bsDstZs1RQg02Z1T5m3+kqGptlZAIPF6DyivVUHV7L8+tlX+velGJ7MLxRz7?=
 =?us-ascii?Q?Ob/AlseYxcbrLI0gvCWhP3s6SjY7ZHpQ7RxYbsmkUxy4hTMNsAQ5ZhAbg+VO?=
 =?us-ascii?Q?38DKr6KHVS+EatduprsveJWPArNQYdmeSdtyGsONKq9TjK/6gFuojMmlELEM?=
 =?us-ascii?Q?zU7PzRdWACzeqCs5vfGZUTXxv3tN1JXW5S0GPORlMUWbKU+xZhUiXdgpexpO?=
 =?us-ascii?Q?qeAZOL7lzj3P2arF97SBEFm9JX1KSPKBVv+jrJ6sA4skwOMa6UBjB5aZX5PW?=
 =?us-ascii?Q?gm0qSj/Tcm0F538sEpq7TIlLq/W21wXm/pAV5jNN/2ZomkYD0B+GSQUGB9++?=
 =?us-ascii?Q?xMwOgVei1V9aliw2aBUICkt3l5YxfjMgTeBhIpbud/t8i7yXADhQeSWRIV+i?=
 =?us-ascii?Q?I9tjWzs+8EkJ6ybEHCS0+ppkJZKvQ/HinYY4s3AQnqCghhcgbudVJoFPDr7q?=
 =?us-ascii?Q?ff/bBK+ZPyJiyP7foUSzycIhm6yNl+HpNwrUjuFleZY7E3JRhxp3ep5rtzm5?=
 =?us-ascii?Q?5lyUJHDzdURKpAkEWmtZw7a2iOsIS65I4gXFc/5Vj+r3K2GoqMmPUgD7IK37?=
 =?us-ascii?Q?CMqhnLrElVQi3DNxNUAFkWiL0yu6qJz3TULpKLdFLmuiV8sTKmTeb/Xge6rA?=
 =?us-ascii?Q?feitfmlipPIZy+z6uXhyblIHnq/RH6SHSx+JUosxjwjB6WCRuA713RbAlVP8?=
 =?us-ascii?Q?16sLEpeJv/Ln4ye4LATl44VYmwXqk+tT+C4Y3TkMwtj/bA3GTh2phbpDe0GV?=
 =?us-ascii?Q?Cd9q4o7rqHOPfJ0tWpHRCXHDKzto60mYz3+x+L0hTPG3jcokRp+QW/E+eUpY?=
 =?us-ascii?Q?sNYZWstkugYsT7gQNbF2rH0EghlEURM4oODLulNY+z+9dOL/bw39D6ffn7z2?=
 =?us-ascii?Q?BDlY/Ndmzzm5Sa67aKc3So+XxRMYRk48Kr2i1sg0Wa1CepATOWinSoRu2QOC?=
 =?us-ascii?Q?AXVESlcrrW2x3jkPD+C9fB2xtoZ6n5JqCNKr1IW9qvNU9FU1t1EB2Se70nVf?=
 =?us-ascii?Q?sed1Xt1aS7iICmnmmoNvoDWFyP9L6J2IPEl1dGOUru/KLTjw+1hs9cw1X9DO?=
 =?us-ascii?Q?gzgBR9p6Tgs/mJbQdopI8s2Uc+VXQX9vDb7uJmbtocTzRP6Nu20XrtZIkntr?=
 =?us-ascii?Q?uLajo0UFmGadfn2vImkHLbg1vaJdNZz1N5NV8PUuzBds9R1XU68J75i1pMAw?=
 =?us-ascii?Q?rKiVntObqY0xPhMTKcK9E/N8PLV0WA/b81/+JraB?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM3PR11MB8714.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 090729dc-b9ea-43de-2571-08db9c0829eb
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Aug 2023 14:18:27.9451
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Zz0FiPSy3zx1j7ehIrxH4keH4iM4UiZQtrgB2Y+/e538zTzoDLg57LCehLrI1bC/P7WCuIm9tKSS5jTH1jh79A5Q1VFvQUn5nZHEeWSuJLE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7171
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/9/23 18:50, Jisheng Zhang wrote:
> The IP can support up to 31 xgmac c22 addresses now.
>=20
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> ---
>   drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/=
net/ethernet/stmicro/stmmac/stmmac_mdio.c
> index 3db1cb0fd160..e6d8e34fafef 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> @@ -40,7 +40,7 @@
>   #define MII_XGMAC_WRITE			(1 << MII_XGMAC_CMD_SHIFT)
>   #define MII_XGMAC_READ			(3 << MII_XGMAC_CMD_SHIFT)
>   #define MII_XGMAC_BUSY			BIT(22)
> -#define MII_XGMAC_MAX_C22ADDR		3
> +#define MII_XGMAC_MAX_C22ADDR		31
>   #define MII_XGMAC_C22P_MASK		GENMASK(MII_XGMAC_MAX_C22ADDR, 0)
>   #define MII_XGMAC_PA_SHIFT		16
>   #define MII_XGMAC_DA_SHIFT		21

Recent commit 10857e677905 ("net: stmmac: XGMAC support for mdio C22
addr > 3") already addressed this in a different way. As per Synopsis
IP team until version 2.2, XGMAC supports only MDIO devices 0 - 3. An
XGMAC IP version check is newly added for the same reason. I think this
covers your commit also. Please have a look and if so you can drop this
commit.

BR,
Rohan