Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jernej =?utf-8?B?xaBrcmFiZWM=?= <jernej.skrabec@gmail.com>
To:     linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev,
        linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
        Andrei Coardos <aboutphysycs@gmail.com>
Cc:     samuel@sholland.org, wens@csie.org, rui.zhang@intel.com,
        amitk@kernel.org, daniel.lezcano@linaro.org, rafael@kernel.org,
        tiny.windzz@gmail.com, anarsoul@gmail.com, alex@shruggie.ro,
        Andrei Coardos <aboutphysycs@gmail.com>
Subject: Re: [PATCH] thermal: sun8i_thermal: remove unneeded call to
 platform_set_drvdata()
Date:   Sun, 13 Aug 2023 17:32:52 +0200
Message-ID: <4850013.31r3eYUQgx@jernej-laptop>
In-Reply-To: <20230811194032.4240-1-aboutphysycs@gmail.com>
References: <20230811194032.4240-1-aboutphysycs@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Precedence: bulk

Dne petek, 11. avgust 2023 ob 21:40:32 CEST je Andrei Coardos napisal(a):
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
> 
> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>

Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej

> ---
>  drivers/thermal/sun8i_thermal.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/thermal/sun8i_thermal.c
> b/drivers/thermal/sun8i_thermal.c index 195f3c5d0b38..61a2f287ac90 100644
> --- a/drivers/thermal/sun8i_thermal.c
> +++ b/drivers/thermal/sun8i_thermal.c
> @@ -489,8 +489,6 @@ static int sun8i_ths_probe(struct platform_device *pdev)
> if (!tmdev->chip)
>  		return -EINVAL;
> 
> -	platform_set_drvdata(pdev, tmdev);
> -
>  	ret = sun8i_ths_resource_init(tmdev);
>  	if (ret)
>  		return ret;