Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 13 Aug 2023 17:26:47 +0300
From:   Serge Semin <fancer.lancer@gmail.com>
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Marc Zyngier <maz@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>,
        Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= <philmd@linaro.org>,
        wangjianli <wangjianli@cdjrlc.com>, linux-mips@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] irqchip: mips-gic: mark gic_irq_domain_free() static
Message-ID: <3airu2djxchrycegbfb6ijp6cjlxldybo6vzl7ncfwesuitm3e@uilhuqoa6okq>
References: <20230810123404.1222332-1-arnd@kernel.org>
 <20230810123404.1222332-2-arnd@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230810123404.1222332-2-arnd@kernel.org>
Precedence: bulk

On Thu, Aug 10, 2023 at 02:33:55PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> This function is only used locally and should be static to avoid a warning:
> 
> drivers/irqchip/irq-mips-gic.c:560:6: error: no previous prototype for 'gic_irq_domain_free' [-Werror=missing-prototypes]
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/irqchip/irq-mips-gic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-mips-gic.c b/drivers/irqchip/irq-mips-gic.c
> index 6d5ecc10a8703..76253e864f230 100644
> --- a/drivers/irqchip/irq-mips-gic.c
> +++ b/drivers/irqchip/irq-mips-gic.c
> @@ -557,7 +557,7 @@ static int gic_irq_domain_alloc(struct irq_domain *d, unsigned int virq,
>  	return gic_irq_domain_map(d, virq, hwirq);
>  }
>  

> -void gic_irq_domain_free(struct irq_domain *d, unsigned int virq,
> +static void gic_irq_domain_free(struct irq_domain *d, unsigned int virq,
>  			 unsigned int nr_irqs)

Right. Thanks! Note the descendant line should be aligned to the
function open parenthesis to preserve the coding style well
utilized in the driver. With that fixed feel free to add:

Reviewed-by: Serge Semin <fancer.lancer@gmail.com>

-Serge(y)

>  {
>  }
> -- 
> 2.39.2
>