Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jernej =?utf-8?B?xaBrcmFiZWM=?= <jernej.skrabec@gmail.com>
To:     Martin Botka <martin@biqu3d.com>,
        Martin Botka <martin.botka1@gmail.com>,
        Icenowy Zheng <uwu@icenowy.me>
Cc:     Konrad Dybcio <konrad.dybcio@somainline.org>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@somainline.org>,
        Marijn Suijten <marijn.suijten@somainline.org>,
        Jami Kettunen <jamipkettunen@somainline.org>,
        Paul Bouchara <paul.bouchara@somainline.org>,
        Martin Botka <martin.botka@somainline.org>,
        Andre Przywara <andre.przywara@arm.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Chen-Yu Tsai <wens@csie.org>,
        Samuel Holland <samuel@sholland.org>,
        Ludwig Kormann <ludwig.kormann@ict42.de>,
        Andrew Lunn <andrew@lunn.ch>, Heiko Stuebner <heiko@sntech.de>,
        Shawn Guo <shawnguo@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Chris Morgan <macromorgan@hotmail.com>,
        Jagan Teki <jagan@edgeble.ai>,
        Maxime Ripard <mripard@kernel.org>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/4] arm64: dts: allwinner: h616: Add BigTreeTech Pi support
Date:   Sun, 13 Aug 2023 17:57:24 +0200
Message-ID: <1937906.PYKUYFuaPT@jernej-laptop>
In-Reply-To: <200cfafd7ba034d7620740c510c703f3acbeb721.camel@icenowy.me>
References: <20230807145349.2220490-1-martin@biqu3d.com>
 <09BFA974F83AB0E8+20230807145349.2220490-5-martin@biqu3d.com>
 <200cfafd7ba034d7620740c510c703f3acbeb721.camel@icenowy.me>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Dne nedelja, 13. avgust 2023 ob 17:42:10 CEST je Icenowy Zheng napisal(a):
> =E5=9C=A8 2023-08-07=E6=98=9F=E6=9C=9F=E4=B8=80=E7=9A=84 16:53 +0200=EF=
=BC=8CMartin Botka=E5=86=99=E9=81=93=EF=BC=9A
>=20
> > The BigTreeTech Pi is an H616 based board based on CB1.
> > Just in Rpi format board.
> >=20
> > It features the same internals as BTT CB1 but adds:
> >     - Fan port
> >     - IR receiver
> >     - ADXL345 Accelerometer connector via SPI
> >     - 24V DC power supply via terminal plugs
> >     - USB to CAN module connector (The actual USB to CAN happens on
> > the external module)
> >=20
> > List of currently working things is same as BTT CB1 but also:
> >     - IR receiver
> >     - ADXL345 connector
> >=20
> > Signed-off-by: Martin Botka <martin@biqu3d.com>
> > Reviewed-by: Andre Przywara <andre.przywara@arm.com>
> > ---
> > Changes in V2:
> >     - Add UART alongside aliases and chosen for it
> >     - Add model string
> >     - Enable IR receiver
> >     - Enable SPI0 for ADXL345 connector
> > Changes in V3:
> >     - Add missing semicolons
> >     - Add pinctrl for SPI0
> >=20
> >  arch/arm64/boot/dts/allwinner/Makefile        |  1 +
> >  .../allwinner/sun50i-h616-bigtreetech-pi.dts  | 70
> > +++++++++++++++++++
> >  2 files changed, 71 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h616-
> > bigtreetech-pi.dts
> >=20
> > diff --git a/arch/arm64/boot/dts/allwinner/Makefile
> > b/arch/arm64/boot/dts/allwinner/Makefile
> > index 7b386428510b..0b6232a7f328 100644
> > --- a/arch/arm64/boot/dts/allwinner/Makefile
> > +++ b/arch/arm64/boot/dts/allwinner/Makefile
> > @@ -39,5 +39,6 @@ dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-h6-pine-h64-
> > model-b.dtb
> >  dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-h6-tanix-tx6.dtb
> >  dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-h6-tanix-tx6-mini.dtb
> >  dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-h616-bigtreetech-cb1-manta.dtb
> > +dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-h616-bigtreetech-pi.dtb
> >  dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-h616-orangepi-zero2.dtb
> >  dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-h616-x96-mate.dtb
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-
> > pi.dts b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
> > new file mode 100644
> > index 000000000000..b0d0386e8f13
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
> > @@ -0,0 +1,70 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ or MIT)
> > +/*
> > + * Copyright (C) 2023 Martin Botka <martin@biqu3d.com>.
> > + */
> > +
> > +/dts-v1/;
> > +
> > +#include "sun50i-h616-bigtreetech-cb1.dtsi"
> > +
> > +/ {
> > +       model =3D "BigTreeTech Pi";
> > +       compatible =3D "bigtreetech,pi", "allwinner,sun50i-h616";
>=20
> As you say it's based on CB1 too, why no CB1 compatible here? (although
> the manta compatible won't apply)

Because it doesn't contain module per se.

Best regards,
Jernej

>=20
> > +
> > +       aliases {
> > +               serial0 =3D &uart0;
> > +       };
> > +
> > +       chosen {
> > +               stdout-path =3D "serial0:115200n8";
> > +       };
> > +};
> > +
> > +&ehci0 {
> > +       status =3D "okay";
> > +};
> > +
> > +&ehci1 {
> > +       status =3D "okay";
> > +};
> > +
> > +&ehci2 {
> > +       status =3D "okay";
> > +};
> > +
> > +&ehci3 {
> > +       status =3D "okay";
> > +};
> > +
> > +&ir {
> > +       status =3D "okay";
> > +};
> > +
> > +&ohci0 {
> > +       status =3D "okay";
> > +};
> > +
> > +&ohci1 {
> > +       status =3D "okay";
> > +};
> > +
> > +&ohci2 {
> > +       status =3D "okay";
> > +};
> > +
> > +&ohci3 {
> > +       status =3D "okay";
> > +};
> > +
> > +&spi0 {
> > +       /* SPI connection for onboard connector for ADXL345
> > accelerometer */
> > +       status =3D "okay";
> > +       pinctrl-names =3D "default";
> > +       pinctrl-0 =3D <&spi0_pins>, <&spi0_cs0_pin>;
> > +};
> > +
> > +&uart0 {
> > +       pinctrl-names =3D "default";
> > +       pinctrl-0 =3D <&uart0_ph_pins>;
> > +       status =3D "okay";
> > +};