Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fa1e65d6-5e1f-f58d-1922-0194044d8bdf@suse.com>
Date:   Sun, 13 Aug 2023 23:02:05 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [patch V2 26/37] x86/microcode: Clarify the late load logic
Content-Language: en-US
To:     Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>
Cc:     x86@kernel.org, Borislav Petkov <bp@alien8.de>,
        Ashok Raj <ashok.raj@intel.com>,
        Arjan van de Ven <arjan@linux.intel.com>,
        Nikolay Borisov <nik.borisov@suse.com>
References: <20230812194003.682298127@linutronix.de>
 <20230812195729.045205660@linutronix.de>
From:   Nikolay Borisov <nik.borisov@suse.com>
In-Reply-To: <20230812195729.045205660@linutronix.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RDZXL1EzSEJLVDFSVG5Gc2pibGpyeUFoZTEvMW1QdCt2ZThka2hrN1BSRzY0?=
 =?utf-8?B?clIrcGE0aTI0VEtiODJjeHZLdG5xWVpvNXAxbnpVVUlmYVRYNGl5bEkyYjNN?=
 =?utf-8?B?Q0FLQm9hS2dkRkRDang2S0p6Zkk1MU5JcyttQWtUZzVZeFlyM2hHUEovQkds?=
 =?utf-8?B?YTlIQm5HTlVZSkJwWGt4aXB3UEVCUE5sZTJYWEZUd2YwbmlWSlFmaVVmcGFY?=
 =?utf-8?B?NklqWXlZb1BKN0FwNkhxZ0pOaHozc0VTM0N6MjVGR1o1Rmt2cVUxdHVDV3Jl?=
 =?utf-8?B?WUFQbkJzZzFTR3RiTDF5K3F6c2Q0MW5VZ1psbGM0cnF6OEF1aThIamlZZHRU?=
 =?utf-8?B?ckVEZmRuZXFXWUJlb3FJaWx5N202bkRpRjlMSXVkZEhoTTczTWJVaFJyU1J5?=
 =?utf-8?B?ZjVZUnE1bHZJL0R5T3dBem9vdmJtOUxIWGVkYWtVU2FMTk9GcG81cFNBb3I0?=
 =?utf-8?B?ZFFBc3J2L0hIRHVycnUyL3Y3NnRmSjQ1SnU2eHNQOVR0WFhrSFp2d3RsTXBT?=
 =?utf-8?B?bkFNSWhsc2llSGI4eERlVFpiTDBTelFubGJmUzN0eHE0VzRkdWpHU1lyVmxq?=
 =?utf-8?B?bDRUdWkvcCs5R2E1cDBFdytiYlplWTk5OXVkcVFaNG9jcjZ1WUNzSklqdFhl?=
 =?utf-8?B?RGxjT3NOYXAxeUlWSFIxWHMyVk05a2dydCs3OThlTHArd0hrRVRSUVRlNjhu?=
 =?utf-8?B?SlFCMTdsbHl2NExXSVpiNzJLMzhtQ1JCVGorL09YT3RWNExvbGlYdHQ1cml0?=
 =?utf-8?B?cnNacHRFZE1YNE5aZDUyaWsvMXlLQ3JEdlJqbGRISUtXQWxiNGtvKzVMZy9u?=
 =?utf-8?B?Q2d6cnhRaXRRQWJEMjRZNnpKL3dMNUszZTR3S2EzYmgwQmFWS3c3TFJRM3FO?=
 =?utf-8?B?WUloUHVGUFhMR00wV24wYmY4NCs1UkFoTU5WMFc0cnNIY0N5Wk16bUZmeVha?=
 =?utf-8?B?Y2tyUzJXcEs3RjZ4MlNDZmkwYjJvblRlNUZwU1RXRWlBd0FDcWhuL0VYWHBJ?=
 =?utf-8?B?b0x1ZVpuZnRUWjN0K2lUMy9SSDhQb0JyRlo5dWV4Yzk4MXRXR3Z4Z0M0WjBr?=
 =?utf-8?B?RUhEckMvVVNwRDRZOGN4SHFDKzh5aTkyeUtlajBiblFFcGkxRTRmTTlnWW91?=
 =?utf-8?B?SUpZRXhvMFlTd3V5YnpTR2FkMW1wdDh2TnZYM1F3NEt1SiszZ0JXMnhJWWxG?=
 =?utf-8?B?Nm5mT1R0djc1YW1IcGh0bjhPdDVPMWhzUnZ2SDNJYS8wMXNTMWJGT09reDlR?=
 =?utf-8?B?eVNGNGdJWUtGclZpbjhQdTlpalcydEJLclRDSFZGVG1ybWhpMGVwUktQamkw?=
 =?utf-8?B?QmM4eXpldk1nNVJqbnptOU15VzBJQ3lYd0NYZGtjVkU4cUJmWXc4dzhpVFhs?=
 =?utf-8?B?WjFhRWx3MFBzdG55V1lwQmFUbnNDRTBEUkxDSk4rT2tsZEUzcGhJU0QvZjI5?=
 =?utf-8?B?Ymh6SGQvYWxzbUdLMU4yaU9nNWg0c3pGNVdUR1hvc244dVA0bTdYRFpWZjRa?=
 =?utf-8?B?eFEwb25YSUNRM3RyVDdma0JIdTlRZm1nZzI5YXEyZERlNDh1RCs5alR0M1Yw?=
 =?utf-8?B?THFxL1hHSlhGKzBVR3dMVi8ySVkvWnB6ODdBeTVHUnBoYzE2UzV5WkZuMFkx?=
 =?utf-8?B?MzRDeTUzQ1dYcXJ5M2RnWmtFVnRWamlVTnhUck1hb0JlVHIyTTkvMFMwU2ND?=
 =?utf-8?B?RDRFWUhjVFVhZS9XdlltNmZZZjBrbktmRVVXb0JRM2JIWkhDZW8xUzVReEl2?=
 =?utf-8?B?WWw5K3hjSUJIeTVDWXU2MU53MnVUd3NMeUJnVGdsdXVGNFZob1BsTHRYSHU1?=
 =?utf-8?B?ZDJUeVRPTllZbzdoQ25WK3Mrb0ZOU1BWT0pCV2VHc3JzUHdyOU1uNGJTcmRR?=
 =?utf-8?B?Rnd6L0xuRlhNc1J4bGNhZjQxMExhWml0NVk5VVNSTDhOblpGNDhsM1JUNGtR?=
 =?utf-8?B?Z09iOVd5Qy9LNHcwQ0REa1dUMDcveVowNVV0VkhkdnNmLzlwNWIvN2V1OGhL?=
 =?utf-8?B?ZGJXSndUMmtHVURVZVEzUFVsWW5VbEdEYVRFQ0VMZ2pweHgwOGJjbWtEbWJO?=
 =?utf-8?B?M3Y4TUxCL2ZxUjVmZXJRWCtycDQwcjBWVGhRREM0Uk1MR2tOSjV4RzZNT3NH?=
 =?utf-8?Q?ObBfUKCZv/Stn9V8UuZUtUkjl?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a5feb0a3-fbf6-4e27-bb7d-08db9c382cc3
X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB7790.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Aug 2023 20:02:08.9666
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PdlHG90WZMKv7+fsuxlJI/pAZbxRi5usfL7SnGXRSdNYa4IoKXJ3xIHEymnKwRA81oUczzEFZBvQ9e3G6CzC0g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9656
X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 12.08.23 г. 22:59 ч., Thomas Gleixner wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
> 
> reload_store() is way too complicated. Split the inner workings out and
> make the following enhancements:
> 
>   - Taint the kernel only when the microcode was actually updated. If. e.g.
>     the rendevouz fails, then nothing happened and there is no reason for
>     tainting.
> 
>   - Return useful error codes
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Reviewed-by: Nikolay Borisov <nik.borisov@suse.com>