Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 13 Aug 2023 20:04:29 +0100
From:   Daniel Golle <daniel@makrotopia.org>
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     Qingfang Deng <dqfext@gmail.com>,
        SkyLake Huang <SkyLake.Huang@mediatek.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org
Subject: Re: [PATCH net-next v2] net: phy: mediatek-ge-soc: support PHY LEDs
Message-ID: <ZNkpPRc9loNX2Wos@makrotopia.org>
References: <32e534441225c62e3bf9384b797d9beda7475053.1691943605.git.daniel@makrotopia.org>
 <8f20d427-91cc-4fbc-b263-dfc76df855f9@lunn.ch>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8f20d427-91cc-4fbc-b263-dfc76df855f9@lunn.ch>
Precedence: bulk

On Sun, Aug 13, 2023 at 08:57:01PM +0200, Andrew Lunn wrote:
> On Sun, Aug 13, 2023 at 05:24:55PM +0100, Daniel Golle wrote:
> > Implement netdev trigger and primitive bliking offloading as well as
> > simple set_brigthness function for both PHY LEDs of the in-SoC PHYs
> > found in MT7981 and MT7988.
> > 
> > For MT7988, read boottrap register and apply LED polarities accordingly
> 
> Should this be bootstrap? With an S? boottrap appears quite often in
> the code, so maybe the datasheet does say boottrap?

Yes, datasheet and vendor code refer to boottrap register which reflects
the state of the pins used for bootStrapping the SoC...

> 
>     Andrew