Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 13 Aug 2023 21:53:43 +0300
From:   Vladimir Oltean <olteanv@gmail.com>
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     Alfred Lee <l00g33k@gmail.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        sgarzare@redhat.com, AVKrasnov@sberdevices.ru
Subject: Re: [PATCH v2 net] net: dsa: mv88e6xxx: Wait for EEPROM done before
 HW reset
Message-ID: <20230813185343.rxkdcrvbpoap3gx4@skbuf>
References: <20230811232832.24321-1-l00g33k@gmail.com>
 <20230813105804.2r4zdr6dyqe5dsrf@skbuf>
 <dc56700c-8617-44de-8285-720e1514ebc9@lunn.ch>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <dc56700c-8617-44de-8285-720e1514ebc9@lunn.ch>
Precedence: bulk

On Sun, Aug 13, 2023 at 05:09:14PM +0200, Andrew Lunn wrote:
> On Sun, Aug 13, 2023 at 01:58:04PM +0300, Vladimir Oltean wrote:
> > Hi Alfred,
> > 
> > On Fri, Aug 11, 2023 at 04:28:32PM -0700, Alfred Lee wrote:
> > > If the switch is reset during active EEPROM transactions, as in
> > > just after an SoC reset after power up, the I2C bus transaction
> > > may be cut short leaving the EEPROM internal I2C state machine
> > > in the wrong state.  When the switch is reset again, the bad
> > > state machine state may result in data being read from the wrong
> > > memory location causing the switch to enter unexpect mode
> > > rendering it inoperational.
> > > 
> > > Fixes: 8abbffd27ced ("net: dsa: mv88e6xxx: Wait for EEPROM done after HW reset")
> > > Signed-off-by: Alfred Lee <l00g33k@gmail.com>
> > > ---
> > 
> > I don't think you understand the meaning of the Fixes: tag.
> 
> The subject looks correct, but the hash is wrong. The correct hash is
> a3dcb3e7e70c72a68a79b30fc3a3adad5612731c.
> 
> Fixes: a3dcb3e7e70c ("net: dsa: mv88e6xxx: Wait for EEPROM done after HW reset")
> 
>        Andrew

Ok. I didn't notice the "before" vs "after". But the patch still needs
to be resubmitted with the right Fixes: tag.