Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 13 Aug 2023 23:58:55 +0200
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Tao Lan <taolan@huawei.com>
Cc:     mturquette@baylibre.com, sboyd@kernel.org, j.neuschaefer@gmx.net,
        linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: fix memory leak in hisi_clk_init.
Message-ID: <ZNlSH+eWV8Sk3FYn@probook>
References: <20221222091221.28308-1-taolan@huawei.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="a6iDqMC9Rx98SozQ"
Content-Disposition: inline
In-Reply-To: <20221222091221.28308-1-taolan@huawei.com>
UI-OutboundReport: notjunk:1;M01:P0:m72hZOWJZfo=;75TnQhajGaIKcxvkM/83FTS2SKE
 DJupgVeAaRnsEY7sxEvtPVl98PzLtejdMJkY1EweVd6ITB0ViGwhXbpjD3YFTxr7DBjJdlMom
 9jdj4sUFl3loIUbZObNclniDb0ReOdGGxl8wr6U74Vjo6O8ybvLG8acJrt/vuJc+/m2qWIJF5
 y4+cE7oHDkasxZf75YO6ottNKuXQodzEUokbX4PQfRBXsOBsRH6AR9CGNyU5TeHa8Ixf1+xVp
 u3NWwVUVE4OlnoQ3Si/ULgm0Vrourb1oAYLHwtnbO+6q/Js+mEg5na32K28/LzPW48sIdRmBP
 gync/57WsYl5pBEdILZ/XWDudhXntcL5Pg5H3CmaBeduGITPwiRpPf6d1mX2V+lDsjSzdRks/
 WUIJtrCYQ6YFbGCZAqtC3RIbsPm0rSJJnGbF/juTD8drZG5bYXEVGFS2nkWb8xZW6AueBHOB2
 B+tWadBaEEwKpHRf+XdGGr9deqwJa2lZrGAxr3MU673Df2aCB6qWXTXytsXuvvvggwMMv5h4Q
 5iaGw35cp7ojBJJKZ884YxvaMJtriTmYPGa477apHLtynoPaHaq3lAHLDElXuxkmS19GUr30Q
 BVXLF4M3RIr3/zkmcRX3ntZvkPutvc/2uWg9CGxVL9RwwvvPT/9u7Axziim4FanGakSuyi+eS
 dWFeyNxJRr/YWuGkPw89NmNTom8vGkGlR0q93l8Tbu1Wa38LKwobUf7BD612+t5zVLOGl9njO
 fjXOKLnhXBg90wYLBLk8TBV/v+TZ6V4nz4UzAFU6rNVO8GvTgum+aQCfsY6IjJPhtFYmycfaj
 gXm1z42SQpBV/pc2PyBJh6EBT5jE60qnYLeG9sQQ8qdEJwc4Fc5hcjG0O7MgGl/KuAvrYFhcP
 F1Os3DbJSxiUUq+3MtY8/kJ5qIO80OV/DtmF/xiOVNPsQFzMHo4Wewprvn73+KeEwoThU7UDy
 x+I5CO0gMNgeG5ff1yZEaELEekM=
Precedence: bulk


--a6iDqMC9Rx98SozQ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

sorry for the delay, but I found this unmerged patch while cleaning up
my mailbox.

On Thu, Dec 22, 2022 at 09:12:21AM +0000, Tao Lan wrote:
> From: taolan <taolan@huawei.com>
>=20
> when clk_data create fail, we also need to release base.
>=20
> Signed-off-by: taolan <taolan@huawei.com>
> ---
>  drivers/clk/hisilicon/clk.c | 4 ++++
>  1 file changed, 4 insertions(+)
>=20
> diff --git a/drivers/clk/hisilicon/clk.c b/drivers/clk/hisilicon/clk.c
> index 54d9fdc93599..9ca4fc05fa57 100644
> --- a/drivers/clk/hisilicon/clk.c
> +++ b/drivers/clk/hisilicon/clk.c
> @@ -82,6 +82,10 @@ struct hisi_clock_data *hisi_clk_init(struct device_no=
de *np,
>  	of_clk_add_provider(np, of_clk_src_onecell_get, &clk_data->clk_data);
>  	return clk_data;
>  err_data:
> +	if (base) {
> +		iounmap(base);
> +		base =3D NULL;
> +	}

This is inaccurate. Consider the case when kzalloc fails:

	clk_data =3D kzalloc(sizeof(*clk_data), GFP_KERNEL);
	if (!clk_data)
		goto err;

base has already been mapped, but the code jumps to 'err', which doesn't
have the iounmap.

To address this properly, you'd have to add another label between
err_data and err.


>  	kfree(clk_data);
>  err:
>  	return NULL;


Best regards,
jn

--a6iDqMC9Rx98SozQ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAmTZUfwACgkQCDBEmo7z
X9v5KBAArTSZfCeWFE+wvW+7H3bcqhQzz1HuFXIcWRP/7l4QxZfSrTseScsxx1tt
65fD9mDm9etWw8lnuwHXpwx4KVkZf09eWh+H6LEGcm1x4BfcozFmeBiVySUJ81cO
/UddTJBlXKYLI8wbIiVfIwDzLCGurJkSHNDJBrkgk/U/eV78AethhfP20qkGNChH
Z1TF/4Xc64gcBC1SKHrCALNlB+ICTtQCwehR2DFbmjBtY3FREda3g5Z+xfjENVnN
0dweiJ8ksBEfmAWFevogpDdcJkA+5XqUu9klH7svnm4k45LFJj6KVNQIotxGQJs5
OhfFJ708uzuzNaRlb/GL8dUBQkH/zhS+9+lNn+jKcKgY6yKl9YrtZeOUG2u9ZMjJ
8hPN/2FgpAkaY5pqCyOgDvcxOHyYmM2Vdyg0n79C7HRWqpRCPKezcemsQRMyqq+4
Nlt12FqDMe4z8VDXGqE8gK8UhTZsGBrx+6niH/TYcWZrWZ4CG3Frz6SSOP/NF62r
8h6quL5SbROq+fHpB2sXKj5k9HilQOhJSHvY+X9NB2F62PImXvMX7GGZKnRcAZXw
1CB7aAMPUeqvNozcfO4iLABGpbIuumKTO/pgZ6B00QYExDcxTkDgao0bVZnjUber
KgnGBrmdUv5gb3gYkchGVOST2dHygO1b3DxywiD+bYulbgJMP+4=
=h3d+
-----END PGP SIGNATURE-----

--a6iDqMC9Rx98SozQ--