Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Aug 2023 12:14:58 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     "Limonciello, Mario" <Mario.Limonciello@amd.com>
Cc:     "Yuan, Perry" <Perry.Yuan@amd.com>,
        "Karny, Wyes" <Wyes.Karny@amd.com>,
        "trenn@suse.com" <trenn@suse.com>,
        "shuah@kernel.org" <shuah@kernel.org>,
        "rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "chenhq2005@gmail.com" <chenhq2005@gmail.com>
Subject: Re: [PATCH] cpupower: Fix querying boost support for amd-pstate-epp
 mode
Message-ID: <ZNmqQkOK7CLa7TNl@amd.com>
References: <20230811213501.17293-1-mario.limonciello@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230811213501.17293-1-mario.limonciello@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vWVtZLCVHVUXxMIhWOu+ePyxXDqxzDcItx7RB5XuF2JDG5jjFGJrAgBGxJh6?=
 =?us-ascii?Q?XBg05ZSkaB6DR3x03dXailnIszgT0aCQVTOPwqr2YnCrgEgSnBKaDfQvee2t?=
 =?us-ascii?Q?Pa3DBLqWypqYzN+UYIaxavXQvKL+2GeFFegIZhlqwEpqIGVX8kKT1/HIuByy?=
 =?us-ascii?Q?oWLJvortCd5LnVi5kIPSoRxIKhUqXc1Md12R7PRA+olNN+8AIcPmyU5qNeS9?=
 =?us-ascii?Q?7FdmmpMd/ixjWuj/YTznBe91/8Ge/nAipJ3bHInD6yEYZLKegQRJVJo0nQL1?=
 =?us-ascii?Q?lgoVig8AO2Slp1jMTZuD45kTINxpUSvnj/V7opq1Hn6y01Zvm/1lVUrf0xeH?=
 =?us-ascii?Q?y/Jax8toUgi23gJf0DdjgZ5ELoV+F2f4NP6/sq4K7+GcgZz4vvcoTudmkLIp?=
 =?us-ascii?Q?fHpxtPvvKYZ3Bfl2C5M4UCbEIj4u8SJrU9mBouZtASjxZA8v3hYV10Tb49iy?=
 =?us-ascii?Q?+tNtJuXBNJ0NqL0zhY+QoAzUOBsfUDjpQ4GUE8/R704pAeA770l/S97wpO6t?=
 =?us-ascii?Q?fLWG+5cGzD8EG6lAP+ps2ASxHKEq5y0UE7fLLkAsVPpNpHxpGHAkIJb1+gXr?=
 =?us-ascii?Q?y/+AaEYL/K7wkoLPw9mqmbURu3BgIDsMl69IuYHlvpRv3rMDvFvy7Yav0nkc?=
 =?us-ascii?Q?hnIVPUga4Q8AARNFaZhXytKhw4CVUpjeVGD6LZFoDbotqDrpktksBTYlSOs/?=
 =?us-ascii?Q?tBS9h7WZEO3mPZdHVq098K1z4pdow7O95nUKqh7Mxw0J4pwBDLkhv13CrMqt?=
 =?us-ascii?Q?lln/c3WXKJgdHLwwWk7+53yylw7ySG7ftrZPWa5FnAedsPyDR706w2kTUcbl?=
 =?us-ascii?Q?tqcvwTTLMhaL2YL/CrdGi854Af4Y5W2A1HBNv1rxW6mmYRN3BqapMzVt52Xs?=
 =?us-ascii?Q?AKI7KmxJkWxD9tD6C0J4x4ACirvqKweVihoPmnwbyyemrK3r6AEfaOVX4/DQ?=
 =?us-ascii?Q?b+jgcSB7t5YwuK8FP+FC2WldkvFMnGO5Z0r+H+MsmpRFs5/VDnGbxn4OFpg7?=
 =?us-ascii?Q?LktllSDQUGrhTbnDBcxNbeMKxuAVeBhMzttDTmDaTMufGTamSFpm9MBL0v5r?=
 =?us-ascii?Q?neSHNhXJXlddFqVTYQ+1Avj0HrYG/CiGnlGL8xNWtK1CyZMnG2yDWyki6QsW?=
 =?us-ascii?Q?AVPvGovSJLfrbPPCiym6ozxCDj+FZiFAjbh2xWUlANDrAUx5Mb62dbygowfs?=
 =?us-ascii?Q?/G5XYQE/r1bRTV1X95Bv9/ajGV5upQidsuo/IoLZe1qBnQBg+/z1yMx7dBou?=
 =?us-ascii?Q?KnguIhjZM4jYxnTL+bJF9O1WUEgPuBmocJ3mzdMDYnubjEILJ1uH2ZqiCGH3?=
 =?us-ascii?Q?6S27GPbfo14ccqu2sYsFc2dqb/1/fjXMyeUzjpaV2gmdEXGughhZTyZ362IY?=
 =?us-ascii?Q?rFttZU3OFAIp0AzdFWRZH0y06G5J6jjjQj7oUGEXPb2A0SfNN5S0IkxGaxXF?=
 =?us-ascii?Q?f06uCqHJR7BbpC9Vqg/Ex7I6lEfA0L8/88jAsqVdrNt3wWF/Ee0PWVvc7LHd?=
 =?us-ascii?Q?WRrib4XYQMJWs/gYm5DMScSzDQFPJ1p96sXAApw3RiJMHqQyScyEo0bmENFN?=
 =?us-ascii?Q?66vOx+hBAczzgbO9pJpyDkCQe2wKqTY3TISLwNai?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 15b2d072-3998-4717-6320-08db9c7d1277
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8690.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2023 04:15:19.9275
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QinoRe75Z5UMblUPxbDBOrWZufJ/OqjYhHXO+J3Su3mZiyUDjKox3jV5EohtWMhndYaghnbMK2f8l/MOBcV//g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8737
X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Aug 12, 2023 at 05:35:01AM +0800, Limonciello, Mario wrote:
> When running in active mode the driver for amd-pstate has -epp appended.
> This throws off amd-pstate detection.
> 
> To detect amd-pstate look for the prefix instead.
> 
> Fixes: ffa5096a7c33 ("cpufreq: amd-pstate: implement Pstate EPP support for the AMD processors")
> Reported-by: chenhq2005@gmail.com
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217755
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>

Acked-by: Huang Rui <ray.huang@amd.com>

> ---
>  tools/power/cpupower/utils/helpers/misc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/power/cpupower/utils/helpers/misc.c b/tools/power/cpupower/utils/helpers/misc.c
> index 9547b29254a7f..01c0440efe850 100644
> --- a/tools/power/cpupower/utils/helpers/misc.c
> +++ b/tools/power/cpupower/utils/helpers/misc.c
> @@ -95,7 +95,7 @@ bool cpupower_amd_pstate_enabled(void)
>  	if (!driver)
>  		return ret;
>  
> -	if (!strcmp(driver, "amd-pstate"))
> +	if (!strncmp(driver, "amd-pstate", 10))
>  		ret = true;
>  
>  	cpufreq_put_driver(driver);
> -- 
> 2.34.1
>