Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Aug 2023 07:57:51 +0100
From:   Conor Dooley <conor.dooley@microchip.com>
To:     Xingyu Wu <xingyu.wu@starfivetech.com>
CC:     Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Emil Renner Berthing <emil.renner.berthing@canonical.com>,
        Conor Dooley <conor@kernel.org>,
        Hal Feng <hal.feng@starfivetech.com>,
        <linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>
Subject: Re: [PATCH v1] clk: starfive: jh7110-sys: Set PLL0 rate to 1.5GHz
Message-ID: <20230814-relieving-brisket-9a8c38e817a4@wendy>
References: <20230811033631.160912-1-xingyu.wu@starfivetech.com>
 <20230811-jiffy-nebula-a8ea5ef15eee@wendy>
 <cace0094-948b-a4e9-ab63-6fdfb9952b44@starfivetech.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="RojBI9Zo7R/mgEe2"
Content-Disposition: inline
In-Reply-To: <cace0094-948b-a4e9-ab63-6fdfb9952b44@starfivetech.com>
Precedence: bulk

--RojBI9Zo7R/mgEe2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Aug 14, 2023 at 11:06:05AM +0800, Xingyu Wu wrote:
> On 2023/8/11 14:43, Conor Dooley wrote:
> > On Fri, Aug 11, 2023 at 11:36:31AM +0800, Xingyu Wu wrote:
> >> Set PLL0 rate to 1.5GHz.
> >=20
> > Why are you doing that though?
>=20
> Because the CPU frequency scaling is based on 1.5GHz rate on JH7110 SoC.
> And now the PLL clock driver has been accepted and PLL0 is just 1GHz[1].
> [1] https://github.com/starfive-tech/VisionFive2/issues/55
>=20
> We should set the PLL0 rate to a correct rate (1.5GHz) and then
> the CPUfreq will work normally.

Please include an explanation in the commit message of the problem this
is addressing.

Also, a Fixes: tag + reported-by?

> Best regards,
> Xingyu Wu
>=20
> >=20
> >=20
> >> Change the parent of cpu_root clock
> >> and the divider of cpu_core before setting.
> >>=20
> >> Signed-off-by: Xingyu Wu <xingyu.wu@starfivetech.com>
> >> ---
> >>=20
> >> Hi Stephen and Emil,
> >>=20
> >> This patch sets PLL0 rate to 1.5GHz. In order not to affect the cpu=20
> >> operation, the cpu_root's parent clock should be changed first.
> >> And the divider of the cpu_core clock should be set to 2 so they
> >> won't crash when setting 1.5GHz without voltage regulation.
> >>=20
> >> This patch is based on linux-next which has merge PLL driver on
> >> StarFive JH7110 SoC.
> >>=20
> >> Thanks,
> >> Xingyu Wu
>=20

--RojBI9Zo7R/mgEe2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZNnQXwAKCRB4tDGHoIJi
0qJMAP4kZmzrUwCXni8fgSgkuHudobkp5DySRNfylKsWb967qQD+NOCVhXJk98tx
PBr+FTU1J98r09xigNcFP3qzFziehgU=
=bcON
-----END PGP SIGNATURE-----

--RojBI9Zo7R/mgEe2--