Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e912d7a8-0a3b-913d-3583-b383b874077c@starfivetech.com>
Date:   Mon, 14 Aug 2023 15:28:14 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.14.0
Subject: Re: [PATCH v1] clk: starfive: jh7110-sys: Set PLL0 rate to 1.5GHz
Content-Language: en-US
To:     Conor Dooley <conor.dooley@microchip.com>
CC:     Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Emil Renner Berthing <emil.renner.berthing@canonical.com>,
        Conor Dooley <conor@kernel.org>,
        "Hal Feng" <hal.feng@starfivetech.com>,
        <linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>
References: <20230811033631.160912-1-xingyu.wu@starfivetech.com>
 <20230811-jiffy-nebula-a8ea5ef15eee@wendy>
 <cace0094-948b-a4e9-ab63-6fdfb9952b44@starfivetech.com>
 <20230814-relieving-brisket-9a8c38e817a4@wendy>
From:   Xingyu Wu <xingyu.wu@starfivetech.com>
In-Reply-To: <20230814-relieving-brisket-9a8c38e817a4@wendy>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023/8/14 14:57, Conor Dooley wrote:
> On Mon, Aug 14, 2023 at 11:06:05AM +0800, Xingyu Wu wrote:
>> On 2023/8/11 14:43, Conor Dooley wrote:
>> > On Fri, Aug 11, 2023 at 11:36:31AM +0800, Xingyu Wu wrote:
>> >> Set PLL0 rate to 1.5GHz.
>> > 
>> > Why are you doing that though?
>> 
>> Because the CPU frequency scaling is based on 1.5GHz rate on JH7110 SoC.
>> And now the PLL clock driver has been accepted and PLL0 is just 1GHz[1].
>> [1] https://github.com/starfive-tech/VisionFive2/issues/55
>> 
>> We should set the PLL0 rate to a correct rate (1.5GHz) and then
>> the CPUfreq will work normally.
> 
> Please include an explanation in the commit message of the problem this
> is addressing.
> 
> Also, a Fixes: tag + reported-by?
> 

OK, I will add the explanation in next version as a fixes patch.

Thanks,
Xingyu Wu

>> > 
>> > 
>> >> Change the parent of cpu_root clock
>> >> and the divider of cpu_core before setting.
>> >> 
>> >> Signed-off-by: Xingyu Wu <xingyu.wu@starfivetech.com>
>> >> ---
>> >> 
>> >> Hi Stephen and Emil,
>> >> 
>> >> This patch sets PLL0 rate to 1.5GHz. In order not to affect the cpu 
>> >> operation, the cpu_root's parent clock should be changed first.
>> >> And the divider of the cpu_core clock should be set to 2 so they
>> >> won't crash when setting 1.5GHz without voltage regulation.
>> >> 
>> >> This patch is based on linux-next which has merge PLL driver on
>> >> StarFive JH7110 SoC.
>> >> 
>> >> Thanks,
>> >> Xingyu Wu
>>