Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Aug 2023 09:39:34 +0200
From:   Marek =?UTF-8?B?QmVow7pu?= <kabel@kernel.org>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
        linux-gpio@vger.kernel.org,
        Linus Walleij <linus.walleij@linaro.org>,
        linux-kernel@vger.kernel.org
Subject: Re: regression from commit b0ce9ce408b6 ("gpiolib: Do not unexport
 GPIO on freeing")
Message-ID: <20230814093934.1793961e@dellmb>
In-Reply-To: <ZNYKjnPjIRWIYVot@smile.fi.intel.com>
References: <20230808102828.4a9eac09@dellmb>
        <ZNYKjnPjIRWIYVot@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, 11 Aug 2023 13:16:46 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> On Tue, Aug 08, 2023 at 10:28:28AM +0200, Marek Beh=C3=BAn wrote:
> > Hi,
> >=20
> > the commit b0ce9ce408b6 ("gpiolib: Do not unexport GPIO on freeing")
> >=20
> >   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/co=
mmit/?id=3Db0ce9ce408b6
> >=20
> > causes a regression on my mvebu arm board (haven't tested on other
> > systems), wherein if I export a GPIO to sysfs and then unexport it, it
> > does not disasppear from the /sys/class/gpio directory, and subsequent
> > writes to the export and unexport files for the gpio fail.
> >=20
> >   $ cd /sys/class/gpio
> >   $ ls
> >   export       gpiochip0    gpiochip32   gpiochip512  unexport
> >   $ echo 43 >export
> >   $ ls
> >   export       gpio43       gpiochip0    gpiochip32   gpiochip512
> >   unexport
> >   $ cat gpio43/value
> >   1
> >   $ echo 43 >unexport
> >   $ ls
> >   export       gpio43       gpiochip0    gpiochip32   gpiochip512
> >   unexport
> >   $ echo 43 >unexport
> >   ash: write error: Invalid argument
> >   $ echo 43 >export
> >   ash: write error: Operation not permitted =20
>=20
> Can you test the following change (I'll submit a formal patch if it works=
)?
>=20
> diff --git a/drivers/gpio/gpiolib-sysfs.c b/drivers/gpio/gpiolib-sysfs.c
> index 530dfd19d7b5..b10a9b5598b2 100644
> --- a/drivers/gpio/gpiolib-sysfs.c
> +++ b/drivers/gpio/gpiolib-sysfs.c
> @@ -515,8 +515,9 @@ static ssize_t unexport_store(const struct class *cla=
ss,
>  	 * they may be undone on its behalf too.
>  	 */
>  	if (test_and_clear_bit(FLAG_SYSFS, &desc->flags)) {
> +		gpiod_unexport(desc);
> +		gpiod_free(desc);
>  		status =3D 0;
> -		gpiod_free(desc);
>  	}
>  done:
>  	if (status)
>=20

tested, works.

Please add Fixes tag when sending the patch