Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Aug 2023 09:16:21 +0200
From:   Willy Tarreau <w@1wt.eu>
To:     Zhangjin Wu <falcon@tinylab.org>
Cc:     linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        tanyuan@tinylab.org, thomas@t-8ch.de
Subject: Re: [PATCH v2 5/7] selftests/nolibc: customize CROSS_COMPILE for all
 architectures
Message-ID: <20230814071621.GB14322@1wt.eu>
References: <20230813091625.GG8237@1wt.eu>
 <20230813101805.10885-1-falcon@tinylab.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230813101805.10885-1-falcon@tinylab.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Sun, Aug 13, 2023 at 06:18:05PM +0800, Zhangjin Wu wrote:
> > Given that we don't support mips64, I'd suggest to ust mips-linux-
> > instead here for now. That doesn't seem right to ask users to
> > download a toolchain for a different architecture than the one
> > supported just because we can adapt to it.
> >
> 
> Agree very much, and the one below from patch 7/7 [1]:
> 
>     +CROSS_COMPILE_arm64     ?= aarch64-linux- aarch64-linux-gnu-
>     +CROSS_COMPILE_arm       ?= arm-linux-gnueabi- arm-none-eabi-
>     +CROSS_COMPILE_mips      ?= mips64-linux- mips64el-linux-gnuabi64-
> 
> It should be:
> 
>     +CROSS_COMPILE_mips      ?= mips-linux- mips-linux-gnu-gcc
> 
> And if necessary, the mips64-linux- line in the commit message of [1] should be
> corrected too.

I just did that (and fixed mips-linux-gnu- instead of mips-linux-gnu-gcc
above).

Thanks,
Willy