Received: by 2002:a05:7412:6592:b0:d7:7d3a:4fe2 with SMTP id m18csp2409442rdg; Mon, 14 Aug 2023 01:13:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGQbDPtJQ1tGGSynFRpsSTj+qlLZiMLIzfxWT+HzRoICrS4/w0PAKHlJuxVtnxdJ0Jj/DO8 X-Received: by 2002:a05:6870:fb8f:b0:1bf:1346:63e with SMTP id kv15-20020a056870fb8f00b001bf1346063emr9075434oab.49.1692000815664; Mon, 14 Aug 2023 01:13:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692000815; cv=none; d=google.com; s=arc-20160816; b=x4wzPDPQH421ZD3GcewlFilO+ccx71+4oeQ5pMpXnXxjWhS2UcIz4cR1ABsk1dZG8Y W9IXfLtzdNrPRjWw5rWLsP4L5BRFpv17WbSKrhdz4ZHPjG8/ZyhisSHMSmKQ+tXlso3y lmTDw3QscoVWreaAUdFfqa0ckdNltTLs5OP3qbB4jK1gMFO7woTCk3bq3YIJ7pm1IzL8 1mf2c4vchA9YoekqYEIm6XlHBY930DwDkfntoPEljCfcwqvMXugL9s23REpTDvcbGyBl LvSN27/yOt5rJO2dH5uKAec5CNf84leAP3roz45FibqWUKk9DzRTjWV0pX4nWOTxS+IU jMUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=N4EWnn28IkPRNoL7Axe9FTyMJv0nAchBkTjn5AGtOYc=; fh=fMnZi4KuePuHxbZev+VeXCBNB9z31b5//W1Y8XgnUVE=; b=xwuc/ylk7/ZbvJ4OdlcCaTkSS9UgnXX+GDCf+23gqzIzv7Sn51HhzV9qlaJUvhegWB xjwYpEmDoc7zcbJkokfLyC/ElhG879lBNeizg4peBS2ukMSJeAXHnX9mmmXLvx4Q9aI0 ko6IcswMnB0Se3OV8+Peo3r0eN+9FQAw5OUOQzUrTgoCVZt/jt7NX4ikANax1ondjeSR E/ka1TqbpSWJsK0uNgAhYMjQfxujwm20pZ+t3w/s46ctqvZVH34W+ixS/BpoRF8Wxv0A Diat5nR685OIxhchBCP7PUoJtu+VEtBY2rb6lbZi0lgWYmSsmDM4rke2ax+53hz8iZrb WYtQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Q9n6wBSp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e9-20020a17090301c900b001b8b2cb7359si7715177plh.627.2023.08.14.01.13.23; Mon, 14 Aug 2023 01:13:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Q9n6wBSp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233894AbjHNHj7 (ORCPT + 99 others); Mon, 14 Aug 2023 03:39:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233586AbjHNHjf (ORCPT ); Mon, 14 Aug 2023 03:39:35 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4546D115; Mon, 14 Aug 2023 00:39:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D6B0A641EA; Mon, 14 Aug 2023 07:39:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68DA5C433C7; Mon, 14 Aug 2023 07:39:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691998774; bh=kjg4TBwaNAs7v3/kzjzI7ssu51NWiAz4yaBXH6sVnzA=; h=From:To:Cc:Subject:Date:From; b=Q9n6wBSpeCAmsniOpaTf36ptveR2UoXu9MK6Mg9csJErcjWWaZ0gtQktyJK1gNf/h WwY2PMo9Qq4DkFDKsASy57be6NJtijZma9cXeMQspZmRhdy3g5c0qZt25Zu8Q1ztaw 03Gve2RcnhifH0vYp3NucfkqXMk4gkYxqmWEJON5KmHtNjQRFnzpsZCdzwQXbSFPdy ny1PuHu0F+ywtghptl2tMgzy5pXmvjjebtmonM9B5mtdzHCVcC7vB99LDryG0tgq4F 4Hx3r9yZQDscCgcF6QwomrwgO5nB1NMYiuy5uk8l8KBRugKEioKRNeSzknjWE9wB9J xHoKHHTrBc+wA== From: Arnd Bergmann To: Wim Van Sebroeck , Guenter Roeck , Hans de Goede , Henning Schild Cc: "xingtong . wu" , Arnd Bergmann , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] watchdog: simatic: add PCI dependency Date: Mon, 14 Aug 2023 09:38:50 +0200 Message-Id: <20230814073924.1066390-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann The simatic-ipc driver no longer depends on PCI, but its watchdog portion still needs it, otherwise P2SB runs into a build failure: WARNING: unmet direct dependencies detected for P2SB Depends on [n]: PCI [=n] && X86 [=y] Selected by [m]: - SIEMENS_SIMATIC_IPC_WDT [=m] && WATCHDOG [=y] && SIEMENS_SIMATIC_IPC [=y] drivers/platform/x86/p2sb.c:121:3: error: call to undeclared function 'pci_bus_write_config_dword'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] pci_bus_write_config_dword(bus, devfn_p2sb, P2SBC, 0); Add back the minimum dependendency to make it build in random configurations again. Fixes: b72da71ce24b0 ("platform/x86: simatic-ipc: drop PCI runtime depends and header") Signed-off-by: Arnd Bergmann --- drivers/watchdog/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig index 04e9b40cf7d53..09452384221a4 100644 --- a/drivers/watchdog/Kconfig +++ b/drivers/watchdog/Kconfig @@ -1680,7 +1680,7 @@ config NIC7018_WDT config SIEMENS_SIMATIC_IPC_WDT tristate "Siemens Simatic IPC Watchdog" - depends on SIEMENS_SIMATIC_IPC + depends on SIEMENS_SIMATIC_IPC && PCI default y select WATCHDOG_CORE select P2SB -- 2.39.2