Received: by 2002:a05:7412:6592:b0:d7:7d3a:4fe2 with SMTP id m18csp2422817rdg; Mon, 14 Aug 2023 01:50:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF6qI7as+vDKsjMsWCk8DCyFojQqRCiPCQNt9SZMGTOO6TgkIBsoJoAZ6LXBcyi4M/z+1FX X-Received: by 2002:a05:6808:7db:b0:3a7:4fa4:edfe with SMTP id f27-20020a05680807db00b003a74fa4edfemr8651244oij.54.1692003024255; Mon, 14 Aug 2023 01:50:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692003024; cv=none; d=google.com; s=arc-20160816; b=Ao/Sl2VK7cq6JQITytSxcmgF5vU+bOjQxNImINW+jMcU/kaiqvSQfrWDZsaLZvmfJV tSNJcc7tx/p7Jxf7qwMBWZlE3Y2yAzUXMobs1gRgVxBbp0cP31FFiUl24z+268a6sAsJ HxWbBYrJXS5lYZs/lttfF9qtLz0P3JmgYScvTaAAhYf2ppyXt/UktAd52eA9U4/ciwdF zd8HoD6FpswvXjPdFbVjrZ7g3EG/RqI3AeTiEfyr4JwlpTdQJrhOlmqoHuXWNEqew4gs 3BoSFZxMDPbfaA6DQzp/5wAA47Ah8ly8I9AO4WHGmWw79qsr85gtLmsnhHx7XiLlCZcP bzjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=tApBKYNIV0fg/mn8WIMBLmG45QZJDj/ZB0MaRe6NkIM=; fh=pYyUFAa9w/tQxt6MedLYEJCY0DWS5bUx7Jq5SD+hVeA=; b=o9d5kwrSBdJQOU22ZaXOIITOPy6nPkOZa3elJGMDOrsj2jdE2r4R6CIKbbgYLiHyIM XQVGjcGNikRWfBT2QP/0aF4ier9v63CJH7+d5c4lqknsNYTmDlRT8XHSYxe2sMVNZNlL Eu/GE0vNPrOCaIBB/5SvjgXz+Gl4Bp6iKnmjSDUn7J1bcWQtISjfEq92W5p2L/1Ozpdr 1aFvJRhSMlr/9930ipnax2JtG03XnhKkih+qjtEkOtxH9nV/p/YoShgojC5AtyfyQqoX mQ4i2s/xpFbTu6cUMaGAY2X+ASWZOTS001Uwki4MXYDKz7i0vQrsmd92KFnUo0GvFlOL hT/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gjvQAg8R; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x186-20020a6386c3000000b00563d4e61773si8003527pgd.812.2023.08.14.01.50.12; Mon, 14 Aug 2023 01:50:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gjvQAg8R; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232930AbjHNIJn (ORCPT + 99 others); Mon, 14 Aug 2023 04:09:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231691AbjHNIJH (ORCPT ); Mon, 14 Aug 2023 04:09:07 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB10F109 for ; Mon, 14 Aug 2023 01:08:48 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-99c0290f0a8so495376566b.1 for ; Mon, 14 Aug 2023 01:08:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692000522; x=1692605322; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tApBKYNIV0fg/mn8WIMBLmG45QZJDj/ZB0MaRe6NkIM=; b=gjvQAg8RXhIqO/8zdU98meKnSUF+/6BodRTaCJQSIddTV5mwhT9N7OA+i7/ThuFjXk pXu5ORfFW9UhwmiGOYXLzo6T9vo1to7fScRIQ3M/dFp991hJHy+56imCpLzGIEzUtV1q 7a/I0V6oR5eZxbp76sPtGJiHkTNQWErHv96dbQ0+ACXBKYnx/EwkeHYzte0GF8eXeDOH 5JEuMGvVgdocNNAgHfcPv3YXZ1J4jkxPPa0KAfWwHwK0Vj9Cw7C5/WW8Y75ifQ6BgwBV QEeChOekv3LYxr5adUIzJmCNRmDSOrA9XJRKGMRayCNX62A2lywF6xtnrd9houp/kl+o LadA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692000522; x=1692605322; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tApBKYNIV0fg/mn8WIMBLmG45QZJDj/ZB0MaRe6NkIM=; b=EHfBV5bRfl+vNzFRJ+dY7QNuVcy5Fz1ycIeCpllMdVeUwl+q0BMnE5WXGvjQ6mgGWJ tldaGdMt3DjC/BnLB+n1qU8LagWZukYwq6cP7Qmv8uWOt5UAPtpKLQEf7klqR5xYBzf1 LC4SbUIwh2114iyETeB/4CGvoiOw50AF+KCk3geFcS9xlpLuv8sVOtYt5R99xi0Qp0R+ mHQeziG1PjW0jCOw2bSB9yLLNvohzA5DT+C5REn9b43HujHRRRbbpTUXiXTh3vzjpWua G8oO8H9WuK1gViYfbFQ6UFDjV2Jzk6MOjs2cABaFGne9CBIskQCE37SIdbs7CelQd8nh ZhsQ== X-Gm-Message-State: AOJu0Yypa4pBPLmsE9Y4etMnFdKHO+Qij+UJBGdrJIGWTJ3WbJNfQB0J aD8/MHIlMYclU9JKRod+27CvYw== X-Received: by 2002:a17:906:8a59:b0:99b:ddac:d9d9 with SMTP id gx25-20020a1709068a5900b0099bddacd9d9mr7238687ejc.53.1692000521538; Mon, 14 Aug 2023 01:08:41 -0700 (PDT) Received: from [192.168.1.20] ([178.197.214.188]) by smtp.gmail.com with ESMTPSA id ha21-20020a170906a89500b009920e9a3a73sm5403737ejb.115.2023.08.14.01.08.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Aug 2023 01:08:41 -0700 (PDT) Message-ID: <830e5e34-f6de-3233-4a12-06c8390169d1@linaro.org> Date: Mon, 14 Aug 2023 10:08:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v2 1/2] dt-bindings: nvmem: SID: Add binding for H616 SID controller Content-Language: en-US To: Martin Botka , Srinivas Kandagatla , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Maxime Ripard Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Andre Przywara , Alan Ma , Marijn Suijten , AngeloGioacchino Del Regno , Konrad Dybcio References: <20230814-sid-h616-v2-0-0267749b4471@somainline.org> <20230814-sid-h616-v2-1-0267749b4471@somainline.org> From: Krzysztof Kozlowski In-Reply-To: <20230814-sid-h616-v2-1-0267749b4471@somainline.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/08/2023 08:38, Martin Botka wrote: > Add binding for the SID controller found in H616 SoC > > Signed-off-by: Martin Botka > --- > Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml > index 296001e7f498..2ec0a1b8f803 100644 > --- a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml > +++ b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml > @@ -27,6 +27,7 @@ properties: > - const: allwinner,sun50i-a64-sid > - const: allwinner,sun50i-h5-sid > - const: allwinner,sun50i-h6-sid > + - const: allwinner,sun50i-h616-sid It does not look like you tested the DTS against bindings. Please run `make dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ for instructions). Best regards, Krzysztof