Received: by 2002:a05:7412:6592:b0:d7:7d3a:4fe2 with SMTP id m18csp2422931rdg; Mon, 14 Aug 2023 01:50:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG+DHLJ4irxlS3Je9l1vr6+3AfX/ocVuvLftaP9QR8Lw7mwV3wuUY7y4d8IloJB1uEGh+yQ X-Received: by 2002:a05:6a21:3b46:b0:140:3554:3f44 with SMTP id zy6-20020a056a213b4600b0014035543f44mr9655591pzb.22.1692003041677; Mon, 14 Aug 2023 01:50:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692003041; cv=none; d=google.com; s=arc-20160816; b=Q0i4BHfyJ83Qj380Vi/tuJrqq+cEd/80oRfXyPhfWhSlgMXy2yioy7BW88F+Yfnt9G kaehp0VLRC/+9590CDgJvBPV+bju1PXdBtIgl2EKiFVoKw7jfsPT4Chv66RsbZ66THjl 0Qui6MWuCwsBOCmYlBUfkrnQKBMbBuuSQYlHtIp01MZ6q28/nA7yVpWFCwxkejajjDkl EYzq+LQ38VBthewSLZiVqzH1FL5iFVdTg/reRA/vImJjl/VY9DIHah9iVoRK62xyiacw MCyzz3hPCm/g4YXZYM8cpJHkXoEpB7Sp0qE5PZBhl8EIxWnWRfqW3YMJnniMGEbahS9r NxUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :cc:to:subject:from:date; bh=N/nmIxAiaLEDKfe+I2qsPwfm9Ypq7jnGjgZbIcUf+kY=; fh=TnSER6/Iv9g/bIJjRckHcAIEtHXxyuZnLi2Mwj7//SU=; b=BiMxOcFFBw4WKdxMGsw81ZQaTHMw0yyeEaxN8FqK94MBaAXrR+PHu1EhYYNWWEqtXy p7LrXrSf2aGbFJJntK9y3B/Tur/KTfYQB8D9AgDRwVvqQfq2HSF9WGSh1MxzLyQkBK0Q klRiRgHrXEZPgPw0Kh0TSreIY6xvm149aAYqoyRi5Fh5K4UOoiIM3WyKc6Fdhs+voxz+ 0AJroMH4AZq3rN+zZLdG2J1GNwIoVcJRuST7BR1FtyJ/C3Bs7P4pSkwEHXw/Zdah6Jlh cUIauiPpf3c9HwH146aLl8DWpJWYD0ExwAlOu70+/noXhU7sbIWNBe7wxaWQ8+6T7/g6 RMBg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s9-20020a637709000000b0055c4c9cc010si8143163pgc.481.2023.08.14.01.50.29; Mon, 14 Aug 2023 01:50:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234572AbjHNIXF (ORCPT + 99 others); Mon, 14 Aug 2023 04:23:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233567AbjHNIWa (ORCPT ); Mon, 14 Aug 2023 04:22:30 -0400 Received: from relay01.th.seeweb.it (relay01.th.seeweb.it [IPv6:2001:4b7a:2000:18::162]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BCD1273A for ; Mon, 14 Aug 2023 01:21:58 -0700 (PDT) Received: from [192.168.2.144] (bband-dyn221.178-41-211.t-com.sk [178.41.211.221]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id B9E2A1F4A4; Mon, 14 Aug 2023 10:21:55 +0200 (CEST) Date: Mon, 14 Aug 2023 10:21:49 +0200 From: Martin Botka Subject: Re: [PATCH v2 1/2] dt-bindings: nvmem: SID: Add binding for H616 SID controller To: Krzysztof Kozlowski Cc: Srinivas Kandagatla , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Maxime Ripard , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Andre Przywara , Alan Ma , Marijn Suijten , AngeloGioacchino Del Regno , Konrad Dybcio Message-Id: In-Reply-To: <830e5e34-f6de-3233-4a12-06c8390169d1@linaro.org> References: <20230814-sid-h616-v2-0-0267749b4471@somainline.org> <20230814-sid-h616-v2-1-0267749b4471@somainline.org> <830e5e34-f6de-3233-4a12-06c8390169d1@linaro.org> X-Mailer: geary/43.0 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 14 2023 at 10:08:38 AM +02:00:00, Krzysztof Kozlowski wrote: > On 14/08/2023 08:38, Martin Botka wrote: >> Add binding for the SID controller found in H616 SoC >> >> Signed-off-by: Martin Botka >> --- >> >> Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml >> | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git >> a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml >> b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml >> index 296001e7f498..2ec0a1b8f803 100644 >> --- >> a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml >> +++ >> b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml >> @@ -27,6 +27,7 @@ properties: >> - const: allwinner,sun50i-a64-sid >> - const: allwinner,sun50i-h5-sid >> - const: allwinner,sun50i-h6-sid >> + - const: allwinner,sun50i-h616-sid > > It does not look like you tested the DTS against bindings. Please run > `make dtbs_check` (see > Documentation/devicetree/bindings/writing-schema.rst or > https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ > for instructions). > > Best regards, > Krzysztof > Yea completely forgot. Sorry for that. Will send v3 tomorrow with proper binding patch using items with enums