Received: by 2002:a05:7412:6592:b0:d7:7d3a:4fe2 with SMTP id m18csp2439965rdg; Mon, 14 Aug 2023 02:32:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHJWi1b3AYRkWnKlP/CQT989foAs9/ehW5tvkhFRB4ZxHLl936yOTEbmHEwv4/r3IL9Grj+ X-Received: by 2002:a17:903:1cb:b0:1bc:4f04:17f4 with SMTP id e11-20020a17090301cb00b001bc4f0417f4mr15498923plh.30.1692005551470; Mon, 14 Aug 2023 02:32:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692005551; cv=none; d=google.com; s=arc-20160816; b=CHGvSQK4NQo+H49mgiCJsVgiBJs5s7pAcfbDIe8Iz9EDWNcE71m6vq8jfTI1o4E5Rc eoh8VnNn491+0ccgCUJIPxqZfzrhX/VONX2XItU1X57fGzsUqhPqJ+Owz7sb3GdJmF2r ysAyOPdbqGhhaoG2QAwiIymUhBOuAuRKyK/L4s62FGSigObA5H81quwo/ofP8aRdrQSE sBy4/pf3H3aLgLpp4Ktnnw2NMi3So0rqzov6Oq6P+X7bN8d5GzqStneZZlqizPV0Xvcm Iia6KMssUbJyNyyzHTtWEIuOrFiwowS576UO2YTlvgS6yv4VBfNsCULWY5Ml6CdoYR9N HTvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date:dkim-signature; bh=H2w5g0BlWb263nI7GlwRivwCDOcI1uQmwydH9RknkXE=; fh=76krDUtoAno3wE/NL1i4OUozQWkbBf0InXDjjOoZDxM=; b=KNJChEMfLC3gnlMr1ER1jVMZw+jGW7OTOtNqnGdk9pl5Xrl1U1B35pwG4KMFKMufpj cB+0pKAjdhMfot4aou47HJBdcPFd5ihKCkE5TD+V+ekHs5m4N191McidtNgz3Wjcgke0 j/uHWt3FI/tmB+kZIrTepooRpVG+YniwRjeOUcIM5dMqqZu9Av/SnLL9Z6jn47l7F7V5 AONXonrEu0U7B8rr5sncP6285ful6Lag5JaZfz+c+sUkX8udXpMA+KBkxu7e5e2mHOs4 3N1dv5IbA1sailrkgP8fyomwuXRqj3mReXatIWYKmS4k7T2MfwgeVnmRhnBjEBommu1k B0hA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="dP4OkEt/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q139-20020a632a91000000b0054fdf58c23esi5824250pgq.680.2023.08.14.02.32.20; Mon, 14 Aug 2023 02:32:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="dP4OkEt/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231334AbjHNJWO (ORCPT + 99 others); Mon, 14 Aug 2023 05:22:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230394AbjHNJVu (ORCPT ); Mon, 14 Aug 2023 05:21:50 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DFD2D7; Mon, 14 Aug 2023 02:21:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EF62D63080; Mon, 14 Aug 2023 09:21:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 245F5C433C7; Mon, 14 Aug 2023 09:21:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692004909; bh=PgX2A+ccGYe4/wQfUKl5YuSHuvpxj/bPRazdogtCW4w=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=dP4OkEt/Pvu133FDZEXWTd9Di5XCd9n4DOo3B3p8ryE4jk+wPNkPEBDaYtrhkM0iW r9n4AposCWCC58b6w9t0+UOb2vxkc4X/NPT1FVBpRItCcjOWPf5FxRIGIltEvRC5T+ CNbAnS98rbFGCoE7pm0l3IeItbdo5BzMrb6UqjURE7PJ5QwMM8OcAOGBx08SM9h0VX KhRe1NJvJVv4qftWWCvaeMmHhbwrDoeB+x53KnDl9jqOUeukBvJPMB0fjKUycCW+Ev DFi66D1Z4xjo3xI48116+/T+4+Z3f3rMxABsT9dqOcSgEFnHdJtHdrE108I6t0/n4J SFztE5nkjCHtQ== Date: Mon, 14 Aug 2023 11:21:45 +0200 (CEST) From: Jiri Kosina To: Christophe JAILLET cc: Benjamin Tissoires , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [PATCH] HID: Reorder fields in 'struct hid_input' In-Reply-To: <9accb4ebd1247e2f2acc77dd053f67e60bf8d283.1687079502.git.christophe.jaillet@wanadoo.fr> Message-ID: References: <9accb4ebd1247e2f2acc77dd053f67e60bf8d283.1687079502.git.christophe.jaillet@wanadoo.fr> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 18 Jun 2023, Christophe JAILLET wrote: > Group some variables based on their sizes to reduce hole and avoid padding. > On x86_64, this shrinks the size of 'struct hid_input' > from 72 to 64 bytes. > > It saves a few bytes of memory and is more cache-line friendly. Applied, thanks. -- Jiri Kosina SUSE Labs