Received: by 2002:a05:7412:6592:b0:d7:7d3a:4fe2 with SMTP id m18csp2441430rdg; Mon, 14 Aug 2023 02:36:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFqacAr7QcdAb34lbu7nMwtKpvfsFhsHyfFs02/xggmGwQP0sULRgJyI06Zh7vrqeJCWSn+ X-Received: by 2002:a05:6358:6f09:b0:135:24ed:5108 with SMTP id r9-20020a0563586f0900b0013524ed5108mr5979872rwn.10.1692005788463; Mon, 14 Aug 2023 02:36:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692005788; cv=none; d=google.com; s=arc-20160816; b=fRpIkucqnZHmy7fbGPi6wEnzQeE/9Zn0Uh3PFmWJlaSpn03rM5mrUKovGPsL22ERSl HXVD9UJIvNdfEGXG1FfQuoZ283Dl4fccAk8ZbL3HqNs4fFJqGWbZ1ZWd41amFQpfmMqU K4BptivedBGKqVfkeSQpZyttPCwmARtlLiPQbAydGowintZYxEqsdZN2c/tag3B6Pw32 su5K5470659wtgSDDHS3e0hKWXoh5BMYMqMRQy88Ldwe0kPy2+PidA/P8yj7E31ZE0hQ B+TBhn7ELYUNO3F4HvUUzdOSIW7EzI/mUUdqzL8pSBjfng6XW9ChynFkWEJxdesaN2hC lO+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date:dkim-signature; bh=qn8ba8EOgCDbLjlW+oUZ81b3SNJqb+icEKQ6PMnIbps=; fh=RKL4DwxyTxp1etzzfVio/nPfyc1rURzh14wHkazqBOU=; b=eEZDBXfIVxDg9OtlkYq6wcGvH5c24g+fkrBKVuWm7dr43iYDMSsUA7nlGYQpNhA3Rm oaETJ5bbnVT/YwGfAbpH6SssThcEiR4tQnqnUyAFO0DhDur3Hq2TbRBLegkUI33NOfC+ gVsWr+o9W0ZCuJ9zqOsPwZ3/4nM5d7CEm9iZU2Bp0SjVHbdLEW/o7avCTG4KIO24SbAa kiIN1FPPEIqMCjPTBwsTqtNR1EoeTDplZWiDnoa+/FS740pMYBXl7THPY7tvO24ukb98 NHb1i8PRSQft3/dY/9Ma0Cpba/QdmX2kTO06F6GwmVZ0ldbibFQkVyd9IXpBg4YYrbkt qDAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ao5OxByR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fc16-20020a056a002e1000b00665dfbf3b17si8105720pfb.264.2023.08.14.02.36.16; Mon, 14 Aug 2023 02:36:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ao5OxByR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233130AbjHNJOE (ORCPT + 99 others); Mon, 14 Aug 2023 05:14:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234211AbjHNJNh (ORCPT ); Mon, 14 Aug 2023 05:13:37 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF2F6AD; Mon, 14 Aug 2023 02:13:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 41326648E3; Mon, 14 Aug 2023 09:13:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DF27FC433C7; Mon, 14 Aug 2023 09:13:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692004415; bh=KEl0WjzhsYH00h3btT+tK17v6e+veb0lNNV8BHlMGfo=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Ao5OxByRCAkz/IF507lGgLQuDHYgQvIo0C/4fb/pnw3oDPpDSojqAdTwdmns/eoyt d5uescLUcYBKvgeEOTFjFu/R2PTvGXS32cisA7uXb9RTrCakfXJnEIVUHb+nEKOeup uwioltWhBflBbGjhfJJZiUJ99dYKvYVjhe09X9gmqOaHjAT2zfH4Tbb9aGV/WA7FKz N8lz8AFV8KpXrQju7x+HSUerpvbjJIu+hmPtYxaveUEINspMf0SeCOfQIuEv5TCGI4 xGcYtc3MpwGc01Mtx82hLD/aT7kMzBqdsbpvpLEEBlhAGVVO2oFWU1THUxOJW0BXGG eUKKJCKRdK0wQ== Date: Mon, 14 Aug 2023 11:13:31 +0200 (CEST) From: Jiri Kosina To: Daniel Thompson cc: Jonathan Cameron , Srinivas Pandruvada , Benjamin Tissoires , Bjorn Andersson , linux-input@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] HID: sensor-hub: Allow multi-function sensor devices In-Reply-To: <20230528092427.42332-1-daniel.thompson@linaro.org> Message-ID: References: <20230528092427.42332-1-daniel.thompson@linaro.org> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 28 May 2023, Daniel Thompson wrote: > The Lenovo Yoga C630 has a combined keyboard and accelerometer that > interfaces via i2c-hid. Currently this laptop either has a working > keyboard (if CONFIG_HID_SENSOR_HUB is disabled) or a working accelerometer. > only works on kernels. Put another way, most distro kernels enable > CONFIG_HID_SENSOR_HUB and therefore cannot work on this device since the > keyboard doesn't work! > > Fix this by providing a richer connect mask during the probe. With this > change both keyboard and screen orientation sensors work correctly. > > Signed-off-by: Daniel Thompson Applied. Sorry for the delay, -- Jiri Kosina SUSE Labs