Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From:   David Howells <dhowells@redhat.com>
In-Reply-To: <20230811010309.20196-2-zhanghongchen@loongson.cn>
References: <20230811010309.20196-2-zhanghongchen@loongson.cn> <20230811010309.20196-1-zhanghongchen@loongson.cn>
To:     Hongchen Zhang <zhanghongchen@loongson.cn>
Cc:     dhowells@redhat.com, Alexander Viro <viro@zeniv.linux.org.uk>,
        Christian Brauner <brauner@kernel.org>,
        Steve French <stfrench@microsoft.com>,
        Jens Axboe <axboe@kernel.dk>, David Disseldorp <ddiss@suse.de>,
        Luis Chamberlain <mcgrof@kernel.org>,
        Nick Alcock <nick.alcock@oracle.com>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        loongson-kernel@lists.loongnix.cn
Subject: Re: [PATCH v5 2/2] pipe: use __pipe_{lock,unlock} instead of spinlock
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3955286.1692002820.1@warthog.procyon.org.uk>
Date:   Mon, 14 Aug 2023 09:47:00 +0100
Message-ID: <3955287.1692002820@warthog.procyon.org.uk>
Precedence: bulk

Hongchen Zhang <zhanghongchen@loongson.cn> wrote:

> -	spin_lock_irq(&pipe->rd_wait.lock);
> +	__pipe_lock(pipe);

This mustn't sleep.  post_one_notification() needs to be callable with a
spinlock held.

David