Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Aug 2023 11:15:17 +0200 (CEST)
From:   Jiri Kosina <jikos@kernel.org>
To:     Osama Muhammad <osmtendev@gmail.com>
cc:     david.rheinsberg@gmail.com, benjamin.tissoires@redhat.com,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] hid-wiimote-debug.c: Drop error checking for
 debugfs_create_file
In-Reply-To: <20230530154252.7895-1-osmtendev@gmail.com>
Message-ID: <nycvar.YFH.7.76.2308141115050.14207@cbobk.fhfr.pm>
References: <20230530154252.7895-1-osmtendev@gmail.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Tue, 30 May 2023, Osama Muhammad wrote:

> This patch removes the error checking for debugfs_create_file
> in hid-wiimote-debug.c.c. This is because the debugfs_create_file()
> does not return NULL but an ERR_PTR after an error.
> The DebugFS kernel API is developed in a way that the
> caller can safely ignore the errors that occur during
> the creation of DebugFS nodes.The debugfs Api handles
> it gracefully. The check is unnecessary.
> 
> Link to the comment above debugfs_create_file:
> https://elixir.bootlin.com/linux/latest/source/fs/debugfs/inode.c#L451
> 
> Signed-off-by: Osama Muhammad <osmtendev@gmail.com>
> 
> ---
> changes since v1
> 	-In v1 the IS_ERR was used for error checking which is dropped now.

Now applied, sorry for the delay.

-- 
Jiri Kosina
SUSE Labs