Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Aug 2023 15:52:26 +0800
From:   Yan Zhao <yan.y.zhao@intel.com>
To:     Nadav Amit <nadav.amit@gmail.com>
CC:     linux-mm <linux-mm@kvack.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        <kvm@vger.kernel.org>, Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Mike Kravetz <mike.kravetz@oracle.com>, <apopple@nvidia.com>,
        Jason Gunthorpe <jgg@nvidia.com>,
        Mike Rapoport <rppt@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        <kevin.tian@intel.com>, <david@redhat.com>
Subject: Re: [RFC PATCH v2 4/5] mm/autonuma: call .numa_protect() when page
 is protected for NUMA migrate
Message-ID: <ZNndOm4EW5eIokJJ@yzhao56-desk.sh.intel.com>
Reply-To: Yan Zhao <yan.y.zhao@intel.com>
References: <20230810085636.25914-1-yan.y.zhao@intel.com>
 <20230810090048.26184-1-yan.y.zhao@intel.com>
 <8735E3A2-795B-4D52-9634-D48C68645A5D@gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <8735E3A2-795B-4D52-9634-D48C68645A5D@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?REZWSm9GSTNZUThMV3ZYRnQ5T1ZMeEJUMkc3YVdvRU9NMW10Ynk0YThzdmRJ?=
 =?utf-8?B?aWZqYlRhb2JoWTRtSGFVV3l2eTBuSXlKSHRhc3FubHBrUW10S2l1cm9NVTNR?=
 =?utf-8?B?TDdvdXMvakxyWmY1S2dtaWYxdi9MQUdpWnJySFJHK0E1bkJ2azJPVTdWeWZL?=
 =?utf-8?B?Y0JwQW1abTN0MmkvYnpDcS9aZXRyQlU1L1NxOTlnblVDYmMwT1pNTVRYd2ND?=
 =?utf-8?B?Ukg0YWtNVmxhQy94OXE1cHl6QkFxYS9qT0gveldvNWNJUkhkbHh5OTRlemJR?=
 =?utf-8?B?QXR5dGhUQmlEQlZEYTVUdkprbWo1VUlRU0t6clZqNkF1Q3BYeGxlMEdmb0xL?=
 =?utf-8?B?czBQSXFDK2tHV2k0Z00weTMxamIxSHRkSWthR2ZCWFQ0NHlHYXp6RTJOTndL?=
 =?utf-8?B?YTIyMHFEWmVWVkYyZGI4TDg2NGNYWXg0ZG05amdnM3IvU285OCtOOFFSZURz?=
 =?utf-8?B?czlxWFdlTTc5dytWTkhoMGRqcXdXZHFSZkcvSktOdXE1NGRuR1grUzFBUGRD?=
 =?utf-8?B?RGZrTW5BQ3pQTEF0RkJ0c1hQNTU4Z0V0MEQ3Ny9LVllNeUtkOVVHVHJiR2Iv?=
 =?utf-8?B?cVRFbXc2MjdKcDhiVFpiR2JTYjBGY1RaL045WkFta0hHNXcrRmsrcTFNYWpp?=
 =?utf-8?B?RXk0cnVZbXp4YnNidm55My93L1I5VHcwaUdpTmNqNW5CL1BDK1d0SEdCWWZH?=
 =?utf-8?B?bDhJelVMU25IWjU4VFEvb3lQQjEyandtUHNjY283STVscHVZajN3bVhEbURB?=
 =?utf-8?B?OTl2Wm1haXc3YTR3YU16TEdtNUpmcVJweXdzNWpyRWVRQjk0T0xQbzBXNlhN?=
 =?utf-8?B?Q0xoYnI3Q1pxUDF0RjBIZW5mVEtkY0hmK3R6NDdkN2pIYXRNTUloazllMDhR?=
 =?utf-8?B?ZEpqZ0EzVWVnUXUrYUw2bXpPUFVNQXhUamZ6dC9MNlBGbEU5T1BpOTNUcjNy?=
 =?utf-8?B?S25vUWhHUXhpdGUxSDkxT1pteGtwWGo1VUFTNWRIdVg5a21QY20xWlREM2Uv?=
 =?utf-8?B?bTJJOXVpQUFRN282Z2VBOENFK2FPZHBYbk9nVExCcVhBak1ONFVicGlJaGx2?=
 =?utf-8?B?SWNuNFVJNU85NjZxd1VhLzBkVHVNQWhuQjVZSG9QWHcrRFBqQTdjakZrUHUw?=
 =?utf-8?B?bzlyWnNYaFAyeUtzRHZhU1ZrQW1ESWhJLzd3YmdQZ2hwNThLZUZHblJOQ0xs?=
 =?utf-8?B?SDdLTkRYMnBCeFpoNjlaSyticVkxeHdDOXcvbWFnU3lXbFlxQS9CZmlCY0FE?=
 =?utf-8?B?Vzc5ZDBrUEU4QkhvaXEvck5Tc3B0RmZVWE1WWWlEd2RPYlB6WmFIb2dhNU9T?=
 =?utf-8?B?Vi9sbHZvdmY0c2FMVTF1SGY3RU02NXBoSFVjbnJqUXhRemc5Zld6M0JrV2k2?=
 =?utf-8?B?M0c3NnVIQkE2NjdxK2lnT1VCWS94WmFmcUhpR1l0MWxRRWtnY3Y3bWNzQmE2?=
 =?utf-8?B?ZXhCeTFsR0RieTAvWlR5cjY1YnJMcnJmRG84N1EyQVFCVVhFVTBuczIvSlk2?=
 =?utf-8?B?OGdaZTAwYjJsM0svL2ppTkpkdWZ1d25mN1pFZVdnQzFuOGlwSmNwRWNtYXhl?=
 =?utf-8?B?RmVmQmpvWjlvclZaRzVLRERsa3ltbXRDQW5iS0NseVFjVzVmeXh5ZFNGOU9B?=
 =?utf-8?B?bDEwcXNxSjRHMXZ2UitPVURnQXIxTHRXS2FoZk9Vd2lpNW9xdm1HTkRJMUVV?=
 =?utf-8?B?cnJzd0RWbkQ5Vnk1eXpPcWhuekRJc0dXYTN0QmE1bytmeGgyY09zUTRvZWdK?=
 =?utf-8?B?TEpNZ0d6TnAwSkVaU2R3RnpaeGl5dXRXMmxRWVlId3FwalZZWk5ETUhIZzR5?=
 =?utf-8?B?VWtTTkc2ODBKaE5hRW8wU2tFNEw3RlY3ME9ULzZTS3lXNXJ1cUxSaTJLWGVn?=
 =?utf-8?B?dnJVVXhRbnpiRTdPTC82VE1FQjZSOVFVd09rci9CcFNYYzBrMXpVWU1ZN1hn?=
 =?utf-8?B?aGQvQnZzdEQ0YlBWbEJPVDJHb2loNVhEc2k5aU9uTHFDVVgzSTVCZmhXMlA3?=
 =?utf-8?B?MWZUN3dmZWtKMXlNOGRaRU10TWhBQkpiVjFiK2djaktlWi9Rd0kvazdTMW5m?=
 =?utf-8?B?elBQQ1V4T3ViRDZRTHJkYlpvT25IenF1ODY1anV3SmlncFhWZkk4Z3ZURm1a?=
 =?utf-8?Q?1mvyHgDozkwH27HKr3EXItx3a?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c3964fb-aa30-468c-7bd2-08db9c9f2c6e
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2023 08:19:26.3656
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oQei/v9f6PBUhzYO1KbQbDyuUSWG/2fn0nDCRny5ocm9F+jGAX88SYBlOxRTymhQ2OYwfkaBLk8cDIeKyB/81g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6651
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Aug 11, 2023 at 11:52:53AM -0700, Nadav Amit wrote:
> 
> > On Aug 10, 2023, at 2:00 AM, Yan Zhao <yan.y.zhao@intel.com> wrote:
> > 
> > Call mmu notifier's callback .numa_protect() in change_pmd_range() when
> > a page is ensured to be protected by PROT_NONE for NUMA migration purpose.
> 
> Consider squashing with the previous patch. It’s better to see the user
> (caller) with the new functionality.
> 
> It would be useful to describe what the expected course of action that
> numa_protect callback should take.
Thanks! I'll do in this way when I prepare patches in future :)