Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Mon, 14 Aug 2023 09:43:02 +0200
Message-Id: <CUS3KXRIND5J.VSB0PVWXZ4DO@otso>
To:     "Fenglin Wu" <quic_fenglinw@quicinc.com>,
        <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <robh+dt@kernel.org>,
        <agross@kernel.org>, <andersson@kernel.org>,
        <dmitry.baryshkov@linaro.org>
Cc:     <quic_collinsd@quicinc.com>, <quic_subbaram@quicinc.com>,
        <quic_kamalw@quicinc.com>, <jestar@qti.qualcomm.com>
Subject: Re: [PATCH v4 0/3] Add support for vibrator in multiple PMICs
From:   "Luca Weiss" <luca.weiss@fairphone.com>
References: <20230731053712.2220898-1-quic_fenglinw@quicinc.com>
In-Reply-To: <20230731053712.2220898-1-quic_fenglinw@quicinc.com>
Precedence: bulk

Hi Fenglin,

On Mon Jul 31, 2023 at 7:37 AM CEST, Fenglin Wu wrote:
> Add SW support for the vibrator module inside PMI632, PM7250B, PM7325B, P=
M7550BA.
> It is very similar to the vibrator module inside PM8916 which is supporte=
d in
> pm8xxx-vib driver but just the drive amplitude is controlled with 2 regis=
ters,
> and the register base offset in each PMIC is different.

Briefly tested on a SDM632+PMI632-based Fairphone 3.

I didn't really check for vibration strength or anything more detailed
but with the fftest tool the vibrator seems to work fine!

Diff is attached below. I can send the pmi632.dtsi change once this
series is merged (unless you send something first).

Many thanks for sending these patches!

Tested-by: Luca Weiss <luca.weiss@fairphone.com> # sdm632-fairphone-fp3 (pm=
i632)

Regards
Luca


diff --git a/arch/arm64/boot/dts/qcom/pmi632.dtsi b/arch/arm64/boot/dts/qco=
m/pmi632.dtsi
index 4eb79e0ce40a..41ef7dad508e 100644
--- a/arch/arm64/boot/dts/qcom/pmi632.dtsi
+++ b/arch/arm64/boot/dts/qcom/pmi632.dtsi
@@ -161,5 +161,11 @@ pmi632_lpg: pwm {
=20
 			status =3D "disabled";
 		};
+
+		pmi632_vib: vibrator@5700 {
+			compatible =3D "qcom,pmi632-vib", "qcom,spmi-vib-gen2";
+			reg =3D <0x5700>;
+			status =3D "disabled";
+		};
 	};
 };
diff --git a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts b/arch/arm64=
/boot/dts/qcom/sdm632-fairphone-fp3.dts
index 301eca9a4f31..0d89bc39f613 100644
--- a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
+++ b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
@@ -112,6 +112,10 @@ led@3 {
 	};
 };
=20
+&pmi632_vib {
+	status =3D "okay";
+};
+
 &sdhc_1 {
 	status =3D "okay";
 	vmmc-supply =3D <&pm8953_l8>;

> Changes in v4:
>   1. Update to use the combination of the HW type and register offset
>      as the constant match data, the register base address defined in
>      'reg' property will be added when accessing SPMI registers using
>      regmap APIs.
>   2. Remove 'qcom,spmi-vib-gen1' generic compatible string.
>
> Changes in v3:
>   1. Refactor the driver to support different type of the vibrators with
>     better flexibility by introducing the HW type with corresponding
>     register fields definitions.
>   2. Add 'qcom,spmi-vib-gen1' and 'qcom,spmi-vib-gen2' compatible
>     strings, and add PMI632, PM7250B, PM7325B, PM7550BA as compatbile as
>     spmi-vib-gen2.
> =20
> Changes in v2:
>   Remove the "pm7550ba-vib" compatible string as it's compatible with pm7=
325b.
>
> Fenglin Wu (3):
>   input: pm8xxx-vib: refactor to easily support new SPMI vibrator
>   dt-bindings: input: qcom,pm8xxx-vib: add new SPMI vibrator module
>   input: pm8xxx-vibrator: add new SPMI vibrator support
>
>  .../bindings/input/qcom,pm8xxx-vib.yaml       |  16 +-
>  drivers/input/misc/pm8xxx-vibrator.c          | 171 ++++++++++++------
>  2 files changed, 132 insertions(+), 55 deletions(-)