Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jernej =?utf-8?B?xaBrcmFiZWM=?= <jernej.skrabec@gmail.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Martin Botka <martin.botka@somainline.org>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Chen-Yu Tsai <wens@csie.org>,
        Samuel Holland <samuel@sholland.org>,
        Maxime Ripard <mripard@kernel.org>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev,
        linux-kernel@vger.kernel.org,
        Andre Przywara <andre.przywara@arm.com>,
        Alan Ma <tech@biqu3d.com>,
        Marijn Suijten <marijn.suijten@somainline.org>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@somainline.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: nvmem: SID: Add binding for H616 SID
 controller
Date:   Mon, 14 Aug 2023 12:28:36 +0200
Message-ID: <5856748.MhkbZ0Pkbq@jernej-laptop>
In-Reply-To: <DKGDZR.4G4SZ781MVSV2@somainline.org>
References: <20230814-sid-h616-v2-0-0267749b4471@somainline.org>
 <830e5e34-f6de-3233-4a12-06c8390169d1@linaro.org>
 <DKGDZR.4G4SZ781MVSV2@somainline.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Precedence: bulk

Dne ponedeljek, 14. avgust 2023 ob 10:21:49 CEST je Martin Botka napisal(a):
> On Mon, Aug 14 2023 at 10:08:38 AM +02:00:00, Krzysztof Kozlowski
> 
> <krzysztof.kozlowski@linaro.org> wrote:
> > On 14/08/2023 08:38, Martin Botka wrote:
> >>  Add binding for the SID controller found in H616 SoC
> >>  
> >>  Signed-off-by: Martin Botka <martin.botka@somainline.org>
> >>  ---
> >> 
> >> Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
> >> 
> >> | 1 +
> >> | 
> >>   1 file changed, 1 insertion(+)
> >>  
> >>  diff --git
> >> 
> >> a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
> >> b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
> >> 
> >>  index 296001e7f498..2ec0a1b8f803 100644
> >>  ---
> >> 
> >> a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
> >> 
> >>  +++
> >> 
> >> b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
> >> 
> >>  @@ -27,6 +27,7 @@ properties:
> >>             - const: allwinner,sun50i-a64-sid
> >>         
> >>         - const: allwinner,sun50i-h5-sid
> >>         - const: allwinner,sun50i-h6-sid
> >>  
> >>  +      - const: allwinner,sun50i-h616-sid
> > 
> > It does not look like you tested the DTS against bindings. Please run
> > `make dtbs_check` (see
> > Documentation/devicetree/bindings/writing-schema.rst or
> > https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sour
> > ces-with-the-devicetree-schema/ for instructions).
> > 
> > Best regards,
> > Krzysztof
> 
> Yea completely forgot. Sorry for that.
> 
> Will send v3 tomorrow with proper binding patch using items with enums

Don't. You have cca. 1 month time now, since you missed at least window for DT 
changes for 6.6.

Best regards,
Jernej