Received: by 2002:a05:7412:6592:b0:d7:7d3a:4fe2 with SMTP id m18csp2474971rdg; Mon, 14 Aug 2023 04:00:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFZEEjrOanLNna6S4dQASJRR6l1mzT2JDfUVkQLQtuTDtUsT7+tTeOQlmeDe7fTjFqVjrBK X-Received: by 2002:a05:6358:590e:b0:139:d6cf:c430 with SMTP id g14-20020a056358590e00b00139d6cfc430mr5115738rwf.6.1692010810330; Mon, 14 Aug 2023 04:00:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692010810; cv=none; d=google.com; s=arc-20160816; b=ap3RvHq+v8M2xdEl4PWNL+YN3kWKWJrvmhpUqh8MlvBxZS/Iv1uWhzCkNNHCNVOssy okMqsaKlm8CGaakq2fFGTlIix8JqB7SYjM7amK+cXUb9GAQM4A3wF6yqHMYPapMLmuGj H8ZRbi6X9TVQXe6dw+AN+M84n2vFuhvpgHr6YRLZYgveN+teA+jnKS2sflDCWdVS3RtQ GNDSwrZjEZXFoyZfb0JGv/eNlFAd94NvH5Uonttml06/wUVIlYV+u7qHyK/L2GGIu0M2 h/ivkrEu0Tl1orL+A8Fi4H0scz5jyFwjsO42KJVTC7zN1kiz7zWsizUeu+GZ3wGePxfp ZiCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=bJqXGCy/gpr1h/aO3Ck0Euv7gooGxx1elpuOZaq8EvE=; fh=5VnmXmoZBR4+6qVIfQDiLcsiW+SDqIu0KJ6MYk3TKH8=; b=NTWvjVhI2FGtU967gkSUjnz647d8nvjMh+GaG9yN95wfFa4ByxfouUrvNZorC5Sl6k NqeAgZqB+M7pZPNVx8y9QoEF8Prw18AOqvlEnQQ1EviXfpaT+G64wevmrV2jxVsWK98y Sp1de8jUhgcenwt7ZjxxFR5C8C52MLWYS5jYssPzB4CRC5KpgO6numIamNytWul0USgP JHN7CIAmCR5wml2j4/zqclVs7UzJ6U5aDMLr/eyCVvt+8LZDjTiShJb6VJekVNiuQSio y8puzxHTO/5mko9tC2pXvKFN6NNit3jzDaI1w1NTH7H1R37Yk4aC8JpFD3zVhQL6l7t/ UkYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bgdev-pl.20221208.gappssmtp.com header.s=20221208 header.b=LyLXa2V4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fj16-20020a056a003a1000b0068761c460bdsi7891287pfb.32.2023.08.14.03.59.58; Mon, 14 Aug 2023 04:00:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20221208.gappssmtp.com header.s=20221208 header.b=LyLXa2V4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235396AbjHNJhK (ORCPT + 99 others); Mon, 14 Aug 2023 05:37:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233095AbjHNJgq (ORCPT ); Mon, 14 Aug 2023 05:36:46 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45B79E61 for ; Mon, 14 Aug 2023 02:36:28 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-31427ddd3fbso3649369f8f.0 for ; Mon, 14 Aug 2023 02:36:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20221208.gappssmtp.com; s=20221208; t=1692005787; x=1692610587; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=bJqXGCy/gpr1h/aO3Ck0Euv7gooGxx1elpuOZaq8EvE=; b=LyLXa2V4NI6PO4VZFVGTWc0e8Wsz3VR38cS1s9jSyivCPz8OQhvGMxWr4nQFpcKiTY yAgp53thwMTUdth1yteKIiiJzNMazdvc8BWgzvsT3Ow4ZSW/5VhzpClshf2l4aFJ3ORo 7YM1Xp5sjHt5azbb7hOhNC59z0p51T0PHvRTCJiwgpK4epqqF0IymkbIlRIPGUKPhtPG yn+IvVSgzkna02IJzbvJeuPD08wbqsgj3nGVi+dPcWuJ6iBl6QXhLrxfsqBKgF47QRqI /iwyjYT1MQ1CJeJnnrU+ezPUMTrjSNBbCfxKc6HyqP8vTw/bpFSc7luYF3jgUlCNbFCN VjTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692005787; x=1692610587; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bJqXGCy/gpr1h/aO3Ck0Euv7gooGxx1elpuOZaq8EvE=; b=LUrbP+Y8RhZ2GJir/4er+SvyEnlX0F7XYekW9bKh/YqOYmVfV5KR5dO5bsEA5AcaGU Odz7QnGX8KM6BsbshRFztcpkJICyCZZxdzkbYnj+/9RyM511XhFT4o7i9KQKbg0Y59G2 vkZjiXDrmKf/tg44P3EFxzqv3dZ9k6yb+aooXIWX3H95X4PJrWUOSRlnJRicu9bHPhJc nwlYKEKFqh3nOETUzA7/XMUnAJDR86B06oors+0GjXw67mqqDngOtXhq2/yyFozNr16K 2UDSsqbOKFWZ7qRH6B//Z1UCelWoCS+jLftoRLA+FW0mhByHu4OA8txBH3/WnQdSu8JB RPLA== X-Gm-Message-State: AOJu0YwBmVPcF64jR9u8l26yCFFAPP26DNn8nG8po6FUAvway00eqUxx 7z5t9oP0kq9k/6MwOGJkMDmxtQ== X-Received: by 2002:adf:f590:0:b0:317:5ddb:a8bf with SMTP id f16-20020adff590000000b003175ddba8bfmr5819049wro.29.1692005786371; Mon, 14 Aug 2023 02:36:26 -0700 (PDT) Received: from brgl-uxlite.home ([2a01:cb1d:334:ac00:d0cb:d23e:f2fb:62b4]) by smtp.gmail.com with ESMTPSA id d17-20020adfe851000000b003197839d68asm2422140wrn.97.2023.08.14.02.36.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Aug 2023 02:36:26 -0700 (PDT) From: Bartosz Golaszewski To: Thomas Gleixner , Marc Zyngier Cc: linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH 0/2] genirq: don't leak handler procfs entries Date: Mon, 14 Aug 2023 11:36:19 +0200 Message-Id: <20230814093621.23209-1-brgl@bgdev.pl> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bartosz Golaszewski When we remove the procfs entry for an irq desc that's still in use, we leak the procfs entries created per handler. We need to go through the irqaction chain and remove all entries before finally removing the irq's top procfs directory. First patch drops an unused argument from unregister_handler_proc(), the second fixes the actual leak. Bartosz Golaszewski (2): genirq: proc: drop unused argument from unregister_handler_proc() genirq: proc: fix a procfs entry leak kernel/irq/internals.h | 5 ++--- kernel/irq/manage.c | 6 +++--- kernel/irq/proc.c | 17 ++++++++++++++++- 3 files changed, 21 insertions(+), 7 deletions(-) -- 2.39.2