Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Aug 2023 16:05:05 +0530
From:   Nitesh Shetty <nj.shetty@samsung.com>
To:     Bart Van Assche <bvanassche@acm.org>
Cc:     Jens Axboe <axboe@kernel.dk>, Jonathan Corbet <corbet@lwn.net>,
        Alasdair Kergon <agk@redhat.com>,
        Mike Snitzer <snitzer@kernel.org>, dm-devel@redhat.com,
        Keith Busch <kbusch@kernel.org>,
        Christoph Hellwig <hch@lst.de>,
        Sagi Grimberg <sagi@grimberg.me>,
        Chaitanya Kulkarni <kch@nvidia.com>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Christian Brauner <brauner@kernel.org>,
        Kanchan Joshi <joshi.k@samsung.com>,
        martin.petersen@oracle.com, linux-doc@vger.kernel.org,
        gost.dev@samsung.com, Anuj Gupta <anuj20.g@samsung.com>,
        linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
        linux-block@vger.kernel.org, mcgrof@kernel.org, dlemoal@kernel.org,
        linux-fsdevel@vger.kernel.org
Subject: Re: [dm-devel] [PATCH v14 01/11] block: Introduce queue limits and
 sysfs for copy-offload support
Message-ID: <20230814103505.rjcv4esakiqpndnl@green245>
MIME-Version: 1.0
In-Reply-To: <170b68ca-b24c-0723-cc54-7fcdc9004bcc@acm.org>
User-Agent: NeoMutt/20171215
Content-Type: multipart/mixed;
        boundary="----Ax27aEWlRRTyCTKvLJGz44CsYuK4yEI58Kfkn8Ic_yMAot59=_545b7_"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <20230811105300.15889-1-nj.shetty@samsung.com>
        <CGME20230811105638epcas5p4db95584b6a432ea4b8b93e060a95e5f1@epcas5p4.samsung.com>
        <20230811105300.15889-2-nj.shetty@samsung.com>
        <170b68ca-b24c-0723-cc54-7fcdc9004bcc@acm.org>
Precedence: bulk

------Ax27aEWlRRTyCTKvLJGz44CsYuK4yEI58Kfkn8Ic_yMAot59=_545b7_
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Disposition: inline

On 23/08/11 02:56PM, Bart Van Assche wrote:
>On 8/11/23 03:52, Nitesh Shetty wrote:
>>+/* maximum copy offload length, this is set to 128MB based on current testing */
>>+#define COPY_MAX_BYTES		(1 << 27)
>
>Since the COPY_MAX_BYTES constant is only used in source file
>block/blk-settings.c it should be moved into that file. If you really
>want to keep it in include/linux/blkdev.h, a BLK_ prefix should
>be added.
>
We are using this in other files. So we will add a prefix BLK_.

Thank you,
Nitesh Shetty

------Ax27aEWlRRTyCTKvLJGz44CsYuK4yEI58Kfkn8Ic_yMAot59=_545b7_
Content-Type: text/plain; charset="utf-8"


------Ax27aEWlRRTyCTKvLJGz44CsYuK4yEI58Kfkn8Ic_yMAot59=_545b7_--